From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 3F00E5F4D for ; Tue, 2 Oct 2018 16:59:51 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id b19-v6so2601921wme.3 for ; Tue, 02 Oct 2018 07:59:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=NuBNs88Bw2ol1jeRM/6pvNdSfnTkI0hxoC53QeXj0yk=; b=rQUoIdU00Dgv4rwoL4wddR0E92j6uZSBAw69WMNs8UVfZAC12Ztwvrs5xvvhClwWsU OwrNJvRl5rh3/3gcMO6/+EJRM/eJ96E+L5fk4Hk5ncKFU/YMM+eZFRsEeyJYscEWvCvY AfzsOr8wleoX/Ga4xIg4oEkdgxFqrdrvSE4M3pSymEnDpxKpakVz8p6swBw4PLnQ/2i0 eC2Kpvkr/kdBHDYa1IZWO4SeFWoJR2odt/SkZ7vobnSvu56wbgTrYxeYQ/o9gTFT7cQS dMzPrFJQ4Oe0+5vdtE8QWYYsOdSbRoZ8eqPYTuJvkEiOODvONxixS9f2YMhwywdDJXtX Qt6g== X-Gm-Message-State: ABuFfohUeyUHSZhbhvMKKEHu3pFkuOahp0f6X4mYueterIdSSFzehxvE yJLOY/TVNRiuzDyD5icvzOQ= X-Google-Smtp-Source: ACcGV625Ridy5m/7tC77Vu0jI5g85Z0j1Pxm5xWKeBvzQRHSQwZ4/6ZJi5hzV5WEljt6XgZj0vewVQ== X-Received: by 2002:a1c:f4e:: with SMTP id 75-v6mr2066590wmp.79.1538492390793; Tue, 02 Oct 2018 07:59:50 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id j66-v6sm18519869wrj.28.2018.10.02.07.59.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Oct 2018 07:59:49 -0700 (PDT) Message-ID: <1538492388.4835.6.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, tredaelli@redhat.com, christian.ehrhardt@canonical.com, mvarlese@suse.de Date: Tue, 02 Oct 2018 15:59:48 +0100 In-Reply-To: <20181002142805.GA13012@bricha3-MOBL.ger.corp.intel.com> References: <20180928175803.12955-1-bluca@debian.org> <20181002130646.14919-1-bluca@debian.org> <20181002130646.14919-2-bluca@debian.org> <20181002142805.GA13012@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] build: add drivers_install_subdir meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 14:59:51 -0000 On Tue, 2018-10-02 at 15:28 +0100, Bruce Richardson wrote: > On Tue, Oct 02, 2018 at 02:06:46PM +0100, Luca Boccassi wrote: > > Allow users and packagers to override the default dpdk/drivers > > subdirectory where the PMDs get installed under $lib. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 10 +++++++= +-- > > =C2=A0meson_options.txt |=C2=A0=C2=A02 ++ > > =C2=A02 files changed, 10 insertions(+), 2 deletions(-) > >=20 > > diff --git a/meson.build b/meson.build > > index 4bd04b9de3..9f7f17f7fe 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -20,8 +20,14 @@ dpdk_extra_ldflags =3D [] > > =C2=A0pver =3D meson.project_version().split('.') > > =C2=A0major_version =3D '@0@.@1@'.format(pver.get(0), pver.get(1)) > > =C2=A0 > > -driver_install_path =3D join_paths(get_option('libdir'), 'dpdk', > > - 'pmds-' + major_version) > > +pmd_subdir_opt =3D get_option('drivers_install_subdir') > > +if pmd_subdir_opt =3D=3D 'dpdk/pmds-XX.YY' > > + driver_install_path =3D join_paths(get_option('libdir'), > > + 'dpdk', 'pmds-' + major_version) > > +else > > + driver_install_path =3D join_paths(get_option('libdir'), > > + pmd_subdir_opt) > > +endif >=20 > Not sure I like this degree of hard-coding of paths. While meson > doesn't > have a string replace function, we can still use "sed" via > run_command to > perform some substitution, or else get a little creative using split > if it > can be made work. That would allow us to put in e.g "" as a > generic placeholder in the text. >=20 > /Bruce Do you mean for the "if pmd_subdir_opt =3D=3D 'dpdk/pmds-XX.YY'" bit? I can change that to "=3D=3D 'dpdk/pmds-'" if you prefer? --=20 Kind regards, Luca Boccassi