From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id AB1085F35 for ; Wed, 3 Oct 2018 18:18:10 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id x12-v6so6804875wru.8 for ; Wed, 03 Oct 2018 09:18:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=TDjpJklKKK5+GUznl/p3CVZ96AzxyE3JWvdCEvlJP6o=; b=VwuIfzGKprUlBm6aX/ho3+J3x5p7lCSR5UaTd+kPk0AnXxXN+L0QDsuqRO/wBxFAZ/ E5hmoiEaXsdVpN7d9ZTRJgPr7VKPtQD8RZ0FzEaRy9GnnpH5v7nF3G5+TgiS3gO6ZlP7 /TRrnlCDbFSd/gMwzmCZF08JKgF3vEtKGKzb6zoMZaGsvEKeY9iXt5WmKQOnGqgNBwXO VfflCec7sOGH6eEUs9Gu669GJA2UF0v27PftSK6XgfQpirY1iiBu7dNyGT2BxTB+8IuJ MDbfm1115M6mAam2tKAuJprsCVOnqDUtGHlDctXbahMTbWo9vY6cKnt2ULfKcgRsC2S/ wPJw== X-Gm-Message-State: ABuFfogxqvQOBMQlZ5VSr56xedM+OpG0JVlr3IFOoL0ab71W20KRPbxQ 4BYw4dtitmCRLSnK90Ztzzs= X-Google-Smtp-Source: ACcGV6128y988drMxoJzIu8RwbFxPq6ypT20YJOi8dvrbZvNgCSk+ljm1KTx8UsjFAi6Q8xAZCCReA== X-Received: by 2002:a5d:4b50:: with SMTP id w16-v6mr1698954wrs.173.1538583490236; Wed, 03 Oct 2018 09:18:10 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 12-v6sm2936323wms.11.2018.10.03.09.18.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Oct 2018 09:18:08 -0700 (PDT) Message-ID: <1538583488.8721.0.camel@debian.org> From: Luca Boccassi To: "Ananyev, Konstantin" , Thomas Monjalon Cc: "dev@dpdk.org" Date: Wed, 03 Oct 2018 17:18:08 +0100 In-Reply-To: <2601191342CEEE43887BDE71AB977258EA95B16D@irsmsx105.ger.corp.intel.com> References: <1535129226-25510-1-git-send-email-konstantin.ananyev@intel.com> <1912621.YvyjYky8PI@xps> <1537878167.10481.46.camel@debian.org> <2601191342CEEE43887BDE71AB977258EA95B16D@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 16:18:10 -0000 On Tue, 2018-09-25 at 14:34 +0000, Ananyev, Konstantin wrote: > Hi Luca, >=20 > >=20 > > On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > > > 24/08/2018 18:47, Konstantin Ananyev: > > > > If user specifies priority=3D0 for some of ACL rules > > > > that can cause rte_acl_classify to return wrong results. > > > > The reason is that priority zero is used internally for no- > > > > match > > > > nodes. > > > > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=3D79. > > > > The simplest way to overcome the issue is just not allow zero > > > > to be a valid priority for the rule. > > > >=20 > > > > Fixes: dc276b5780c2 ("acl: new library") > > > >=20 > > > > Signed-off-by: Konstantin Ananyev > > > > > > >=20 > > > Cc: stable@dpdk.org > > >=20 > > > Applied with below title, thanks > > > acl: forbid rule with priority zero > >=20 > > Hi, > >=20 > > This patch is marked for stable, but it changes an enum in a public > > header=C2=A0 >=20 > Yes it does. >=20 > > so it looks like an ABI breakage? Have I got it wrong? >=20 > Strictly speaking - yes, but priority=3D0 is invalid value with current > implementation. > I don't think someone uses it - as in that case acl library simply > wouldn't work > correctly. > Konstantin Ok, I'll include this patch in 16.11.9 then, thanks for clarifying. --=20 Kind regards, Luca Boccassi