From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 242C61B91D for ; Fri, 12 Oct 2018 17:13:49 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 143-v6so12590315wmf.1 for ; Fri, 12 Oct 2018 08:13:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=GiR4aL+MNh32fgKU6w95nPnIgoD7WMmMPZ19pEGoOuI=; b=VR5xngIexSX968//BLn7tL4PhwfblVa9MH8f0d3p6gg62DZszsZe2DKZ6GN4o22qZj TK58zImB4g+L1IwGpldCnLnREBcC8F1aQDjflpT8OEXnt0b4fuWFFEp8kJDE5ZJhlaYL jpkbfMRL5y9ng9JIod1oimprQi6nlCFKznyp7g+8uttj+kWwR10fZCM+gHehqn6yy1bP bf+dD8fjjck4TpsGZV6NVU7UXMCAmpUhfcbj6x8u+KE8UT0bI1onESgVudGjQ/V9REWK 51AuOiw/AEvkd06w63EjyPcF/RbtynR7koFbeQZdpRYKsJ4DcH048j/BTc3JyfqzY74J av8g== X-Gm-Message-State: ABuFfog41MggutZ293Tuy9KM0QVoX2lFrM5f52bSorbYOeekOZFBGSVf R5+eUTG5eLe+uFDgzjN8Gxk= X-Google-Smtp-Source: ACcGV61nAqgbYiJbRoDaecsUVusxQbByMJqJkFaT6dz9lUU4QCSFLiRXfiQ5AjiECicozH+aNU2szw== X-Received: by 2002:a1c:a90:: with SMTP id 138-v6mr5726820wmk.49.1539357228714; Fri, 12 Oct 2018 08:13:48 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id e6-v6sm1208590wrc.70.2018.10.12.08.13.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 08:13:47 -0700 (PDT) Message-ID: <1539357226.8721.43.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 12 Oct 2018 16:13:46 +0100 In-Reply-To: <20181012140930.GA21308@bricha3-MOBL.ger.corp.intel.com> References: <20181011194629.4699-1-bluca@debian.org> <20181012140930.GA21308@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 15:13:49 -0000 On Fri, 2018-10-12 at 15:09 +0100, Bruce Richardson wrote: > On Thu, Oct 11, 2018 at 08:46:29PM +0100, Luca Boccassi wrote: > > A Kbuild is also included to allow users to use DKMS natively > > without > > additional code. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > build-tested on debian sid am64 > >=20 > > =C2=A0kernel/linux/kni/Kbuild=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2= =A0=C2=A08 ++++++ > > =C2=A0kernel/linux/kni/meson.build | 51 > > ++++++++++++++++++++++++++++++++++++ > > =C2=A0kernel/linux/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2= =A02 +- > > =C2=A03 files changed, 60 insertions(+), 1 deletion(-) > > =C2=A0create mode 100644 kernel/linux/kni/Kbuild > > =C2=A0create mode 100644 kernel/linux/kni/meson.build > >=20 >=20 > I get a couple of errors building this on Fedora 28. First problem is > that > I get a compilation error for a missing rte_fifo.h. The fix for that > error > is to ensure the current dir is on the include list: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0' -I' + meson.build_root() + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0' -I' + meson.current_source_dir() + > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0' -I' + meson.current_source_dir() + '/ethtool/ixgb= e' > + >=20 > Then I hit a second error, where the compile fails because the output > directory for the ethdev files does not exist.=C2=A0 >=20 > Fatal error: can't create /home/bruce/dpdk-clean/build-gcc- > static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o: No such file > or directory > make[1]: *** [scripts/Makefile.build:318: /home/bruce/dpdk- > clean/build-gcc- > static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o] Error 2 >=20 > I haven't fixed this, but I think the easiest fix is probably to > split the > file lists so that each file is listed in a meson.build in its own > subdirectory. Then using subdir to build up the file list rather than > having it all at one gom should cause meson to create the > subdirectory > structure in the build directory. > There may be other, better solutions, though. >=20 > /Bruce Hi, Interesting, I guess it's down to differences between the kernel makefiles in Debian and Fedora? Although the include one is strange. I've sent a v2 with your suggestions, please give it a run when you've got a sec. --=20 Kind regards, Luca Boccassi