From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id B6EDA1BAFD for ; Fri, 12 Oct 2018 19:06:43 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id 185-v6so13660202wmt.2 for ; Fri, 12 Oct 2018 10:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=i4LvYFZrWHkJzAzsOkpVgfg143r4KiBwauhUeY1mixs=; b=h5FA+Q1PTv3sV62qkfL4pWbM4enGjaCqHIxPl8MDgp3khvvjcT8FgJI4N1Am1X9Y1I OkNlWWNTzefXq7nf6Via2FnR0BHRUP9uRXI0m7yjgIpT1aI0XetE1XMeLDN/0UmJmMf+ 3lxJ1uWgx14N8liN2m3M8yfVWTcCszMaOU46y+Nvc7d01F/oEalESMuF0WdT/yy1gg7J wCMdV9puGpebuUjLL/WDJNnIxlQ29u4BmWXf5VOY+7/aO5bQKlx0MIrbNEbbqlCAzlJZ oxpfSWweAyeAwpEDKz6t6G5XXhwMvTWHja7xdBAcKo8LqGvXE5QQ/y5seZbI69gMQzqi UNOQ== X-Gm-Message-State: ABuFfogaK2N6DzKRLW/MhnjBQ5+I6+drb6toVAdHpneprurtyuQd3NMX 7uKLm4WBM0IzfiFaIStO7UM= X-Google-Smtp-Source: ACcGV629+HLiA7QuHw2XCtyg+pV8ZkdpVTrPjg9QXopJZ1ftPS/cDUd+3ZYxpDd4ZQEMgTaV6r9QCw== X-Received: by 2002:a1c:a8c2:: with SMTP id r185-v6mr5657647wme.8.1539364003351; Fri, 12 Oct 2018 10:06:43 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id k1-v6sm1514341wrl.39.2018.10.12.10.06.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 10:06:42 -0700 (PDT) Message-ID: <1539364001.8721.45.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 12 Oct 2018 18:06:41 +0100 In-Reply-To: <20181012162938.GA11676@bricha3-MOBL.ger.corp.intel.com> References: <20181011194629.4699-1-bluca@debian.org> <20181012151221.11295-1-bluca@debian.org> <20181012162938.GA11676@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 17:06:43 -0000 On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > > A Kbuild is also included to allow users to use DKMS natively > > without > > additional code. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > v2: add local directory to -I and build sources list recursively to > > =C2=A0=C2=A0=C2=A0=C2=A0fix build on Fedora > >=20 >=20 > Yep, now seems to build for me on Fedora. One minor suggestion is to > look > to use the "console" keyword on the custom_target if possible. It > should > help prevent noticable stalls as make runs in the background. > [Unfortunately, it's meson 0.48 onward only, so if conditionals are > needed, > just ignore this suggestion] Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there are no complaints or errors, it's simply ignored in the older versions. > Also, do we want to use "make -j" for this, given the number of > files? > [Maybe -j4 just?] Yeah makes sense, added j4. Sent v3 with both changes and the ack, thanks. --=20 Kind regards, Luca Boccassi