From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 6B582532C for <dev@dpdk.org>; Wed, 17 Oct 2018 14:32:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5396E9B8; Wed, 17 Oct 2018 08:32:46 -0400 (EDT) Received: from web5 ([10.202.2.215]) by compute1.internal (MEProxy); Wed, 17 Oct 2018 08:32:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= message-id:from:to:cc:mime-version:content-transfer-encoding :content-type:date:references:subject:in-reply-to; s=mesmtp; bh= E4/Ig8T6j07bcccEUJJmcvHct6yTDNQlxMn10cGuIe4=; b=EleYEMBCPBkrLdrb yYEMpMf92UcDAzN7BNROGSoDARlwkK6KrdFShZU1jDNMnLidqy4p3LkWsyfhfUXB lDK5sfaH3tGsw9zPgKhtFp3+30CKv8gEM9Ijc5mUJL3cIQxP4ebEv2JQxx+ZIxqo i/1Pk6eNgrF7k20hoGl5MR0jTTA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=E4/Ig8T6j07bcccEUJJmcvHct6yTDNQlxMn10cGuI e4=; b=G7WVCCkPXuSl8RrpoF+qmUPLjReRqqrlRna3vO9MagFYIP36d0K3E9dt0 CwftBd0ewLFS3Ahu77TQpSH8MMYx0JpSEbVHpc7lqmCqnFppR+FTt9/Dqbaw37pw 3hlValm16Mhru2UUfmF7BwhHv6qQziNtkrqgzIQdG+Gw8QNBjwyfulfgdNN8Hu1v QqLQ76JVTFtmGd/KSVm7Ka3Q7THzq19TPfwIIezfp2KP0kaKnMjXZj7GTr5aOE3c LkIQg0rSTbuAkRwR4pYGN22Ls/5q4KOGgwaZhpI1detH0K3r7iDUgnJd/g0pUEE8 OHJplwvUUhtfZJtmMzkbSNbZXoG7w== X-ME-Sender: <xms:7SvHW1uCdl3M4wdKlIDIebH55s2lwNKMFmnteHeaqy3PtpuZexFdfg> X-ME-Proxy: <xmx:7SvHWwu-N9JMBSSGM_dD70spjV-NxMLiK_piejoJmSTFtlJvkwTY3A> <xmx:7SvHWywZ5eP-nJAArUJk0lnw2W84GvLKY7D3WPXKuTwZdNMlVNI7aA> <xmx:7SvHWzjhEuB-yaf-nbPtRpSOUuXafTSAOG3bPuBRVF5wtiYMiRpUbQ> <xmx:7SvHWx5w6TQqUqI8X_AA7qpliw4SkwQiA9-wD06GiQuSh43th6oyHw> <xmx:7SvHW1nWxQs87v9mDWrVw-OhVQ0hvG1OS-Lt0mRYL-iDLTXRpq5g4w> <xmx:7SvHWz28DkjUUQAgfVs0yTed1BNHLhXNglMpD2oLCd_fT_Ho_mFbHg> Received: by mailuser.nyi.internal (Postfix, from userid 99) id 5A7429E0FE; Wed, 17 Oct 2018 08:32:45 -0400 (EDT) Message-Id: <1539779565.285794.1545097600.5D9A232A@webmail.messagingengine.com> From: Thomas Monjalon <thomas@monjalon.net> To: "Hunt, David" <david.hunt@intel.com> Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-cc4e8f33 Date: Wed, 17 Oct 2018 14:32:45 +0200 References: <20181017112350.19811-1-david.hunt@intel.com> <19031454.2TYKyzlM3p@xps> <5b428dec-d773-7714-8642-eff5678f8dd2@intel.com> In-Reply-To: <5b428dec-d773-7714-8642-eff5678f8dd2@intel.com> Subject: Re: [dpdk-dev] [PATCH] Update release notes for container power policies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Oct 2018 12:32:47 -0000 Hunt, David: > On 17/10/2018 12:43 PM, Thomas Monjalon wrote: > > 17/10/2018 13:23, David Hunt: > >> Signed-off-by: David Hunt <david.hunt@intel.com> > >> --- > >> doc/guides/rel_notes/release_18_11.rst | 7 +++++++ > >> 1 file changed, 7 insertions(+) > > Why this patch is alone? It is for a change already applied? > > If you forgot the release notes, you should add a Fixes: line > > so we know which code change it refers. > > Thanks > > The related patch set is not merged yet, so I could not add a Fixes: line. > This is in reference to one of the patch sets I mentioned in an email to > you yesterday. > http://patches.dpdk.org/project/dpdk/list/?series=1628 > > > >> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst > >> index 9c00e33cc..3174a0f80 100644 > >> --- a/doc/guides/rel_notes/release_18_11.rst > >> +++ b/doc/guides/rel_notes/release_18_11.rst > >> @@ -88,6 +88,13 @@ New Features > >> the specified port. The port must be stopped before the command call in order > >> to reconfigure queues. > >> > >> +* **Added JSON power policy interface for containers .** > >> + > >> + Extended the Power Library and vm_power_manger sample app to allow power > >> + policies to be submitted via a FIFO using JSON formatted strings. Previously > >> + limited to Virtual Machines, this feature extends power policy functionality > >> + to containers and host applications that need to have their cores frequency > >> + controlled based on the rules contained in the policy. > >> > >> API Changes > >> ----------- > > You must keep a double blank line before before next heading. > > > > Anyway you should move it before testpmd note, as explained in the comment: > > Suggested order in release notes items: > > * Core libs (EAL, mempool, ring, mbuf, buses) > > * Device abstraction libs and PMDs > > - ethdev (lib, PMDs) > > - cryptodev (lib, PMDs) > > - eventdev (lib, PMDs) > > - etc > > * Other libs > > * Apps, Examples, Tools (if significative) > > > > I can hold off uploading a v2 of this patch until the main patch set is > merged? Then I can > add in a Fixes: line and make your suggested changes. In this case, it is a lot better to integrate it with one of the patches of your series, maybe with the doc patch?