From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 93CE058C4 for ; Mon, 1 Oct 2018 21:48:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 06EA521FE6; Mon, 1 Oct 2018 15:48:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Oct 2018 15:48:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5/EDXBEe/7Dryj2PxbNSuqDmVA 1ZDPCoXn941zW1SCE=; b=ZeMxXJ26fr5H8yE9+lXjdande5PV0oYwb16Aa0/pV7 5/U6bQm2PE2PfkxMjenlngoIN8QKdlhoABvs80+8sIxDpqYpOF0eTh2S8Tyx/E6E +54616NgA3Iv9Lx7t0xFXRRw8RSuPWt+KF7eGnUgi9rDu6b31hoP9bMnHYoBLR/U M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5/EDXB Ee/7Dryj2PxbNSuqDmVA1ZDPCoXn941zW1SCE=; b=LhYTnIThZ++aGuXKM1ebLw mTiI7MZ7tClaOh0gs0UWty2wZ1Fjk/lqqVHtcE49K1ikIKQTsvIzts5vL+eIDPCf 8Mal8KZlPNqlpdxmWzECIv/CTklPBQykKIKI241MoOafYXeD1efHxKS5PQ1o0yu/ mpQzFPpuGHILxk8DBzO+lyglPbaERMm6RqeFjL4jgtiNyhT8a/C16eWV8SsIC4Kg iyV7AEdrgKGfyvDCjFccJxi2gkD3keb5lVvoqVj88FmiJG/m1anWdZQwDyG/g4se gw8iRBDYbqLIin6SzehCEy5ZDqF8DjAxrGemV93N9e8tZhT6EvdOKnrqSsmT5Gaw == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19B28E4A47; Mon, 1 Oct 2018 15:47:58 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com Date: Mon, 01 Oct 2018 21:47:54 +0200 Message-ID: <15400060.KEnbAWTMbX@xps> In-Reply-To: References: <20180907222727.20521-1-thomas@monjalon.net> <20180928162144.1972-3-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 19:48:00 -0000 01/10/2018 13:25, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > The function rte_devargs_remove(), which is intended to be internal, > > can take a devargs structure as argument. > > The matching is still using string comparison of bus name and > > device name. > > It is simpler and may allow a different devargs matching in future. > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: Andrew Rybchenko > > What about release notes? It is API change, yes, experimental, but still. Yes, you're right. Will fix in v4, thanks.