From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 6B06C1E2F for ; Mon, 29 Oct 2018 16:33:50 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id b203-v6so8416992wme.5 for ; Mon, 29 Oct 2018 08:33:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=HgWcl3bJnUqEpEzeZKnpcZ4nKeCt4D+ML3kwgOV4YNM=; b=sJOW3RMTFMf0R3034/7U3rqd/oHgb1XWViHFUJoXlcZyLf6ENftoNSm2UnoD7vyTir Z0R8E/PjVWu55wLy+ayEL22XwGPGADq18oJeuxL7WT2yaHeUTjEWOED1BX7S/wrLQ0jb dlzsx2AwUWtHJd+rgHh7NnUBlM0qmKYURug2L+M76xBItsJR3YFLnnXVz9YLWRXRgmAw AR4BIMIfZ453YGTGIQoBn4mlzd0Yq8KmfbgL7rwBqd+D1KRmdNyrbLGMlSCNE/fhWgtD b+dhfaMAqJe3bzRBaxwG6xshbvKXLKCLex4VsTyvGhh8UkO/JP2fahei06Wo7mEXZTWv nc1w== X-Gm-Message-State: AGRZ1gKwxtPaf/1yINI41MyJYU1dtv0XD+NoOLwenhU5aS6MmBzz8Wik gjV2XpMd/4ZHbh7hYW2XKKo= X-Google-Smtp-Source: AJdET5dmjgKrQTTaKT+YbYrdbpdNBCv78BuC2XAZVRfZEU3HuLV65twZl2pXv92Qiz06aMPmhfgMhg== X-Received: by 2002:a7b:c096:: with SMTP id r22-v6mr14586818wmh.40.1540827229954; Mon, 29 Oct 2018 08:33:49 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 68-v6sm3546197wmg.26.2018.10.29.08.33.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:33:48 -0700 (PDT) Message-ID: <1540827227.29722.8.camel@debian.org> From: Luca Boccassi To: Ilya Maximets , dev@dpdk.org, Bruce Richardson Date: Mon, 29 Oct 2018 15:33:47 +0000 In-Reply-To: <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com> References: <1539364001.8721.45.camel@debian.org> <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 15:33:50 -0000 On Mon, 2018-10-29 at 17:09 +0300, Ilya Maximets wrote: > > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: > > > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > > > > A Kbuild is also included to allow users to use DKMS natively > > > > without > > > > additional code. > > > >=20 > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > v2: add local directory to -I and build sources list > > > > recursively to > > > > =C2=A0=C2=A0=C2=A0=C2=A0fix build on Fedora > > > >=20 > > >=20 > > > Yep, now seems to build for me on Fedora. One minor suggestion is > > > to > > > look > > > to use the "console" keyword on the custom_target if possible. It > > > should > > > help prevent noticable stalls as make runs in the background. > > > [Unfortunately, it's meson 0.48 onward only, so if conditionals > > > are > > > needed, > > > just ignore this suggestion] > >=20 > > Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there > > are > > no complaints or errors, it's simply ignored in the older versions. >=20 > Hmm. > I have following on my Ubuntu 18.04 with dpdk v18.11-rc1: >=20 > $ meson --version > 0.45.1 >=20 > $ meson build > <...> > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword > argument "console". > WARNING: This will become a hard error in the future. > WARNING: Unknown keyword arguments in target rte_kni: console > <...> >=20 > It builds, but prints above warning. >=20 > Best regards, Ilya Maximets. Interesting, wonder why I didn't see that on 0.41! Anyway those warnings are fine to ignore, especially in this case. --=20 Kind regards, Luca Boccassi