From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enic: state change from link-down to link-up not recognized
Date: Wed, 30 Mar 2016 19:35:01 +0200 [thread overview]
Message-ID: <1540849.gS1UoX4J3q@xps13> (raw)
In-Reply-To: <1458953117-13817-1-git-send-email-johndale@cisco.com>
2016-03-25 17:45, John Daley:
> When the enic was disabled, link notification was correctly disabled
> in the NIC but the software indicator that it was disabled was not
> updated (vdev->notify_pa not set to 0). When the link came back up,
> enic did not re-enable notification in the NIC.
>
> This affected bonding when a enic slave device link bounced.
>
> The fix is to unconditionally enable notification when the enic is
> enabled.
>
> Fixes: 9913fbb91df0 ("enic/base: common code")
>
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>
Applied, thanks
prev parent reply other threads:[~2016-03-30 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 0:45 John Daley
2016-03-30 17:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540849.gS1UoX4J3q@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).