From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 57571952 for ; Wed, 30 Mar 2016 19:36:54 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id 127so106153259wmu.1 for ; Wed, 30 Mar 2016 10:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=RsEDy/gSu8ZoRV0ey7IcF8sm8jyB9Y/gXzDr8SgafHw=; b=cVqFwX+QPGilxZSM7g/DNBZw2q+wK3SwueayOv6nh9I6qowT1N0EoH0ydNvTqnpOyW w65YpgnEy6e/T+fVs2jLnLB6H2OrSrKlWF2prPXrH1YdusY6CSA+29jZHf6dPQd3polE HE6a60OJNVgSvYhVLA3P40rqVRyFgLIZxFmhUINv9VUaahXr2WjMOXNIFVBjeC6a3dB7 XhLBF2CzFE0g+D0It2KhsPWHa+FeLSxOpIdpLOZ4S7A0Cd6W9bH4rg+LfiaWOXRu30L3 EkvOFkmmN8ByJl4yxfvUAjclquOEB3oSOylDJwwJH5IZ/7y5Fv2TvZmGQ/lPvtjMaqXH C9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=RsEDy/gSu8ZoRV0ey7IcF8sm8jyB9Y/gXzDr8SgafHw=; b=VtSpXQgiF9dWzjgaWhXtTUB46boaEkFdVL5mCpoz62XfHKPd1sbsrfED4JqggQz5dM 9KCxvRPpwmrBVLaYEhWH7jxVAwUTJlYVXomT1Nh3Zp5VHJBxjlIi2QpcUuwx9o0dEVRw ze7VW6m/HSP5cRAqY2aGLEAhzSsGrCHPVjs8CNON1bBObtNhwwK7leB9qwX/xD9YSsGm gRkk3Eb3eMhGMp2OjT/DKstJyd/ta8jVzbJj7gi0k0sIwRso9DEIakWravTQdf9gCsnl UYqTqcQ1LnpPz1aQNoelb3wJzrt4Ikdp8TeYNuNrmjPXkc3othOObYRGkhnaO8Rc4sZ9 iF4A== X-Gm-Message-State: AD7BkJKfhJpDmEPn14TY+aTzUOhiS0MjSxS3Et8htpJGs63dVucCzUFMxMG/6Ghn5w2iJkz9 X-Received: by 10.28.12.80 with SMTP id 77mr11641466wmm.19.1459359414223; Wed, 30 Mar 2016 10:36:54 -0700 (PDT) Received: from xps13.localnet (109.202.154.77.rev.sfr.net. [77.154.202.109]) by smtp.gmail.com with ESMTPSA id jo6sm4952979wjb.48.2016.03.30.10.36.53 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2016 10:36:53 -0700 (PDT) From: Thomas Monjalon To: John Daley Cc: dev@dpdk.org Date: Wed, 30 Mar 2016 19:35:01 +0200 Message-ID: <1540849.gS1UoX4J3q@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458953117-13817-1-git-send-email-johndale@cisco.com> References: <1458953117-13817-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] enic: state change from link-down to link-up not recognized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 17:36:54 -0000 2016-03-25 17:45, John Daley: > When the enic was disabled, link notification was correctly disabled > in the NIC but the software indicator that it was disabled was not > updated (vdev->notify_pa not set to 0). When the link came back up, > enic did not re-enable notification in the NIC. > > This affected bonding when a enic slave device link bounced. > > The fix is to unconditionally enable notification when the enic is > enabled. > > Fixes: 9913fbb91df0 ("enic/base: common code") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar Applied, thanks