From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 383F9B10F
 for <dev@dpdk.org>; Sat, 14 Jun 2014 01:37:58 +0200 (CEST)
Received: by mail-we0-f175.google.com with SMTP id k48so2660220wev.6
 for <dev@dpdk.org>; Fri, 13 Jun 2014 16:38:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=QY70PSoDSflIEme0O+lctukNKPbQDygZF0Gz5pNzCX4=;
 b=LFQtP0bI5gAQ/drqmlmHS7IFdJZ/7Ld0LFecBNslRagOfC5prPSSw9+e3qJ0rsqgwO
 qv2R2mB1UdxUBNayucFGWQPCGjL9Hc+QdIm27zIEjx/8R/FGFi4+FqsU28OSoeRxW9pv
 Rwlgb7RDbmaUD8hOzCELZF2us78FFZiWbqXLGpCChVMTZNsqipAyV92W3v/xH96HQbel
 L9szEJ71DSRyIZPY/7hdXbq25KW5T5pHfFDynxdgT5uUed5/M57Q3r7+osZR4AE5tojD
 /F3RGKxCC5nNs586YxWBQdDPOgUHmo1AiDl/jnI3RUbRZiWyBkz0B3uZKQS/fUi9hTby
 IlTA==
X-Gm-Message-State: ALoCoQlwSJWY90/oUXSlh1jjMWaeIOm0pcQaHv8OdVNMGVIYB/CST6jbK6R0WBZ0AgKRN/lZ4DUa
X-Received: by 10.180.83.225 with SMTP id t1mr8642917wiy.28.1402702693393;
 Fri, 13 Jun 2014 16:38:13 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id i8sm5009977wiw.22.2014.06.13.16.38.11
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 13 Jun 2014 16:38:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Date: Sat, 14 Jun 2014 01:38:11 +0200
Message-ID: <1541041.MVudaz1CFn@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com>
References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com>
 <3012262.OhlkyXXJnt@xps13>
 <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jun 2014 23:37:58 -0000

2014-06-13 12:02, Ananyev, Konstantin:
> 2014-06-13 13:56, Thomas Monjalon:
> > > Konstantin Ananyev (5):
> > >   Add ACL library (librte_acl) into DPDK
> > >   acl: update UT to reflect latest changes in the librte_acl
> > >   acl: New test-acl application
> > >   acl: New sample l3fwd-acl
> > >   acl: add doxygen configuration and start page
> > > 
> > > v2 fixes:
> > > * Fixed several checkpatch.pl issues
> > > * Added doxygen related changes
> > > 
> > > v3 fixes:
> > > * Fixed even more checkpatch.pl issues
> > 
> > Sorry to bother you but after checking v3,
> > 
> > I think these errors should be avoided:
> > 	ERROR: do not use assignment in if condition
> > 	ERROR: return is not a function, parentheses are not required
> 
> These changes would require a lot of changes inside ACL library.
> As I said in cover letter, ACL library was part of IPL code for a while
> (nearly a year).
> I don't really want to make significant changes in it just before the
> release without really good reason - bugs found.

I've made the code style changes, move some configuration lines and added
to BSD build (not tested).
As it was previously acked and tested,
it is now applied for version 1.7.0.

Thanks
-- 
Thomas