From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255])
 by dpdk.org (Postfix) with ESMTP id 2517D1B2AC
 for <dev@dpdk.org>; Fri,  2 Nov 2018 11:52:28 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by mta.qwilt.com (Postfix) with ESMTP id 2BFB2861C31;
 Fri,  2 Nov 2018 10:52:27 +0000 (UTC)
X-Virus-Scanned: amavisd-new at qwilt.com
Received: from mta.qwilt.com ([127.0.0.1])
 by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oOgMcpey6pjU; Fri,  2 Nov 2018 10:52:27 +0000 (UTC)
Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il
 [80.179.204.39])
 by mta.qwilt.com (Postfix) with ESMTPSA id A92C58069C4;
 Fri,  2 Nov 2018 10:52:25 +0000 (UTC)
From: Arnon Warshavsky <arnon@qwilt.com>
To: thomas@monjalon.net, dev@dpdk.org, john.mcnamara@intel.com,
 marko.kovacevic@intel.com
Cc: arnon@qwilt.com
Date: Fri,  2 Nov 2018 12:52:21 +0200
Message-Id: <1541155941-18088-1-git-send-email-arnon@qwilt.com>
X-Mailer: git-send-email 1.8.3.1
Subject: [dpdk-dev] [PATCH v3] devtools: add explicit warning messages for
	forbidden tokens
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Nov 2018 10:52:28 -0000

Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages

Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
---

v2 - fix typo
v3 - reduce message not to exceed 80 chars 

 devtools/check-forbidden-tokens.awk | 7 +------
 devtools/checkpatches.sh            | 2 ++
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/devtools/check-forbidden-tokens.awk b/devtools/check-forbidden-tokens.awk
index fd77cdd..8c89de3 100755
--- a/devtools/check-forbidden-tokens.awk
+++ b/devtools/check-forbidden-tokens.awk
@@ -63,12 +63,7 @@ BEGIN {
 END {
 	if (count > 0) {
 		print "Warning in " substr(last_file,6) ":"
-		print "are you sure you want to add the following:"
-		for (key in expressions) {
-			if (expressions[key] > 0) {
-				print key
-			}
-		}
+		print MESSAGE
 		exit RET_ON_FAIL
 	}
 }
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index fb9e9f7..7f823e0 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -49,6 +49,7 @@ check_forbidden_additions() { # <patch>
 	awk -v FOLDERS="lib drivers" \
 		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
 		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using rte_panic/rte_exit' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
 		"$1"
 	# svg figures must be included with wildcard extension
@@ -56,6 +57,7 @@ check_forbidden_additions() { # <patch>
 	awk -v FOLDERS='doc' \
 		-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
 		-v RET_ON_FAIL=1 \
+		-v MESSAGE="Using explicit .svg extension instead of .*" \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
 		"$1"
 }
-- 
1.8.3.1