From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by dpdk.org (Postfix) with ESMTP id D573ADED for ; Sat, 3 Nov 2018 16:54:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDJ5/dNMw+XcKvLgcQDiUXS/koberSaIO5NyHZAhwiE=; b=gi/WbEG27vtrXD1oL6Nj5zUAGDI6pGiL5m4Xx3FIz4zyERfnOpdTKVfN4PX7OjseK/gh4u63rBPElkLlpUP/rNf51x71vu8/INagvQPyRKilj8qyXi0vb5EYrgJDq2zoR4sMt6IRBd6UHNxzxkg1Lf8E3/PX9uLPOIP30CO5vF8= Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com (52.134.8.154) by VI1PR0502MB2959.eurprd05.prod.outlook.com (10.175.21.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Sat, 3 Nov 2018 15:54:45 +0000 Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4]) by VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4%4]) with mapi id 15.20.1294.028; Sat, 3 Nov 2018 15:54:45 +0000 From: Ophir Munk To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , "dev@dpdk.org" CC: Asaf Penso , Shahaf Shuler , Thomas Monjalon , Olga Shern , Ophir Munk , Yongseok Koh Thread-Topic: [PATCH v1] app/testpmd: set default RSS key as NULL Thread-Index: AQHUc42KKl7n13UNvk+JpU+G+ZKXoA== Date: Sat, 3 Nov 2018 15:54:45 +0000 Message-ID: <1541260478-4621-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:52::32) To VI1PR0502MB3743.eurprd05.prod.outlook.com (2603:10a6:803:11::26) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0502MB2959; 6:Nlo7nUx6Kg3dJGLMH+HdonmZJE+PZao1mRehra7B4TkDqFOKMqgafO/tImIdlpdB5nORJZ5JfrvTc8xO632cHGG6etaUxH9ds0IbxlKb1B9/i5yYRZk+21khSfojdfATMSbGdOMlvUDKsh0l4nozNomJD2XBFiyyBJPcJWdrtC5MvbSV0cZ36/1hNC8VhFP4EJ91/yEWVT/+LSPYVc4T0fPNAZxO74c3j3n8YlYvlN0CjNwkltEmZ6cnsTyIEFY5KD2tKBLCPRqyXISf1DMVRKYkrxQDJwxUqyH0ymIu06s/hHDkWKnfUuLH+P8vWSvAYVAoyMkGNt+XYmaPUHKhNTfeOXhMoLNj7CWJ2AZ/63iQR5vZ3S8rMJJGXZnXXX2+vPeJpnKvaBfZXPoJ2jb+ijpd59coGd+mx78Kz070S6a3Zus+ZNcYWqjjs3DKCVwBOOkWaGlMEeQsU87OlRmaww==; 5:y6QHaFPgWb9E8dSGqEkYy8Bo41z4lYZE9kzK9fIRbbTQYBXTU8gAPxhVxeqaVSy7rQJ4QaFmsH4eFHpvzz5nsQqAhp9t3sWfeTuVZ/TDRO+E306OxbgBV7fmx7qOruJGXyKMHV7VaTF14dkkSI46HyuFEdjYecilWIaUS8rwKpk=; 7:4+by3g5u8mns33sLtkb7850gDIJJeuQKl/Cr4nyemg211txrGJzDpFU1PKOZr8BQHGCGDZ3oJYaGK0l2x1gncXKr/1E0h3lbe2NpBJrOWUgoFwSJZ4CTT/MuQR9yZ/YsW6sIeMW/EWLt5iLT78AbEQ== x-ms-office365-filtering-correlation-id: 1fd28624-9384-4b08-a6b1-08d641a4acb4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB2959; x-ms-traffictypediagnostic: VI1PR0502MB2959: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR0502MB2959; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB2959; x-forefront-prvs: 08457955C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(376002)(366004)(199004)(189003)(53936002)(3846002)(5660300001)(8936002)(486006)(106356001)(71190400001)(71200400001)(86362001)(6436002)(105586002)(6116002)(66066001)(14454004)(81166006)(81156014)(316002)(8676002)(110136005)(54906003)(6486002)(478600001)(68736007)(2906002)(6506007)(386003)(102836004)(97736004)(26005)(7736002)(4326008)(256004)(14444005)(186003)(107886003)(6512007)(25786009)(305945005)(36756003)(99286004)(2900100001)(52116002)(2501003)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB2959; H:VI1PR0502MB3743.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NNjsivqOMwLHb4qL6yH+RL7A3XUrx4I1TEwwrQONa2Mn9x6QLwsbQvxcGHeCqQdUsLkWtm7qhtjUFt6DRLOPaaS5AGjUlFBVMlc5YYVat8Nrh4P4Tol5yW+1+ZfZr9MmhDY7Q+eTrAuW9TS1fcCHDVJGNwLt9vb5GNsYZBIiXT3ZZJEIdcG7Y7T0p3mAd3OXzUdlulC9DoYfbxoyXPyXzzEORECippS5uLVkythU34zsxWHD4ZBxxKSc7+IXKHt7Ss6n8qS3Yx/la03IfQVYrO8f5Xi2X6Y8yf/tXNL9PW6nVGKRUa0qZFVjpwWJR2bHDRhszcm4fqGasWw91tPNC+hNv7nRVDK+EEi3SpJVEWo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fd28624-9384-4b08-a6b1-08d641a4acb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2018 15:54:45.1372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2959 Subject: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Nov 2018 15:54:47 -0000 When creating an RSS rule without specifying a key (see [1]) it is expected that the device will use the default key. A NULL key is uded to indicate to a PMD it should use its default key, however testpmd assigns a non-NULL dummy key (see [2]) instead. This does not enable testing any PMD behavior when the RSS key is not specified. This commit fixes this limitation by setting key to NULL. [1] RSS rule example without specifying a key: flow create 0 ingress / end actions rss queues 0 1 end / end [2] Testpmd default key assignment: .key=3D "testpmd's default RSS hash key, " "override it for better balancing" Signed-off-by: Ophir Munk --- v1: Initial version app/test-pmd/cmdline_flow.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 23ea7cc..91e2e35 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -3248,26 +3248,15 @@ static int comp_vc_action_rss_queue(struct context = *, const struct token *, .func =3D RTE_ETH_HASH_FUNCTION_DEFAULT, .level =3D 0, .types =3D rss_hf, - .key_len =3D sizeof(action_rss_data->key), + .key_len =3D 0, .queue_num =3D RTE_MIN(nb_rxq, ACTION_RSS_QUEUE_NUM), - .key =3D action_rss_data->key, + .key =3D NULL, .queue =3D action_rss_data->queue, }, - .key =3D "testpmd's default RSS hash key, " - "override it for better balancing", .queue =3D { 0 }, }; for (i =3D 0; i < action_rss_data->conf.queue_num; ++i) action_rss_data->queue[i] =3D i; - if (!port_id_is_invalid(ctx->port, DISABLED_WARN) && - ctx->port !=3D (portid_t)RTE_PORT_ALL) { - struct rte_eth_dev_info info; - - rte_eth_dev_info_get(ctx->port, &info); - action_rss_data->conf.key_len =3D - RTE_MIN(sizeof(action_rss_data->key), - info.hash_key_size); - } action->conf =3D &action_rss_data->conf; return ret; } --=20 1.8.3.1