* [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting
@ 2018-11-06 6:32 Ori Kam
2018-11-07 2:43 ` Zhao1, Wei
0 siblings, 1 reply; 3+ messages in thread
From: Ori Kam @ 2018-11-06 6:32 UTC (permalink / raw)
To: Ori Kam, wei.zhao1; +Cc: dev
The tx offloads should be compared to tx capability
Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
Cc: orika@mellanox.com
Cc: wei.zhao1@intel.com
Signed-off-by: Ori Kam <orika@mellanox.com>
---
examples/flow_filtering/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 27e287a..a582ac0 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -137,7 +137,7 @@
struct rte_eth_dev_info dev_info;
rte_eth_dev_info_get(port_id, &dev_info);
- port_conf.txmode.offloads &= dev_info.rx_offload_capa;
+ port_conf.txmode.offloads &= dev_info.tx_offload_capa;
printf(":: initializing port: %d\n", port_id);
ret = rte_eth_dev_configure(port_id,
nr_queues, nr_queues, &port_conf);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting
2018-11-06 6:32 [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting Ori Kam
@ 2018-11-07 2:43 ` Zhao1, Wei
2018-11-07 18:17 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Zhao1, Wei @ 2018-11-07 2:43 UTC (permalink / raw)
To: Ori Kam; +Cc: dev
Acked-by: Wei Zhao <wei.zhao1@intel.com>
> -----Original Message-----
> From: Ori Kam [mailto:orika@mellanox.com]
> Sent: Tuesday, November 6, 2018 2:32 PM
> To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] examples/flow_filtering: fix capability setting
>
> The tx offloads should be compared to tx capability
>
> Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
> Cc: orika@mellanox.com
> Cc: wei.zhao1@intel.com
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
> examples/flow_filtering/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index 27e287a..a582ac0 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -137,7 +137,7 @@
> struct rte_eth_dev_info dev_info;
>
> rte_eth_dev_info_get(port_id, &dev_info);
> - port_conf.txmode.offloads &= dev_info.rx_offload_capa;
> + port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> printf(":: initializing port: %d\n", port_id);
> ret = rte_eth_dev_configure(port_id,
> nr_queues, nr_queues, &port_conf);
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting
2018-11-07 2:43 ` Zhao1, Wei
@ 2018-11-07 18:17 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-07 18:17 UTC (permalink / raw)
To: Zhao1, Wei, Ori Kam; +Cc: dev
On 11/7/2018 2:43 AM, Zhao1, Wei wrote:
>
>> -----Original Message-----
>> From: Ori Kam [mailto:orika@mellanox.com]
>> Sent: Tuesday, November 6, 2018 2:32 PM
>> To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Cc: dev@dpdk.org
>> Subject: [PATCH] examples/flow_filtering: fix capability setting
>>
>> The tx offloads should be compared to tx capability
>>
>> Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
>> Cc: orika@mellanox.com
>> Cc: wei.zhao1@intel.com
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>
> Acked-by: Wei Zhao <wei.zhao1@intel.com>
Fixes: c82f2f8b4b3a ("examples/flow_filtering: filter out unsupported offloads")
Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-07 18:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 6:32 [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting Ori Kam
2018-11-07 2:43 ` Zhao1, Wei
2018-11-07 18:17 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).