From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A46D1A00C2; Thu, 23 Apr 2020 09:28:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDB1A1C23F; Thu, 23 Apr 2020 09:28:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 4D8311C23D for ; Thu, 23 Apr 2020 09:28:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C9DAD5C021A; Thu, 23 Apr 2020 03:27:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 23 Apr 2020 03:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 4Aid4291QZT2XZi/WTW8PqxjQ+c0AdpdGGoQMfuw/Hc=; b=PtiNGsD1YNJCukh8 2VNcGAQlGVoDy8Tg4lcMUcqTp9sxv85hNX1LZHw1z/lz7No20/A5Kj5s93Gy0jTo AIaJ65c/kGo3aBAlO4R0Ka98RgzpBJIBUBXtean6IhEjxscGDW4WUve6asW8/K4j PV8qegGcGjET8b2yhvr7tWO2NbiJWxQvlPy93Md2r2UECvssWLpT436AgJKNYk0q SDLVF2aEiGrZC+ieF7VdtFM8NbQqRDDqU5ALoIDAKmis6mQsInwhZD2DF4eSIDaV EWqxbe0xzI7IVK1a2MZ9MHqrjiU2cVBRdyfa9qdH3dnd/xm8WH9u0Mka0uwhYB4N lmRvlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4Aid4291QZT2XZi/WTW8PqxjQ+c0AdpdGGoQMfuw/ Hc=; b=uDIUu20/JNQUal5xSWfi9XgdmC+iGk7Mp1hzNwnCBqJ8WbUSxRET4sh1q feCB/fdSYBToOBm+d8dXbh8rTgrEMy793an/0LcwleAuTzwHxpgqNkcgBysgs+zv Lw9rh2/bOHTR0CTrI1uke2gPmhq5l9yJEdnQXx4y/zzcGkI4qiPhXS2YnSGFMEo9 8FJbg+MX+iFDf57yQ3/Dj3yDjkhENrdiVa67XQhzdJtGO9KPNdKcCsuNR/ydfDui +qvRAwr/1X3PUDqU3V/YdwPBwR3fpOzHtUyRGcdEqkKsNnJjab2fC6G8vkmTk+tg AH4u1viX1ivAIzOSGwkjXk8vAbKcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeekgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 81D723065D21; Thu, 23 Apr 2020 03:27:58 -0400 (EDT) From: Thomas Monjalon To: Ranjit Menon Cc: talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net Date: Thu, 23 Apr 2020 09:27:56 +0200 Message-ID: <15414965.hlxOUv9cDv@thomas> In-Reply-To: <1248d40a-741d-69ae-a149-4e5b98691f76@intel.com> References: <20200422072747.15960-1-talshn@mellanox.com> <20200422072747.15960-2-talshn@mellanox.com> <1248d40a-741d-69ae-a149-4e5b98691f76@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/04/2020 01:51, Ranjit Menon: > On 4/22/2020 12:27 AM, talshn@mellanox.com wrote: > > From: Tal Shnaiderman > > > > Move common functions between Unix and Windows to eal_config.c. > > Like other files in common, we should call this eal_common_config.c I am not sure about the interest of repeating the directory name in the file name in general. Do you see a real benefit? Note: the naming in lib/librte_eal/common/ is not uniform.