From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30048.outbound.protection.outlook.com [40.107.3.48]) by dpdk.org (Postfix) with ESMTP id DC32B239 for ; Wed, 7 Nov 2018 10:23:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lu9bvau0S/6k7QAZrhN0fsPHdlXvONSWMELdBJjUfFs=; b=cHyeO6y9zllhEyvs2xgsykdg2WOuH2UQwmdjlYF4umSlwTrY68N8ci6rGQmci9/U9rSvZ8edB3zosUFOS9l75MCe57KaI0Lt9f6uXgNGsMDekmG2iNxJLCQlCaCIpepSlO3vFkE01l8LE7WrEzRC3etONTplPyvQyafgoNYTCpw= Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com (52.134.8.154) by VI1PR0502MB2878.eurprd05.prod.outlook.com (10.175.24.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Wed, 7 Nov 2018 09:23:42 +0000 Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4]) by VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4%4]) with mapi id 15.20.1294.034; Wed, 7 Nov 2018 09:23:42 +0000 From: Ophir Munk To: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Thomas Monjalon CC: Asaf Penso , Shahaf Shuler , Olga Shern , Ophir Munk Thread-Topic: [PATCH v2] ethdev: document RSS default key and types Thread-Index: AQHUdnuTE9UKU0bjB02/QczzO0OvtA== Date: Wed, 7 Nov 2018 09:23:42 +0000 Message-ID: <1541582611-1609-1-git-send-email-ophirmu@mellanox.com> References: <1541259953-4273-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1541259953-4273-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0078.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::18) To VI1PR0502MB3743.eurprd05.prod.outlook.com (2603:10a6:803:11::26) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0502MB2878; 6:3m57gjmy190SMFaBZ23T3J10eSS6wUnvhUS7cVGah6N3u2cIZ0H2rZpo9tRze6vskSdbflLMu4AQ7d2xUSHInMx4MxHZxo5FKR0F9X0GYSRZjAyTuw2jg7L2+dOWsUfeGaUZVR5VjxJyUEOwflZEU5OPuyd7cCHAQAtFspNCk5zpHP+CdUA7r5umjl2uTk2oodgIvHXVBSIa3nsA2IxfvrpaAnAsiGbzZ92LXeStIy7rC1ot3k0B3QlM4poQ8nmSaGLKnqVnU8Ligx4lXNRzIsU9MJyLPy6Oy1+lCMDKmeRjB1yYMdFAm2Zsw63QmLwRb824CbkazuGd6j8ah8AUIVaHITm1tt1gtbHnheZZlI42r0REFEuRdwso4RvK5NX4VGOwvu3+DNr4rnFzCt1XEPNk9O6CeaWQFB0L4smE1c3vP8816RUmrRiXJonW/eZ/eu2uA+hLmuZfRDZVNxN3lA==; 5:EHi64Ln/SmdjiZQC9c/18Z3h2YHWrkmo0UL67DMoAwSV9wQtMFUDWZEDhB5SsCHHbe3gZqYCWWCcRp7egfqBc5aGZL96170NLf1QFE2QZLaa8eV5UFRR4n4zx2PHV/ItAYXxHJgL2h64t8/El+U+SHZoQzuY64X79sd88m2xmak=; 7:+yif3HI9LR3xGOSE6cxq5jK/F35U7PptbsqnRSgp/MXKUHZ9Pf2jquuukbAL1O8QCJ2YyogdR5SHfDtZ+pKBSK2HZ3t+3FeEIeYZ0SlMpBgO6GfQxcdJUbucieLFU5LXF1rHIXVFGajkqqmWu6W0Dg== x-ms-office365-filtering-correlation-id: 7eafc69e-4f3b-4a07-7f0e-08d64492b586 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB2878; x-ms-traffictypediagnostic: VI1PR0502MB2878: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:VI1PR0502MB2878; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB2878; x-forefront-prvs: 08497C3D99 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(136003)(396003)(376002)(366004)(199004)(189003)(5660300001)(6512007)(105586002)(106356001)(97736004)(8936002)(68736007)(107886003)(14454004)(446003)(4326008)(25786009)(11346002)(66066001)(186003)(2906002)(53936002)(486006)(2616005)(476003)(2900100001)(6486002)(110136005)(54906003)(6506007)(386003)(76176011)(71190400001)(71200400001)(52116002)(8676002)(26005)(36756003)(7736002)(256004)(316002)(102836004)(305945005)(2501003)(478600001)(3846002)(6116002)(6436002)(81156014)(575784001)(81166006)(99286004)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB2878; H:VI1PR0502MB3743.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: I2gEwHpNnc2vG694f9+KUQONcfqN7/MC7RozwHJtivr9pOEExqtClcPU+kNgKPai8LKdAOSmNMx5KfcCRtOlu8JcVqir4+ln9GUBhCk21L0d+e9ioBYeVq3lcrtHBI4qEUax55uvuZeuwNh2Vy1tGL+W6KIrdBZdsE+X6Ou/QIAdaRHwHJ/fIgKsV0f5qFz5GyAnCYIQ/pwAGxli5XpngzTNMIaYPflCmYSKhqJO0yYvHjIJok6lGBuBcowCAP5JKsCz94nuFg9CE4p0SjvEJGuhfrWgcM/DUExMfX9o0oOOdNRYTq4+rUtpMVU5+rmTkXo5pIKtKfI5+HlyoxjimQUwIGSiD9U4kiqhYYh/gGs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eafc69e-4f3b-4a07-7f0e-08d64492b586 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2018 09:23:42.4345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2878 Subject: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 09:23:44 -0000 struct rte_flow_action_rss include fields 'key' and 'types'. Field 'key' is a pointer to bytes array (uint8_t *) which contains the specific RSS hash key. If an application is only interested in default RSS operation it should not care about the specific hash key. The application can set the hash key to NULL such that any PMD uses its default RSS key. Field 'types' is a uint64_t bits flag used to specify a specific RSS hash type such as ETH_RSS_IP (see ETH_RSS_*). If an application does not care about the specific RSS type it can set this field to 0 such that any PMD uses its default type. Signed-off-by: Ophir Munk --- lib/librte_ethdev/rte_flow.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index c0fe879..ca9e135 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -1782,10 +1782,15 @@ struct rte_flow_action_rss { * through. */ uint32_t level; - uint64_t types; /**< Specific RSS hash types (see ETH_RSS_*). */ + /** + * Specific RSS hash types (see ETH_RSS_*), + * or 0 for PMD specific default. + */ + uint64_t types; uint32_t key_len; /**< Hash key length in bytes. */ uint32_t queue_num; /**< Number of entries in @p queue. */ - const uint8_t *key; /**< Hash key. */ + /** Hash key, or NULL for PMD specific default key. */ + const uint8_t *key; const uint16_t *queue; /**< Queue indices to use. */ }; =20 --=20 1.8.3.1