From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id EECE7B4B7 for ; Fri, 13 Feb 2015 14:49:53 +0100 (CET) Received: by mail-we0-f175.google.com with SMTP id x3so16744937wes.6 for ; Fri, 13 Feb 2015 05:49:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=x+ABTckVOkTuxNDZ7VSjE7wkfq3YfJ3gnkllstZB9Xg=; b=mRA+qK0ns9XEq2AxMAm1UMakABYUT4YLdIr4Yhheh+JKuz+rywmT7KyuVO7vxx5z+3 ra4fFaTpDi4+g60ct67SxNaVMdqpTp4NWm1D0QOFqsBWbubvbwiUJsal3NozmsPS+hit swgO+VcjS8XtaFYzAueTgEQOOd5t0w9LuaE1VN+cvye35IAgagoKUVyzzXvrxskjOH+P KQM64mENRnvb1ADkTFETtftEyrL0DzStnIG1mr5oxgbY2QuCi8FpD0DvGIfEefwL3Y8h U9ujgS4hBzo9v6sO5ODA44QnW4gYGvcm3xwwfafkVFr9+4dr7MzEkTLASVGiOLuTPqnW E8EQ== X-Gm-Message-State: ALoCoQlRliUzti28yE3zkku/nBB1oADGrOv7N7ufBfRXxuwCeCmHZUW+QGdKuMNtfGUtWqY/zejj X-Received: by 10.180.99.137 with SMTP id eq9mr16485380wib.34.1423835393844; Fri, 13 Feb 2015 05:49:53 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cb14sm3009914wib.22.2015.02.13.05.49.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Feb 2015 05:49:53 -0800 (PST) From: Thomas Monjalon To: Michael Qiu Date: Fri, 13 Feb 2015 14:49:23 +0100 Message-ID: <1541600.e9txtCqPjk@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1423653001-11660-1-git-send-email-michael.qiu@intel.com> <1423661155-16645-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 13:49:54 -0000 > > max_vfs will only be created by igb_uio driver, for other > > drivers like vfio or pci_uio_generic, max_vfs will miss. > > > > But sriov_numvfs is not driver related, just get the vf numbers > > from that field. > > > > Signed-off-by: Michael Qiu > > I can see a different solution : maybe faking a sriov_numvfs parameter from > igb_uio for kernels that don't have it and doing nothing for kernels that > already provide sriov_numvfs. > But your solution is more straightforward (and we don't need to update > documentation and/or existing scripts afaik). > > Acked-by: David Marchand Applied, thanks