From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C6C62AA97
 for <dev@dpdk.org>; Tue, 17 Apr 2018 22:56:55 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5F71E2201C;
 Tue, 17 Apr 2018 16:56:55 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 17 Apr 2018 16:56:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=FxN/QLwTEKbFiydstu/x76RJ+n
 BywZZOUXbl803SYzY=; b=O7h3O6TnQw7mlHFXtwakl82Hv1rkymjaQJMRJE6RLL
 AYB7vAiyVnatIzEMLqb2UOr24cg3+EzZgeipX4Jhua7pi4DkjrsKyo5nh3+XCM7Y
 EBhQbPCK10acfKrq+D9oYnW+JTR5G5BKrTrkzqcw+2/hxQ39V4ReIPNgeJIPIrTr
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FxN/QL
 wTEKbFiydstu/x76RJ+nBywZZOUXbl803SYzY=; b=HqEAw9kYugnTOxDQUup/8a
 BOh3sXNBAfezfL2X9zA29Yrg24mRdtBfqp7xt3DdfvKL3ldyFm0rnZuS1/+AJYKp
 rDj+hw4sTy7bImsNyQ1G9Jjt3u2Ir78PhneQ/tQktdOF/XJOe49evCwNFrahGAOr
 BMiW2c0b7Yn8Z74kaWRB3SGxEUhTEWOEGLbAC1yRf3cBcocuoBPO5t34fA8nmsdS
 gcY7l52MrrcojchPmlEs5GY3OHzM6KBS398NAJ/zL0P0UXFIk9KJYuGZ0eUfA9iO
 oIBUZuSnTSIvvEo1lGfdfdFE98vxnxtVlgVPe4GwJ3sITZaMdxwxtgdsPrMuMn3g
 ==
X-ME-Sender: <xms:l1_WWrdus4vltRXnEWi97Nw_1UFBg-Ttf5iLRXp5VXGlSNzV1nI4Hg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 45014E443C;
 Tue, 17 Apr 2018 16:56:54 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 17 Apr 2018 22:56:52 +0200
Message-ID: <1541697.oJ8yBXImSN@xps>
In-Reply-To: <20180417150404.160990-3-xuemingl@mellanox.com>
References: <20180417150404.160990-1-xuemingl@mellanox.com>
 <20180417150404.160990-3-xuemingl@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 2/4] ethdev: introduce new tunnel VXLAN-GPE
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 20:56:56 -0000

17/04/2018 17:04, Xueming Li:
> +struct rte_flow_item_vxlan_gpe {
> +	uint8_t flags; /**< Normally 0x0c (I and P flags). */
> +	uint8_t rsvd0[2]; /**< Reserved, normally 0x0000. */
> +	uint8_t protocol; /**< Protocol type. */
> +	uint8_t vni[3]; /**< VXLAN identifier. */
> +	uint8_t rsvd1; /**< Reserved, normally 0x00. */
> +};

These comments are not aligned.


> +struct vxlan_gpe_hdr {
> +	uint8_t vx_flags;	/**< flag (8). */
> +	uint8_t reserved[2];	/**< Reserved (16). */
> +	uint8_t proto;		/**< next-protocol (8). */
> +	uint32_t vx_vni;	/**< VNI (24) + Reserved (8). */
> +} __attribute__((__packed__));

Alignment must be done with spaces.