From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 716B928FD for ; Fri, 9 Nov 2018 06:58:10 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4206D80D; Thu, 8 Nov 2018 21:58:09 -0800 (PST) Received: from wls-arm-softiron03.shanghai.arm.com (wls-arm-softiron03.shanghai.arm.com [10.169.41.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 319783F5CF; Thu, 8 Nov 2018 21:58:08 -0800 (PST) From: "tone.zhang" To: dev@dpdk.org Cc: gavin.hu@arm.com, honnappa.nagarahalli@arm.com, Steve.Capper@arm.com, anatoly.burakov@intel.com, nd@arm.com Date: Fri, 9 Nov 2018 13:57:57 +0800 Message-Id: <1541743077-27994-1-git-send-email-tone.zhang@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1540347604-18590-1-git-send-email-tone.zhang@arm.com> References: <1540347604-18590-1-git-send-email-tone.zhang@arm.com> Subject: [dpdk-dev] [PATCH v2] pci_vfio: Support 64KB kernel page_size with vfio-pci driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 05:58:10 -0000 With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the start and end of the MSI table to the PAGE_SIZE, the end offset of the MSI table is out of the PCI BAR boundary. This patch addresses the issue by comparing both the start and the end offset of the MSI table with the BAR size, and skip the mapping if it is out of Bar scope. The patch fixes the debug log as below: EAL: Skipping BAR0 Signed-off-by: tone.zhang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Reviewed-by: Steve Capper Reviewed-by: Burakov Anatoly --- drivers/bus/pci/linux/pci_vfio.c | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c index 305cc06..9a0affe 100644 --- a/drivers/bus/pci/linux/pci_vfio.c +++ b/drivers/bus/pci/linux/pci_vfio.c @@ -445,9 +445,11 @@ pci_vfio_mmap_bar(int vfio_dev_fd, struct mapped_pci_resource *vfio_res, struct pci_msix_table *msix_table = &vfio_res->msix_table; struct pci_map *bar = &vfio_res->maps[bar_index]; - if (bar->size == 0) + if (bar->size == 0) { /* Skip this BAR */ + RTE_LOG(INFO, EAL, "Skipping BAR%d\n", bar_index); return 0; + } if (msix_table->bar_index == bar_index) { /* @@ -456,8 +458,22 @@ pci_vfio_mmap_bar(int vfio_dev_fd, struct mapped_pci_resource *vfio_res, */ uint32_t table_start = msix_table->offset; uint32_t table_end = table_start + msix_table->size; - table_end = (table_end + ~PAGE_MASK) & PAGE_MASK; - table_start &= PAGE_MASK; + table_end = RTE_ALIGN(table_end, PAGE_SIZE); + table_start = RTE_ALIGN(table_start, PAGE_SIZE); + /* after rounding to PAGE_SIZE, it is over the bar->size, + * fall back to the MSI-X table offset in the bar and + * align with PAGE_SIZE. + */ + if (table_start >= bar->size) { + table_start = RTE_ALIGN_FLOOR(msix_table->offset, + PAGE_SIZE); + /* after aligning with PAGE_SIZE, if it is less than + * the MSI-X table offset, continue falling back to + * the actual MSI-X table offset in the bar. + */ + if (table_start < msix_table->offset) + table_start = msix_table->offset; + } if (table_start == 0 && table_end >= bar->size) { /* Cannot map this BAR */ @@ -469,8 +485,18 @@ pci_vfio_mmap_bar(int vfio_dev_fd, struct mapped_pci_resource *vfio_res, memreg[0].offset = bar->offset; memreg[0].size = table_start; - memreg[1].offset = bar->offset + table_end; - memreg[1].size = bar->size - table_end; + if (bar->size < table_end) { + /* + * after rounding to PAGE_SIZE we don't have any space + * left after the MSI table, so don't try and map it. + */ + memreg[1].offset = 0; + memreg[1].size = 0; + } + else { + memreg[1].offset = bar->offset + table_end; + memreg[1].size = bar->size - table_end; + } RTE_LOG(DEBUG, EAL, "Trying to map BAR%d that contains the MSI-X " -- 2.7.4