From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix non-Intel devices probing
Date: Mon, 16 Sep 2013 22:38:47 +0200 [thread overview]
Message-ID: <1541839.XYEVK3QFDL@x220> (raw)
In-Reply-To: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com>
> There is no need to check for bars mapping, especially BAR0 is not required.
> If bars mapping failed, then pci_uio_map_resource will fail and we won't
> reach this check. So get rid of BAR0 check.
> Besides, pci_uio_map_resource should only be called for Intel devices.
> The flag RTE_PCI_DRV_NEED_IGB_UIO is set for all Intel devices, even when
> RTE_EAL_UNBIND_PORTS is disabled.
Addendum:
This patch is needed to run virtio-net-pmd and vmxnet3-usermap with DPDK 1.4.
next prev parent reply other threads:[~2013-09-16 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 20:29 Thomas Monjalon
2013-09-16 20:38 ` Thomas Monjalon [this message]
2013-09-16 21:42 ` Patrick Mahan
2013-09-16 21:59 ` Thomas Monjalon
2013-09-16 23:59 ` Stephen Hemminger
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 1/2] pci: do not check BAR0 mapping Thomas Monjalon
2013-09-17 11:26 ` Damien Millescamps
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 2/2] pci: use igb_uio mapping only when needed Thomas Monjalon
2013-09-17 11:27 ` Damien Millescamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541839.XYEVK3QFDL@x220 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).