From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
 [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 179E458F5
 for <dev@dpdk.org>; Mon, 16 Sep 2013 22:37:22 +0200 (CEST)
Received: by mail-we0-f177.google.com with SMTP id t60so4175033wes.22
 for <dev@dpdk.org>; Mon, 16 Sep 2013 13:38:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=6RVDivsJ/glSZMZm9sMkhzRhOMKobm4Km+eqgpKIYts=;
 b=TPKZ+4rlxm/ejck7pK8XfkbOYWPqAHq40oyqaJ3XQ99B6J9K83L8kphl5lojEHqvua
 T2Ci8NyKw05iDP5CzWcdckdGw9wDOioPierMJUDPNpEoexOnhaA12XeoVCpWRVt6mZww
 /DUI3xQpEpf1XRL1C7T6UpgiXI+z5DLEh3S8bagUsmgelVw0YHD/+EgRemSsvkUXo09/
 aZ8cuYckMamVyADiMV5IUwYd3GVPte7NXTSdlmN+2Y75SHSa/1yPPHGcfxaBhILDeY82
 O6uTEWs5EXVdgcE/8J0JSTnj2tGMGAlYAQlQB/sAUakI6MK197cs+EzEFP5w5KHHgIvC
 Fzxg==
X-Gm-Message-State: ALoCoQkO3h6u5wOouWjEGazeY5wy8f09Dx6K4uG3fQ5dDpRcmzrdEGnctQ2AnGkHZKkenjvLzzqf
X-Received: by 10.194.5.35 with SMTP id p3mr3346820wjp.47.1379363880111;
 Mon, 16 Sep 2013 13:38:00 -0700 (PDT)
Received: from x220.localnet (abo-26-39-68.mts.modulonet.fr. [85.68.39.26])
 by mx.google.com with ESMTPSA id ey2sm26224292wib.5.1969.12.31.16.00.00
 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Mon, 16 Sep 2013 13:37:59 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Mon, 16 Sep 2013 22:38:47 +0200
Message-ID: <1541839.XYEVK3QFDL@x220>
Organization: 6WIND
User-Agent: KMail/4.11.1 (Linux/3.10.10-1-ARCH; KDE/4.11.1; x86_64; ; )
In-Reply-To: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com>
References: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] pci: fix non-Intel devices probing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Sep 2013 20:37:22 -0000

> There is no need to check for bars mapping, especially BAR0 is not required.
> If bars mapping failed, then pci_uio_map_resource will fail and we won't
> reach this check. So get rid of BAR0 check.
> Besides, pci_uio_map_resource should only be called for Intel devices.
> The flag RTE_PCI_DRV_NEED_IGB_UIO is set for all Intel devices, even when
> RTE_EAL_UNBIND_PORTS is disabled.

Addendum:
This patch is needed to run virtio-net-pmd and vmxnet3-usermap with DPDK 1.4.