From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com
[209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 90A4A5F22
for <dev@dpdk.org>; Wed, 14 Nov 2018 12:39:41 +0100 (CET)
Received: by mail-wm1-f65.google.com with SMTP id p2-v6so14375405wmc.2
for <dev@dpdk.org>; Wed, 14 Nov 2018 03:39:41 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
:references:content-transfer-encoding:mime-version;
bh=TsdKs5yzji0l9BLPx8Ny9kpDe8Jg+pUQkifbpOZXzOk=;
b=QJSpj+5Bxva5ec8vcQcM46BM5Bq30NtbFLWpyeKdSezae+aAYYCagdGsYVrdRp58En
YPV8hEpF8oi5SpPkd5P2kEPgfnmgnjJMPv87dtMM8sEL+4uodauP4T4tHORhkZxQocn6
kKdwyPsv18B2ecZdFn5eAXQn1JHHt9lCQGfm5NQB5y/mXaWiEiqdKsNqZO8BLVkamtGK
60p7Pv513j03Pm35q8MyKiib1MbXK/O/RcUFmin4ZndRMrYaZnWQRNGqeTsMAnlN0lj6
RExTBdrGxyCCffJlkXwZpXbnKXesq3Yvm/rzBXegV15HBBEjlslmdpd7y+G1nTAhBbuZ
unNQ==
X-Gm-Message-State: AGRZ1gKMOYmPsZYEzf/RZW4HoTvQwMg5scHnu43Wtl2vFRwhXYkakDts
TRklaMOa+aD/XEyBVbL8q7U=
X-Google-Smtp-Source: AJdET5duFs+cqKnDo5sBTD1EL3CqjOPGDp8z9u49yH1dncVJwgb/MlKKINnIi8wToX/dLJHIXrF0oA==
X-Received: by 2002:a1c:7c17:: with SMTP id
x23-v6mr1492369wmc.23.1542195581071;
Wed, 14 Nov 2018 03:39:41 -0800 (PST)
Received: from localhost ([2001:1be0:110d:fcfe:70c5:32f6:c5b6:39e6])
by smtp.gmail.com with ESMTPSA id h67-v6sm8489722wma.10.2018.11.14.03.39.39
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Wed, 14 Nov 2018 03:39:39 -0800 (PST)
Message-ID: <1542195578.11515.9.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>, dev <dev@dpdk.org>
Date: Wed, 14 Nov 2018 11:39:38 +0000
In-Reply-To: <20181114113453.24852-1-christian.ehrhardt@canonical.com>
References: <20181114113453.24852-1-christian.ehrhardt@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/2] build: avoid non supported -march on ppc
(meson)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2018 11:39:41 -0000
On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote:
> So far only if machine was "native" it did use the re-direction to
> not set -march on ppc64 (where -march is not supported).
> We have to use mcpu/mtune in any case on ppc for whatever someone
> using
> the build system defines as machine.
>=20
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> =C2=A0config/meson.build | 5 +++--
> =C2=A01 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/meson.build b/config/meson.build
> index 0b710b795..1af305f46 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -9,8 +9,9 @@ else
> =C2=A0endif
> =C2=A0dpdk_conf.set('RTE_MACHINE', machine)
> =C2=A0machine_args =3D []
> -# ppc64 does not support -march=3Dnative
> -if host_machine.cpu_family().startswith('ppc') and machine =3D=3D
> 'native'
> +
> +# ppc64 does not support -march=3D at all, use -mcpu and -mtune for
> that
> +if host_machine.cpu_family().startswith('ppc')
> =C2=A0 machine_args +=3D '-mcpu=3D' + machine
> =C2=A0 machine_args +=3D '-mtune=3D' + machine
> =C2=A0else
Acked-by: Luca Boccassi <bluca@debian.org>
--=20
Kind regards,
Luca Boccassi