* [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs
@ 2018-11-14 13:47 Slava Ovsiienko
2018-11-15 8:49 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Slava Ovsiienko @ 2018-11-14 13:47 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev, Viacheslav Ovsiienko
From: Viacheslav Ovsiienko <Viacheslav Ovsiienko viacheslavo@mellanox.com>
The flow_dv_query() just returns -ENOTSUP value and does not
set provided error parameter structure, that crashes the
port_flow_query(). The patch fixes flow_db_query(), now it
sets an error parameter structure.
Fixes: 684dafe795d0 ("net/mlx5: add flow query abstraction interface")
Cc: Moti Haimovsky <motih@mellanox.com>
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index a2edd16..9991cad 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2275,8 +2275,10 @@
void *data __rte_unused,
struct rte_flow_error *error __rte_unused)
{
- rte_errno = ENOTSUP;
- return -rte_errno;
+ return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL,
+ "flow query with DV is not supported");
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs
2018-11-14 13:47 [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs Slava Ovsiienko
@ 2018-11-15 8:49 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-11-15 8:49 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, Viacheslav Ovsiienko
Wednesday, November 14, 2018 3:47 PM, Slava Ovsiienko:
> Subject: [PATCH] net/mlx5: fix flow query routine in Direct Verbs
>
> From: Viacheslav Ovsiienko <Viacheslav Ovsiienko
> viacheslavo@mellanox.com>
>
> The flow_dv_query() just returns -ENOTSUP value and does not set provided
> error parameter structure, that crashes the port_flow_query(). The patch
> fixes flow_db_query(), now it sets an error parameter structure.
>
> Fixes: 684dafe795d0 ("net/mlx5: add flow query abstraction interface")
> Cc: Moti Haimovsky <motih@mellanox.com>
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 13:47 [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs Slava Ovsiienko
2018-11-15 8:49 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).