From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps
Date: Fri, 16 Nov 2018 10:52:47 +0000 [thread overview]
Message-ID: <1542365567.11515.26.camel@debian.org> (raw)
In-Reply-To: <20181116102632.GC3144@bricha3-MOBL.ger.corp.intel.com>
On Fri, 2018-11-16 at 10:26 +0000, Bruce Richardson wrote:
> On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote:
> > Meson can generate the list of private dependencies of libraries
> > automatically for the pkgconfig file only since version 0.45.0.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > doc/build-sdk-meson.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> > index 508e2cb64..229398bb0 100644
> > --- a/doc/build-sdk-meson.txt
> > +++ b/doc/build-sdk-meson.txt
> > @@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
> >
> > build:
> > @mkdir -p $@
> > +
> > +NOTE: for --static builds, DPDK needs to be built with Meson >=
> > 0.45 in order to
> > +fully generate the list of private dependencies. If DPDK is built
> > with an older
> > +version of Meson, it might be necessary to manually specify
> > dependencies of DPDK
> > +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or
> > the static link
> > +step might fail.
>
> Thinking about it more, this doesn't seem to actually be the root-
> cause of
> the reported problem. You said in the other thread that you
> reproduced the
> problem with v0.45.2 which is >= 0.45
>
> /Bruce
I think the documentation linked there is wrong - looking at the
release notes in the repository, it's 0.46 that mentions that new
feature, not 0.45:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for-static-only-libraries
I'll check if I can repro with 0.46 to confirm
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-11-16 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:26 Luca Boccassi
2018-11-16 10:26 ` Bruce Richardson
2018-11-16 10:52 ` Luca Boccassi [this message]
2018-11-16 10:55 ` Luca Boccassi
2018-11-16 10:57 ` [dpdk-dev] [PATCH v2] build: document that Meson < 0.46 " Luca Boccassi
2018-11-16 11:47 ` Richardson, Bruce
2018-11-18 23:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542365567.11515.26.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).