From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 784542BB1 for ; Fri, 16 Nov 2018 11:55:43 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id l9so11526063wrt.13 for ; Fri, 16 Nov 2018 02:55:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=gPwBr4fzA2PF5wF2I5sba2/Kn0fLu87gmXtDhrPKNeA=; b=L6prLYf9zEqM8gOiC1RiQ0hyBRSHIAqEpnh2SP1jnPsl1w2LU4qwtEWIkuTtRd4KCF pjP/2cIUIZ0W7pKn8fBdDh426D2Xxz0dr3nso/iJaKlR4El/dqSwnIOhGS46ruPmKAnF DriQu1nXgplh90fjEqQrSLRsDBoxG7g2b3Rx6dFsbr6XLSJ5aNKTEf1owkwIdMImMraZ HN4nbiRBDNS2NX5UzmzW1jT0vsuGoE0VktFEo6gDOn3B5s71X2DNORHVONS/mMtweWeD lawqr34AxGdhTi+geYYlpsLG3eegfxl1JOJo9NRrcIpzBZSnlEDp1uEI7jVTF/H78q/F f5Bg== X-Gm-Message-State: AGRZ1gLoappuGu87K26jcLYMIQF6bUyHguvmjDPxDyfFxVdN+BBRFNhj wobudyZNREkkBMl2l8BSBIU= X-Google-Smtp-Source: AJdET5fhujswBSqsu5meurH7Rr810MLUcqlF53eJR+NGyfj1+7niFfHAR+qR8z4iTFotc6mx1XZmTg== X-Received: by 2002:adf:b453:: with SMTP id v19-v6mr8795139wrd.47.1542365742730; Fri, 16 Nov 2018 02:55:42 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id l123-v6sm6280986wma.10.2018.11.16.02.55.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Nov 2018 02:55:41 -0800 (PST) Message-ID: <1542365741.11515.27.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net Date: Fri, 16 Nov 2018 10:55:41 +0000 In-Reply-To: <1542365567.11515.26.camel@debian.org> References: <20181115182628.8114-1-bluca@debian.org> <20181116102632.GC3144@bricha3-MOBL.ger.corp.intel.com> <1542365567.11515.26.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 10:55:43 -0000 On Fri, 2018-11-16 at 10:52 +0000, Luca Boccassi wrote: > On Fri, 2018-11-16 at 10:26 +0000, Bruce Richardson wrote: > > On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote: > > > Meson can generate the list of private dependencies of libraries > > > automatically for the pkgconfig file only since version 0.45.0. > > >=20 > > > Signed-off-by: Luca Boccassi > > > --- > > > =C2=A0doc/build-sdk-meson.txt | 6 ++++++ > > > =C2=A01 file changed, 6 insertions(+) > > >=20 > > > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt > > > index 508e2cb64..229398bb0 100644 > > > --- a/doc/build-sdk-meson.txt > > > +++ b/doc/build-sdk-meson.txt > > > @@ -203,3 +203,9 @@ From examples/helloworld/Makefile:: > > > =C2=A0 > > > =C2=A0 build: > > > =C2=A0 @mkdir -p $@ > > > + > > > +NOTE: for --static builds, DPDK needs to be built with Meson >=3D > > > 0.45 in order to > > > +fully generate the list of private dependencies. If DPDK is > > > built > > > with an older > > > +version of Meson, it might be necessary to manually specify > > > dependencies of DPDK > > > +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or > > > the static link > > > +step might fail. > >=20 > > Thinking about it more, this doesn't seem to actually be the root- > > cause of > > the reported problem. You said in the other thread that you > > reproduced the > > problem with v0.45.2 which is >=3D 0.45 > >=20 > > /Bruce >=20 > I think the documentation linked there is wrong - looking at the > release notes in the repository, it's 0.46 that mentions that new > feature, not 0.45: >=20 > https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release > -notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for- > static-only-libraries >=20 > I'll check if I can repro with 0.46 to confirm Yes I can confirm that it's 0.46 that actually fixes the issue, so I'll send a v2 with the updated version. --=20 Kind regards, Luca Boccassi