[dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

[dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

[Luca Boccassi]

Meson can generate the list of private dependencies of libraries
automatically for the pkgconfig file only since version 0.45.0.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 508e2cb64..229398bb0 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.45 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.
-- 
2.19.1

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

[Bruce Richardson]

On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote:
> Meson can generate the list of private dependencies of libraries
> automatically for the pkgconfig file only since version 0.45.0.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  doc/build-sdk-meson.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> index 508e2cb64..229398bb0 100644
> --- a/doc/build-sdk-meson.txt
> +++ b/doc/build-sdk-meson.txt
> @@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
>  
>  	build:
>  		@mkdir -p $@
> +
> +NOTE: for --static builds, DPDK needs to be built with Meson >= 0.45 in order to
> +fully generate the list of private dependencies. If DPDK is built with an older
> +version of Meson, it might be necessary to manually specify dependencies of DPDK
> +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
> +step might fail.

Thinking about it more, this doesn't seem to actually be the root-cause of
the reported problem. You said in the other thread that you reproduced the
problem with v0.45.2 which is >= 0.45

/Bruce

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

[Luca Boccassi]

On Fri, 2018-11-16 at 10:26 +0000, Bruce Richardson wrote:
> On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote:
> > Meson can generate the list of private dependencies of libraries
> > automatically for the pkgconfig file only since version 0.45.0.
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  doc/build-sdk-meson.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> > index 508e2cb64..229398bb0 100644
> > --- a/doc/build-sdk-meson.txt
> > +++ b/doc/build-sdk-meson.txt
> > @@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
> >  
> >  	build:
> >  		@mkdir -p $@
> > +
> > +NOTE: for --static builds, DPDK needs to be built with Meson >=
> > 0.45 in order to
> > +fully generate the list of private dependencies. If DPDK is built
> > with an older
> > +version of Meson, it might be necessary to manually specify
> > dependencies of DPDK
> > +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or
> > the static link
> > +step might fail.
> 
> Thinking about it more, this doesn't seem to actually be the root-
> cause of
> the reported problem. You said in the other thread that you
> reproduced the
> problem with v0.45.2 which is >= 0.45
> 
> /Bruce

I think the documentation linked there is wrong - looking at the
release notes in the repository, it's 0.46 that mentions that new
feature, not 0.45:

https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for-static-only-libraries

I'll check if I can repro with 0.46 to confirm

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

[Luca Boccassi]

On Fri, 2018-11-16 at 10:52 +0000, Luca Boccassi wrote:
> On Fri, 2018-11-16 at 10:26 +0000, Bruce Richardson wrote:
> > On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote:
> > > Meson can generate the list of private dependencies of libraries
> > > automatically for the pkgconfig file only since version 0.45.0.
> > > 
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > >  doc/build-sdk-meson.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> > > index 508e2cb64..229398bb0 100644
> > > --- a/doc/build-sdk-meson.txt
> > > +++ b/doc/build-sdk-meson.txt
> > > @@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
> > >  
> > >  	build:
> > >  		@mkdir -p $@
> > > +
> > > +NOTE: for --static builds, DPDK needs to be built with Meson >=
> > > 0.45 in order to
> > > +fully generate the list of private dependencies. If DPDK is
> > > built
> > > with an older
> > > +version of Meson, it might be necessary to manually specify
> > > dependencies of DPDK
> > > +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or
> > > the static link
> > > +step might fail.
> > 
> > Thinking about it more, this doesn't seem to actually be the root-
> > cause of
> > the reported problem. You said in the other thread that you
> > reproduced the
> > problem with v0.45.2 which is >= 0.45
> > 
> > /Bruce
> 
> I think the documentation linked there is wrong - looking at the
> release notes in the repository, it's 0.46 that mentions that new
> feature, not 0.45:
> 
> https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release
> -notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for-
> static-only-libraries
> 
> I'll check if I can repro with 0.46 to confirm

Yes I can confirm that it's 0.46 that actually fixes the issue, so I'll
send a v2 with the updated version.

-- 
Kind regards,
Luca Boccassi

[dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

[Luca Boccassi]

Meson can generate the list of private dependencies of libraries
automatically for the pkgconfig file only since version 0.46.0.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v2: corrected version, minimum required is meson 0.46

 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 508e2cb64..3d8a69c29 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.46 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.
-- 
2.19.1

Re: [dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

[Richardson, Bruce]

> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Friday, November 16, 2018 10:58 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net;
> Luca Boccassi <bluca@debian.org>
> Subject: [PATCH v2] build: document that Meson < 0.46 will fail to list
> private deps
> 
> Meson can generate the list of private dependencies of libraries
> automatically for the pkgconfig file only since version 0.46.0.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v2: corrected version, minimum required is meson 0.46
> 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

[Thomas Monjalon]

> > Meson can generate the list of private dependencies of libraries
> > automatically for the pkgconfig file only since version 0.46.0.
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Title updated: build: document Meson < 0.46 miss private dependencies