From: Lee Daly <lee.daly@intel.com>
To: declan.doherty@intel.com, chas3@att.com
Cc: dev@dpdk.org, Lee Daly <lee.daly@intel.com>
Subject: [dpdk-dev] [PATCH] net/bonding: check return value in bond_ethdev_configure
Date: Fri, 16 Nov 2018 14:54:27 +0000 [thread overview]
Message-ID: <1542380067-140320-1-git-send-email-lee.daly@intel.com> (raw)
This patch checks the return value of function
rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure
for error return value.
Signed-off-by: Lee Daly <lee.daly@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 156f31c..a7612ae 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3420,9 +3420,14 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
"Failed to parse agg selection mode for bonded device %s",
name);
}
- if (internals->mode == BONDING_MODE_8023AD)
- rte_eth_bond_8023ad_agg_selection_set(port_id,
- agg_mode);
+ if (internals->mode == BONDING_MODE_8023AD) {
+ if (rte_eth_bond_8023ad_agg_selection_set(port_id,
+ agg_mode) < 0) {
+ RTE_BOND_LOG(ERR, "Invalid args for agg selection"
+ " set for bonded device %s", name);
+ return -1;
+ }
+ }
}
/* Parse/add slave ports to bonded device */
--
2.7.4
next reply other threads:[~2018-11-16 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 14:54 Lee Daly [this message]
2018-11-16 15:43 ` Ferruh Yigit
2018-11-16 16:48 ` [dpdk-dev] [PATCH v2] net/bonding: fix possible silent failure in configuration Lee Daly
2018-11-16 17:37 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542380067-140320-1-git-send-email-lee.daly@intel.com \
--to=lee.daly@intel.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).