From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-177180.vip.163.com (mail-177180.vip.163.com [123.58.177.180]) by dpdk.org (Postfix) with ESMTP id 8E97D1B1E6; Wed, 5 Dec 2018 03:50:35 +0100 (CET) Received: from localhost.localdomain (unknown [116.196.72.250]) by smtp1 (Coremail) with SMTP id oGZ4CgDX3rbyPAdccN2oAw--.62312S3; Wed, 05 Dec 2018 10:50:34 +0800 (CST) From: gfree.wind@vip.163.com To: dev@dpdk.org Cc: David Marchand , stable@dpdk.org Date: Wed, 5 Dec 2018 10:50:26 +0800 Message-Id: <1543978226-23480-2-git-send-email-gfree.wind@vip.163.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com> References: <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com> X-CM-TRANSID: oGZ4CgDX3rbyPAdccN2oAw--.62312S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFy3WryUXw4ftF1DJFykGrg_yoWDJwc_Ar s7W3y3Xw15AryktF40yrs3Wrn7Ga98Cws8AF17trn3tryUWa1DuFWDtrnYqrn2qFWSkF1f ZF93Zr1qyr13AjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU833kJUUUUU== X-Originating-IP: [116.196.72.250] X-CM-SenderInfo: 5jiuvvgozl0vg6yl1hqrwthudrp/1tbiJRoUs1XmxqQWCAAAsX Subject: [dpdk-dev] [PATCH] devtools: fix symbol check when adding experimental section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 02:50:37 -0000 From: David Marchand The incriminated commit did relax the condition to catch all sections but dropped the + removal which can trigger false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Neil Horman --- devtools/check-symbol-change.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 4b8d9f3..020da7e 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -31,6 +31,7 @@ build_map_changes() # Triggering this rule sets in_sec to 1, which actives the # symbol rule below /^.*{/ { + gsub("+", ""); if (in_map == 1) { sec=$(NF-1); in_sec=1; } -- 2.7.4