* [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
@ 2018-12-06 12:06 Dekel Peled
2018-12-06 12:15 ` Ori Kam
2018-12-06 12:18 ` Rahul Lakkireddy
0 siblings, 2 replies; 4+ messages in thread
From: Dekel Peled @ 2018-12-06 12:06 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu, bernard.iremonger
Cc: dev, orika, shahafs, dekelp, rahul.lakkireddy
testpmd actions set_tp_src and set_tp_dst documentation adds the
of_ prefix to action names, while the implementation doesn't add it.
This patch removes the prefix from action names in testpmd
documentation.
Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
Cc: rahul.lakkireddy@chelsio.com
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 056f8bb..9d4f107 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.
- ``ipv6_addr``: New IPv6 destination address.
-- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
+- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP source port number.
-- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
+- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP destination port number.
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
2018-12-06 12:06 [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc Dekel Peled
@ 2018-12-06 12:15 ` Ori Kam
2018-12-06 12:18 ` Rahul Lakkireddy
1 sibling, 0 replies; 4+ messages in thread
From: Ori Kam @ 2018-12-06 12:15 UTC (permalink / raw)
To: Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger
Cc: dev, Shahaf Shuler, Dekel Peled, rahul.lakkireddy
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, December 6, 2018 2:06 PM
> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Dekel Peled <dekelp@mellanox.com>;
> rahul.lakkireddy@chelsio.com
> Subject: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd
> doc
>
> testpmd actions set_tp_src and set_tp_dst documentation adds the
> of_ prefix to action names, while the implementation doesn't add it.
>
> This patch removes the prefix from action names in testpmd
> documentation.
>
> Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port
> numbers")
> Cc: rahul.lakkireddy@chelsio.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 056f8bb..9d4f107 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3931,12 +3931,12 @@ This section lists supported actions and their
> attributes, if any.
>
> - ``ipv6_addr``: New IPv6 destination address.
>
> -- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
> +- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP source port number.
>
> -- ``of_set_tp_dst``: Set a new destination port number in the outermost
> TCP/UDP
> +- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP destination port number.
> --
> 1.8.3.1
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
2018-12-06 12:06 [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc Dekel Peled
2018-12-06 12:15 ` Ori Kam
@ 2018-12-06 12:18 ` Rahul Lakkireddy
2018-12-11 17:43 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Rahul Lakkireddy @ 2018-12-06 12:18 UTC (permalink / raw)
To: Dekel Peled
Cc: wenzhuo.lu, jingjing.wu, bernard.iremonger, dev, orika, shahafs
On Thursday, December 12/06/18, 2018 at 17:36:14 +0530, Dekel Peled wrote:
> testpmd actions set_tp_src and set_tp_dst documentation adds the
> of_ prefix to action names, while the implementation doesn't add it.
>
> This patch removes the prefix from action names in testpmd
> documentation.
>
> Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
> Cc: rahul.lakkireddy@chelsio.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 056f8bb..9d4f107 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.
>
> - ``ipv6_addr``: New IPv6 destination address.
>
> -- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
> +- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP source port number.
>
> -- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
> +- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP destination port number.
> --
> 1.8.3.1
>
Good catch!
Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
2018-12-06 12:18 ` Rahul Lakkireddy
@ 2018-12-11 17:43 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-12-11 17:43 UTC (permalink / raw)
To: Rahul Lakkireddy, Dekel Peled
Cc: wenzhuo.lu, jingjing.wu, bernard.iremonger, dev, orika, shahafs
On 12/6/2018 12:18 PM, Rahul Lakkireddy wrote:
> On Thursday, December 12/06/18, 2018 at 17:36:14 +0530, Dekel Peled wrote:
>> testpmd actions set_tp_src and set_tp_dst documentation adds the
>> of_ prefix to action names, while the implementation doesn't add it.
>>
>> This patch removes the prefix from action names in testpmd
>> documentation.
>>
>> Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
>> Cc: rahul.lakkireddy@chelsio.com
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
> Acked-by: Ori Kam <orika@mellanox.com>
>
> Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-11 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 12:06 [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc Dekel Peled
2018-12-06 12:15 ` Ori Kam
2018-12-06 12:18 ` Rahul Lakkireddy
2018-12-11 17:43 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).