From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 9876D2C58 for ; Mon, 9 Jan 2017 16:33:26 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id a197so101726676wmd.0 for ; Mon, 09 Jan 2017 07:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=KP/UmiCdAVwL9oDzKY+RFqrZ5iKoV4xH0T3dv+yRlpQ=; b=gqbJTtdxAi0Wabta2I48pR3UIAlTFMdTUIxICgeSB1TrSI/8D4Lf5E1iu5m0+oQyAo EXSzasYrNWZ9C829Mv6KpzAUronmceIs31tPu2QDk42tetDtGfMaQQS54Tk2nsCS8u/s onn40w0vqWmr6Ij7CL1Wk3zMs1rPfpxX8J326WVydoEDu9KxvhBhKugy9MIu/sULSlhM vmuuFC9UBI730We0vy+iU4HExd1Ow9Eoa0m8krZEMeWHdo7CVfVIAqEPmUHWkFYGnyhS 2LWQxDEahA709pHGVkqQ6U2eysBcEQU2WEasLjtxtv5gVHVFZIpgyrpd5HoYvxxDMrF7 ItBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KP/UmiCdAVwL9oDzKY+RFqrZ5iKoV4xH0T3dv+yRlpQ=; b=eKSPlVFU//CfTTj2ZVZjKGd5eXvPT88wHTna6lvX0nqGttQ1LsgG3Z/dLhQoVQDqcr Fkje2MJaca1gSStlzikb1d8yknlmIebXeLbZ4KpBhO4vbiWYQSR5cL9lDwIsZPoqJPrg VC9oSEjOCDlIobMySDPoc5se4ohMdBXHUY8Z0eHBMccYdSNALCbv9l8O0xisr3278HDw gITjweuknUxb9cDv1U73Q5AobIgcU5w1LSdIGusVpeSMzk95aO/s/2nOSdnGW6WltxzA mUJCyaXUOTjsLqppN6HyXbh/mJ2PDpljKWeJoIMATCq4hT5tTWUmBHTG+ErvFqb/K68V UBUw== X-Gm-Message-State: AIkVDXJmZpjzxIjulEPZrREQ+i4Ch38RSWtxFTbqrpPvAm2HZV4ZWA6zvKjtFCfJhREwITU2 X-Received: by 10.28.52.201 with SMTP id b192mr4612100wma.118.1483976006082; Mon, 09 Jan 2017 07:33:26 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w8sm19349641wmw.4.2017.01.09.07.33.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 07:33:25 -0800 (PST) From: Thomas Monjalon To: Akhil Goyal , hemant.agrawal@nxp.com Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, john.mcnamara@intel.com, nhorman@tuxdriver.com Date: Mon, 09 Jan 2017 16:33:24 +0100 Message-ID: <1544143.B2rDg7MdQ1@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161222201700.20020-8-akhil.goyal@nxp.com> References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161222201700.20020-1-akhil.goyal@nxp.com> <20161222201700.20020-8-akhil.goyal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 15:33:26 -0000 2016-12-23 01:46, Akhil Goyal: > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_COMMON),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_qbman > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_dpio > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_pool > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_fslmcbus > +endif There are so much libs! We do not have even one commit per library in this patchset. Splitting patches would allow to better introduce them one by one with an explanation of the design and the role of each library.