[dpdk-dev] [PATCH] mempool: fix symbol export

[dpdk-dev] [PATCH] mempool: fix symbol export

[Thomas Monjalon]

Every new symbols in release 16.07 are exported with the version
string DPDK_16.07.
Also remove the empty local: section which is not needed because
inherited from the DPDK_2.0 block.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_mempool/rte_mempool_version.map | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
index a4a6c1f..9bcbf17 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -16,7 +16,7 @@ DPDK_2.0 {
 	local: *;
 };
 
-DPDK_16.7 {
+DPDK_16.07 {
 	global:
 
 	rte_mempool_check_cookies;
@@ -33,5 +33,4 @@ DPDK_16.7 {
 	rte_mempool_register_ops;
 	rte_mempool_set_ops_byname;
 
-	local: *;
 } DPDK_2.0;
-- 
2.7.0

Re: [dpdk-dev] [PATCH] mempool: fix symbol export

[Olivier Matz]

On 06/25/2016 03:10 PM, Thomas Monjalon wrote:
> Every new symbols in release 16.07 are exported with the version
> string DPDK_16.07.
> Also remove the empty local: section which is not needed because
> inherited from the DPDK_2.0 block.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  lib/librte_mempool/rte_mempool_version.map | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
> index a4a6c1f..9bcbf17 100644
> --- a/lib/librte_mempool/rte_mempool_version.map
> +++ b/lib/librte_mempool/rte_mempool_version.map
> @@ -16,7 +16,7 @@ DPDK_2.0 {
>  	local: *;
>  };
>  
> -DPDK_16.7 {
> +DPDK_16.07 {
>  	global:
>  
>  	rte_mempool_check_cookies;
> @@ -33,5 +33,4 @@ DPDK_16.7 {
>  	rte_mempool_register_ops;
>  	rte_mempool_set_ops_byname;
>  
> -	local: *;
>  } DPDK_2.0;
> 

Good catch, thanks Thomas
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

[Ferruh Yigit]

On 6/27/2016 1:57 PM, y@ecsmtp.ir.intel.com wrote:
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Send from wrong e-mail address, although patches looks OK, I don't see
them in patchwork and will send again.

Regards,
ferruh

[dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

[Ferruh Yigit]

Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_ether/rte_ether_version.map | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 97ed0b0..e1ccebe 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -66,7 +66,6 @@ DPDK_2.2 {
 	rte_eth_dev_set_vf_rxmode;
 	rte_eth_dev_set_vf_tx;
 	rte_eth_dev_set_vf_vlan_filter;
-	rte_eth_dev_set_vlan_ether_type;
 	rte_eth_dev_set_vlan_offload;
 	rte_eth_dev_set_vlan_pvid;
 	rte_eth_dev_set_vlan_strip_on_queue;
-- 
2.5.5

[dpdk-dev] [PATCH 2/3] cmdline: remove duplicated symbols from .map

[Ferruh Yigit]

Fixes: 9d41beed24b0 ("lib: provide initial versioning")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_cmdline/rte_cmdline_version.map | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map
index c9fc18a..04bcb38 100644
--- a/lib/librte_cmdline/rte_cmdline_version.map
+++ b/lib/librte_cmdline/rte_cmdline_version.map
@@ -50,7 +50,6 @@ DPDK_2.0 {
 	cmdline_token_num_ops;
 	cmdline_token_portlist_ops;
 	cmdline_token_string_ops;
-	cmdline_token_string_ops;
 	cmdline_write_char;
 	rdline_add_history;
 	rdline_char_in;
-- 
2.5.5

[dpdk-dev] [PATCH 3/3] port: remove duplicated symbols from .map

[Ferruh Yigit]

Fixes: 9d41beed24b0 ("lib: provide initial versioning")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_port/rte_port_version.map | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_port/rte_port_version.map b/lib/librte_port/rte_port_version.map
index c528658..048c20d 100644
--- a/lib/librte_port/rte_port_version.map
+++ b/lib/librte_port/rte_port_version.map
@@ -5,10 +5,8 @@ DPDK_2.0 {
 	rte_port_ethdev_writer_ops;
 	rte_port_ring_reader_ipv4_frag_ops;
 	rte_port_ring_reader_ops;
-	rte_port_ring_reader_ops;
 	rte_port_ring_writer_ipv4_ras_ops;
 	rte_port_ring_writer_ops;
-	rte_port_ring_writer_ops;
 	rte_port_sched_reader_ops;
 	rte_port_sched_writer_ops;
 	rte_port_sink_ops;
-- 
2.5.5

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

[Ferruh Yigit]

On 6/27/2016 2:02 PM, Ferruh Yigit wrote:
> Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Hi Thomas,

I got the duplicates with following command [1], does it make sense to
add this into one of the check scripts, -not sure which one?

[1]
# for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
-f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
fi; done; done

Re: [dpdk-dev] [PATCH 3/3] port: remove duplicated symbols from .map

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 27, 2016 2:03 PM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Olivier Matz
> <olivier.matz@6wind.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH 3/3] port: remove duplicated symbols from .map
> 
> Fixes: 9d41beed24b0 ("lib: provide initial versioning")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_port/rte_port_version.map | 2 --
>  1 file changed, 2 deletions(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Re: [dpdk-dev] [PATCH] mempool: fix symbol export

[Thomas Monjalon]

> > Every new symbols in release 16.07 are exported with the version
> > string DPDK_16.07.
> > Also remove the empty local: section which is not needed because
> > inherited from the DPDK_2.0 block.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Good catch, thanks Thomas
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied

Re: [dpdk-dev] [PATCH 2/3] cmdline: remove duplicated symbols from .map

[Olivier MATZ]

On 06/27/2016 03:02 PM, Ferruh Yigit wrote:
> Fixes: 9d41beed24b0 ("lib: provide initial versioning")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_cmdline/rte_cmdline_version.map | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map
> index c9fc18a..04bcb38 100644
> --- a/lib/librte_cmdline/rte_cmdline_version.map
> +++ b/lib/librte_cmdline/rte_cmdline_version.map
> @@ -50,7 +50,6 @@ DPDK_2.0 {
>  	cmdline_token_num_ops;
>  	cmdline_token_portlist_ops;
>  	cmdline_token_string_ops;
> -	cmdline_token_string_ops;
>  	cmdline_write_char;
>  	rdline_add_history;
>  	rdline_char_in;
> 


Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

[Thomas Monjalon]

> Hi Thomas,
> 
> I got the duplicates with following command [1], does it make sense to
> add this into one of the check scripts, -not sure which one?
> 
> [1]
> # for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
> uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
> -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
> fi; done; done
> 

I have started to write a script to check symbol export.
Feel free to start a new script scripts/check-symbols.sh with this
check for duplicated symbols in .map.
I will add my checks later in this script.

Thanks

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

[Thomas Monjalon]

2016-06-27 14:02, Ferruh Yigit:
> Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied, thanks