From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 8A1551B6DA
 for <dev@dpdk.org>; Sun, 16 Dec 2018 23:22:59 +0100 (CET)
Received: by mail-wr1-f66.google.com with SMTP id c14so10431183wrr.0
 for <dev@dpdk.org>; Sun, 16 Dec 2018 14:22:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=3XGZZ4z7JMUvVpJ5pwSjIWiEbw7eGxkO0Y35CJRuu74=;
 b=HHwbFTXmpIp8RQba20OyPiEpF0bu+h23ErO8dIRrxySw5ZzVX+X4eDO6MiuZdc+8IW
 Qc6CtNz9mji5kDXcQqFRUUcVNTgEGnxwcPEW+s0P1O+78yZYrXgQfmySQEM9BjIAVdWo
 6uR1Kyt57QfbXILYP3cWDHHj5ezJdgwSp9odllCAzBhNnNZBWD+3/ekAGCNpIZWhmhXk
 Qc4yiZqq38KWpHlXK7u958qlOm505TUUJ866t73gzD1vIn74c2unTS1U/mwY1rHxEaQI
 HqH9qyMRGUA8UmLBrR/D26RwicFL3WfKNSN80k22XCQO/Y7B6rsAZV4WLRbRTDT8w0JP
 LFig==
X-Gm-Message-State: AA+aEWZhdsxUqjHrlu5PJNHdYIN3g8kxLcByrhsiw3xOXJ3ygcSUX21S
 juU0YVjMhMii5L+ltTgUc44=
X-Google-Smtp-Source: AFSGD/XPif+j44uDCf5V7dHKU2yTwsVy9J2WVbw7bVxynlxjPVv5LzLWPfirSr3RmZOIkotluJLFeA==
X-Received: by 2002:adf:9d08:: with SMTP id k8mr9227315wre.203.1544998978890; 
 Sun, 16 Dec 2018 14:22:58 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:2476:4f8a:d829:f16d])
 by smtp.gmail.com with ESMTPSA id y1sm11147300wme.1.2018.12.16.14.22.57
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sun, 16 Dec 2018 14:22:57 -0800 (PST)
Message-ID: <1544998977.4766.10.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Date: Sun, 16 Dec 2018 22:22:57 +0000
In-Reply-To: <20181216174604.91445-1-keith.wiles@intel.com>
References: <20181216174604.91445-1-keith.wiles@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Dec 2018 22:22:59 -0000

On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote:
> --- /dev/null
> +++ b/lib/librte_dfs/meson.build
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +version =3D 1

You can leave the version out if it's 1, it's the default

> --- /dev/null
> +++ b/lib/librte_dfs/Makefile
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +# library name
> +LIB =3D librte_dfs.a
> +
> +CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) -O3
> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=3D64
> +CFLAGS +=3D -D_GNU_SOURCE
> +CFLAGS +=3D -I$(RTE_SDK)/drivers/bus/pci
> +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev
> -lrte_utils
> +LDLIBS +=3D -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev
> +LDLIBS +=3D -lpthread
> +LDLIBS +=3D $(shell pkg-config --libs-only-l fuse3)
> +LDLIBS +=3D $(shell pkg-config --libs-only-l jansson)

Why --libs-only-l ? If the libraries are not installed in the canonical
path (eg: build-root-without-chroot) it will break as it won't use the
-L

--=20
Kind regards,
Luca Boccassi