From: Lee Daly <lee.daly@intel.com>
To: akhil.goyal@nxp.com
Cc: dev@dpdk.org, vipin.varghese@intel.com, Lee Daly <lee.daly@intel.com>
Subject: [dpdk-dev] [PATCH v5 3/3] doc: update ISA-L guide to reflect checksum support
Date: Wed, 19 Dec 2018 15:48:08 +0000 [thread overview]
Message-ID: <1545234488-86585-3-git-send-email-lee.daly@intel.com> (raw)
In-Reply-To: <1545234488-86585-1-git-send-email-lee.daly@intel.com>
This updates the ISA-L compression driver guide on how to enable and use
checksums and release notes.
Signed-off-by: Lee Daly <lee.daly@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
doc/guides/compressdevs/features/isal.ini | 2 ++
doc/guides/compressdevs/isal.rst | 30 ++++++++++++++++++++++++++++--
doc/guides/rel_notes/release_19_02.rst | 4 ++++
3 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/doc/guides/compressdevs/features/isal.ini b/doc/guides/compressdevs/features/isal.ini
index 919cf70..e705031 100644
--- a/doc/guides/compressdevs/features/isal.ini
+++ b/doc/guides/compressdevs/features/isal.ini
@@ -12,5 +12,7 @@ OOP SGL In SGL Out = Y
OOP SGL In LB Out = Y
OOP LB In SGL Out = Y
Deflate = Y
+Adler32 = Y
+Crc32 = Y
Fixed = Y
Dynamic = Y
diff --git a/doc/guides/compressdevs/isal.rst b/doc/guides/compressdevs/isal.rst
index 3bc3022..af1f41f 100644
--- a/doc/guides/compressdevs/isal.rst
+++ b/doc/guides/compressdevs/isal.rst
@@ -27,6 +27,33 @@ Window size support:
* 32K
+Checksum:
+
+ * CRC32
+ * ADLER32
+
+To enable a checksum in the driver, the compression and/or decompression xform
+structure, rte_comp_xform, must be filled with either of the CompressDev
+checksum flags supported. ::
+
+ compress_xform->compress.chksum = RTE_COMP_CHECKSUM_CRC32
+
+ decompress_xform->decompress.chksum = RTE_COMP_CHECKSUM_CRC32
+
+::
+
+ compress_xform->compress.chksum = RTE_COMP_CHECKSUM_ADLER32
+
+ decompress_xform->decompress.chksum = RTE_COMP_CHECKSUM_ADLER32
+
+If you request a checksum for compression or decompression,
+the checksum field in the operation structure, ``op->output_chksum``,
+will be filled with the checksum.
+
+.. Note::
+
+ For the compression case above, your output buffer will need to be large enough to hold the compressed data plus a scratchpad for the checksum at the end, the scratchpad is 8 bytes for CRC32 and 4 bytes for Adler32.
+
Level guide:
The ISA-L levels have been mapped to somewhat correspond to the same ZLIB level,
@@ -75,13 +102,12 @@ As a result the level mappings from the API to the PMD are shown below.
The above table only shows mapping when API calls for dynamic compression.
For fixed compression, regardless of API level, internally ISA-L level 0 is always used.
+
Limitations
-----------
* Compressdev level 0, no compression, is not supported.
-* Checksums will not be supported until future release.
-
Installation
------------
diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst
index 8deb68b..286c060 100644
--- a/doc/guides/rel_notes/release_19_02.rst
+++ b/doc/guides/rel_notes/release_19_02.rst
@@ -60,6 +60,10 @@ New Features
* Added the handler to get firmware version string.
* Added support for multicast filtering.
+ * **Enabled checksum support in the ISA-L compressdev driver.**
+
+ Added support for both adler and crc32 checksums in the ISA-L PMD.
+ This aids data integrity across both compression and decompression.
Removed Items
-------------
--
2.7.4
next prev parent reply other threads:[~2018-12-19 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11544697752-156863-1-git-send-email-lee.daly@intel.com>
2018-12-14 9:59 ` [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Lee Daly
2018-12-14 9:59 ` [dpdk-dev] [PATCH v4 2/3] test/compress: add checksum tests Lee Daly
2018-12-14 9:59 ` [dpdk-dev] [PATCH v4 3/3] doc: update ISA-L guide to reflect checksum support Lee Daly
2018-12-17 8:19 ` [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Varghese, Vipin
2018-12-17 9:20 ` Daly, Lee
2018-12-17 12:33 ` Varghese, Vipin
2018-12-19 15:48 ` [dpdk-dev] [PATCH v5 " Lee Daly
2018-12-19 15:48 ` [dpdk-dev] [PATCH v5 2/3] test/compress: add checksum tests Lee Daly
2018-12-19 15:48 ` Lee Daly [this message]
2019-01-08 10:29 ` [dpdk-dev] [PATCH v6 1/2] " Lee Daly
2019-01-08 10:29 ` [dpdk-dev] [PATCH v6 2/2] compress/isal: enable checksum support in driver Lee Daly
2019-01-08 14:58 ` [dpdk-dev] [PATCH v6 1/2] test/compress: add checksum tests De Lara Guarch, Pablo
2019-01-08 16:20 ` [dpdk-dev] [PATCH v7 " Lee Daly
2019-01-08 16:20 ` [dpdk-dev] [PATCH v7 2/2] compress/isal: enable checksum support in driver Lee Daly
2019-01-08 17:19 ` [dpdk-dev] [PATCH v7 1/2] test/compress: add checksum tests De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545234488-86585-3-git-send-email-lee.daly@intel.com \
--to=lee.daly@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).