From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F073242B47; Fri, 19 May 2023 11:00:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC89241148; Fri, 19 May 2023 11:00:33 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2088.outbound.protection.outlook.com [40.107.96.88]) by mails.dpdk.org (Postfix) with ESMTP id 0110D40F16 for ; Fri, 19 May 2023 11:00:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQLTIIQmgYVvXorZPgSlI5J/zvDNPwUFB5WEqClOyokYVzWYT3R1MwEinz3RUrrIhf53Bx+kHeYDLWdWVpmVVRa6ke83tnt/gb3p08dvBkt2/CgetWMwsrrNbr4uRIKQVyADj52dn7btTlEvKHNkv6YK++LeOBIJDnxyL4ebci/SU49+ChbY9dBxCKKaxhAwTZPApcLLG0R6Nwf6k8hthXnqWflaMYU6XywO2ELuvIxfJtUE/caB3SQPzuIzLKc1JvwJvArMZGo47p5lZ9W/biu46nncP0SLUh8whi0l+PLD/tmnMPGh5IqXBmOypi6BXXRjyl03DchplO+C43u5tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5wDB5j+eGvPjG7RnVAiE/yW+CgKOwp0As0LV1wIggc=; b=YIQGHciVxZDogtPA72jkeMUMQ5rR7bhB21EH4RaFsMVc3CR1RW0JG07/l/S98Bzy8WdQo8wmpeayHrAJ0wJwBtu4Hderp4hdqdjX/ojbzZSn9d0W7xUKkjatugG8cRJKHTq/TH4QeAFaxULTzjB1LluQEbpYwhou2g6oRevprlV1UFmPMksbId5e1U5VLjLtKSUrU8UV70AjahcvQHSJRC4dS+twywZrmNj87BlpYfWxuas7ioZ8z2bdz10lbXRlRa9PK31vwc6dwJZSoHzqF9KqpFrCvKcYwEXG8NdqkFv5OaLjuVSU2g4N8H/Ec9yYrdAx84uo8csly/iuKwEltQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5wDB5j+eGvPjG7RnVAiE/yW+CgKOwp0As0LV1wIggc=; b=Y9gzq1R20QKSidoF7ZTViHueeHurBTUvwg2T6sFpw+jo3izDbtHUTuGNUYbwmOcmODoazNURUegegfpfBEitgGZAoCqhf5MZ/sj8WAqg4YKpXaZhmu/Mw8voXFXoQh87i9qOxDRj+QQMAbQIsFFe8sQgzq0ANVdWOOfJpt84S0E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8482.namprd12.prod.outlook.com (2603:10b6:610:15b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Fri, 19 May 2023 09:00:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Fri, 19 May 2023 09:00:29 +0000 Message-ID: <15464a44-84c6-1b84-9c80-a6c62c43b85a@amd.com> Date: Fri, 19 May 2023 10:00:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] ethdev: fix asynchronous destroy and push tracepoints Content-Language: en-US To: Alexander Kozyrev , dev@dpdk.org Cc: orika@nvidia.com, matan@nvidia.com, thomas@monjalon.net, adwivedi@marvell.com References: <20230518215928.2366851-1-akozyrev@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230518215928.2366851-1-akozyrev@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0171.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8482:EE_ X-MS-Office365-Filtering-Correlation-Id: 381076e4-1838-486d-0370-08db58477e75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QCYDHK7j+5K4bquValIxx/9tCr6GqdlZJJTsO28UpxxZGyMPc5Zp3rRxViOhWaBlTB+XMGPntK8dx6tsLJ5Lroe7hv/vhVsxeAqkhf3mJIxoAGlyXz60iHYlc6r39Ia4vXwE7yOrhoZkFGB66eEo23zTSnjdM0CBXUw6aEkZbRLEto3zsl90+9EqdxP6ouiXDmTLzHSoNZTNyanp7fZxIc6ZPP/bPokdutI/EkVM02mB1JlKPA9CMoABM5LEFZNwySlwT9UkUOnQFX6moRX3iYVSOktdioRgi/Z7YNZauLa1tQiwiN7nsFvnuaQlMKSop4uBdRalnGHBsMr7dXo0jnePD1fhmML9LYg8QG7bDPGGcUrqEA98uLBsOWmcyhoAZvsd6PywAPXQASvBgd+ytmUyNzWOIAOx5meE1c9nogWiPvTFcFlcwJxw9kBjYp1PgLSWafuKBF/s6MYOEqKPZFuPomtZrQh5/gzlXw+Oh1y14H22AIHWpVxy8uEScB/h14cEj9+5P+GKwlbyF3enbAM6y38C+9Ds1H/U75ytQZELR93DCnBYcEjxJk2nMEhH2fAO1B2vA4YK8Zt7iPMQOKWPkwacphQQOTSRDFcckc4y6M1lzMJQ6schxSMSPKSy9cc/9yn6/KbabvDa+B++9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199021)(2906002)(316002)(478600001)(41300700001)(8676002)(4326008)(31686004)(8936002)(6486002)(5660300002)(44832011)(6666004)(66946007)(66476007)(66556008)(53546011)(6506007)(6512007)(26005)(38100700002)(186003)(83380400001)(36756003)(2616005)(86362001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDc3VzR4VnZ0TWwvZnowbzRwNnV5d1QrYm50Qm92UTNvVkZacWlMNDc2ZEt5?= =?utf-8?B?OW5rQXJFeENkbDlxUnVqTldVSE1vNU5sVVB4MjdKYjdmbjJiOGVIRUtUa0sz?= =?utf-8?B?Zm1yQVFWTzRzUWtUK01SSkVvWmQ0MWl3MXh6bTUzeXlMdytodlBMWEZrelEv?= =?utf-8?B?UWpOenFrdmFHeDc4bVBBQnBUbVVXREdEVzhNZWhtUGRudCtwczRCNTRmL1l2?= =?utf-8?B?TVVwMjViTkxuRTF2dTVMZThZVEZKckJOOG5VR0p4ME1zaHl4NFdUcEJFdTdB?= =?utf-8?B?RXhZT0prVWhIekwyU3gzdnowb2xvUG5kUjRHZDFaRXFNMGZTMXVKV0lvc0c1?= =?utf-8?B?ODZMODlhSlBsZ3hhczJPbXN5SFloRzVNNmRJQm4wQ2R0SUNIV1FqVlZXVnZP?= =?utf-8?B?V1d5K21TUFo5TURhT1VCRHhVbHZ5VnNkMHBWMHEyWUJ0S1hVVHh1OXJsRDRm?= =?utf-8?B?ZFdmQ3U4YXVPbTJOVUQwcTR0eEwrY1Q1c3AwWEJGa3daMTQrVzhaWXA4clAx?= =?utf-8?B?cjk4ZXI1bjdjTWF5M3pUelR2dFg0ZUFhQzcwL0x3QUg2SFRQZndpM2hwOFBG?= =?utf-8?B?QXo4N2pkbWZWNnc0R25VUzdzM0x0STJpenZud3Q1KzRjQWl3U2tGSmFYbytk?= =?utf-8?B?dkIxUnc0bExmOUZ3cGVIMjRCMnlJV0tUOEFmY0ZHQ2xydlAvSjVSa0J2MWgz?= =?utf-8?B?d0xuUmVjVHRaeXhRVnNBMk82WXdPaE4rdXJVZis4QmRGcmlKcEVqVnpJNVly?= =?utf-8?B?MUc0cDhWdTM1OXBGNmZXOWhSV2RudEFjaUNmTlNIdFBNT1pJaHRqNDRmQnZq?= =?utf-8?B?bUhIRElaQ0MyY3Bia3cyR25KVGgyNCtXWU1wMUNoZHl2ZkJOREhOSVRsLzVj?= =?utf-8?B?b2JWVU5GYzVxak44WGtLVzRDdm1HcFhlSVp0b3BvRHAyTFh4dW5TVHpXN201?= =?utf-8?B?SDhWVnFrM2tWVElQdy91RURZWE11LzA1Z3lWSmR6OWhQekE3YlZBZmNVR3FW?= =?utf-8?B?Y2dpK2VMQ3Fpcm1jMElWU0dlVjFRTUp2T08yc0UwamZGWHgyaVVCWWtsZVlx?= =?utf-8?B?WVNmVkQyeVo4MWNWa3Y5a0NlcVA2emgybFg5cTJ4L0hKZ0NSdS9ONXpkb1hh?= =?utf-8?B?Z3JUb2E2RGFIam9rNUswUXpBZzdaYUdCSGEvbnpjTjdGMDAxYjBuYkMzQU9j?= =?utf-8?B?eDhyWFVmdk9xWHM2SEVLUzRQdnZyTm1OTmpHekdQRTUvcTZlMWhGU3Yxamhi?= =?utf-8?B?cDdoZmtSTGhnVHJsaC9MNzkvOTJiL21BS0NRWFcyMHNGam4wdVR0ZHhpY3Qy?= =?utf-8?B?TWUzekp0TXVNNFZsSlNnM2phdEtmUVppOXkxWjVveExGbmxNL2VDbTF0aVdU?= =?utf-8?B?YTRJODI1aWRuSkJXekJ6T2pGMmNKcGprOTA4RnpkVldWbm5vSUpvUWU3dUlN?= =?utf-8?B?YmRwVHlVNWpZcnV2TUh6c09scXNLN2N0QWt2VlloNEpCOXhPbyt1YlNDYmo4?= =?utf-8?B?YWg5cUxZQmI0MHgwQzUzbTFGMkI3bng5blNlN2dhSUEyWUJ3ZzBQUVF1bnBU?= =?utf-8?B?UUxKQXFWNmtFcVJ5ZmY3NzZpRVlScytuMzFUck9FVjlBZE9EZm9UUFZKanNC?= =?utf-8?B?RURmdGNneXMrYTF6SU1lN2c0bm85T05qaTlyMGFzbDhzeXBMOU9JajZtNUlk?= =?utf-8?B?TVJKNyt4WGlsSHB5aFhIdDVEZFdIQVI3TVArQ0NzSFB4L0pjVjZWUlJWYnEy?= =?utf-8?B?WUhKK2s3WmJ6QkM4L1diWGdzQUZXS0QydzM5Ulc2OTFXNXhKSkpHdCt1aEE2?= =?utf-8?B?ZHEwcVRacjhBeGFxc2llY3NrV1I5bjRiVnBsbE5oUGVqTUVtS05PZDZOSkE3?= =?utf-8?B?WlI5OHZkbTVaYzgrc2JMTWFYR05JbnJuSTllaVVhWXRqTFlUWVoyd3F6M3JR?= =?utf-8?B?MDVDUUZmcEJXeWlSbTRJQzVCQ1dTN3Jnc3JWcG1HV2VRRHdjcStOY1FaU3dX?= =?utf-8?B?RW1XTDJJWmx1Sy9OUmNWNG1RVFIvS0hLdDNuVzRPL1EvUTVJNm1Ib3hHd0F5?= =?utf-8?B?bFlCQUUySlNYT1FJYkZObTl0NU1XRDZtUTJ2QlBtNFFKanR6WjhpejNHWXBN?= =?utf-8?Q?C3sIgzG9+49Hvfg0P/k12YJvw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 381076e4-1838-486d-0370-08db58477e75 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 09:00:29.3204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D76CfgM71v1cRez+LGtf9a+HfOMMoWvNFgfx5B3w+alLfhdAXuqdK8bXearLSakA X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8482 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/2023 10:59 PM, Alexander Kozyrev wrote: > > The rte_flow_async_destroy() and rte_flow_push() API is > intended to be as fast as possible and tracepoints for > these functions must be marked as fast-path tracepoints. > > Fixes: 6679cf21d608 ("ethdev: add trace points") > > Signed-off-by: Alexander Kozyrev <...> > +RTE_TRACE_POINT_FP( > + rte_flow_trace_async_destroy, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > + const struct rte_flow_op_attr *op_attr, > + const struct rte_flow *flow, const void *user_data, int ret), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_ptr(op_attr); > + rte_trace_point_emit_ptr(flow); > + rte_trace_point_emit_ptr(user_data); > + rte_trace_point_emit_int(ret); > +) > + > RTE_TRACE_POINT_FP( > rte_flow_trace_async_update, > RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > @@ -2374,6 +2366,14 @@ RTE_TRACE_POINT_FP( > rte_trace_point_emit_int(ret); > ) > > +RTE_TRACE_POINT_FP( > + rte_flow_trace_push, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_int(ret); > +) > + Patch doesn't apply cleanly because it can't find 'rte_flow_trace_async_update', is there a dependency?