DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine
Date: Mon, 07 Jan 2019 13:40:14 +0000	[thread overview]
Message-ID: <1546868414.6022.19.camel@debian.org> (raw)
In-Reply-To: <20190107122401.GA14912@bricha3-MOBL.ger.corp.intel.com>

On Mon, 2019-01-07 at 12:24 +0000, Bruce Richardson wrote:
> On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote:
> > When building for generic distribution we need a stable baseline
> > architecture, or depending on the build worker the result will
> > vary.
> > 
> > Force the default flags if the user explicitly sets
> > marchine=default
> 
> typo: marchine
> 
> > at configuration time.
> > 
> > Fixes: b1d48c41189a ("build: support ARM with meson")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  config/arm/meson.build | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index dae55d6b2..fa21a2fd2 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -6,6 +6,7 @@
> >  march_opt = '-march=@0@'.format(machine)
> >  
> >  arm_force_native_march = false
> > +arm_force_default_march = machine == 'default'
> 
> Do we need a new variable here? Given it only seems to be used once
> below,
> I think just having the boolean expression directly in the if
> statement is
> clearer. If you do keep the variable, suggest putting braces around
> the
> comparison, otherwise at first glance it looks like a chained
> assignment
> like you get in C e.g. x = y = 0;
> 
> >  
> >  machine_args_generic = [
> >  	['default', ['-march=armv8-a+crc+crypto']],
> > @@ -105,7 +106,11 @@ else
> >  	cmd_generic = ['generic', '', '', 'default', '']
> >  	cmd_output = cmd_generic # Set generic by default
> >  	machine_args = [] # Clear previous machine args
> > -	if not meson.is_cross_build()
> > +	if arm_force_default_march and not meson.is_cross_build()
> > +		machine = impl_generic
> > +		cmd_output = cmd_generic
> > +		impl_pn = 'default'
> > +	elif not meson.is_cross_build()
> >  		# The script returns ['Implementer', 'Variant',
> > 'Architecture',
> >  		# 'Primary Part number', 'Revision']
> >  		detect_vendor = find_program(join_paths(
> > -- 
> > 2.19.2
> > 
> 
> With these comments, looks ok to me from a meson viewpoint. I think
> an ack
> from the arm side would be good to get too though.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Fixed typo, removed variable and added the arm maintainers to CC in v2,
thanks.

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2019-01-07 13:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 12:56 Luca Boccassi
2019-01-07 12:24 ` Bruce Richardson
2019-01-07 13:40   ` Luca Boccassi [this message]
2019-01-07 13:45   ` Luca Boccassi
2019-01-07 13:39 ` [dpdk-dev] [PATCH v2] " Luca Boccassi
2019-01-07 14:11 ` [dpdk-dev] [PATCH v3] " Luca Boccassi
2019-01-11 10:45   ` Luca Boccassi
2019-01-14  8:09     ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-14  9:58       ` Luca Boccassi
2019-01-14 10:35         ` Jerin Jacob Kollanukkaran
2019-01-14 11:07           ` Luca Boccassi
2019-02-27 12:15   ` [dpdk-dev] " Luca Boccassi
2019-03-20  5:01   ` Pavan Nikhilesh Bhagavatula
2019-03-20  5:01     ` Pavan Nikhilesh Bhagavatula
2019-03-20 13:18     ` Luca Boccassi
2019-03-20 13:18       ` Luca Boccassi
2019-03-20 13:18 ` [dpdk-dev] [PATCH v4] " luca.boccassi
2019-03-20 13:18   ` luca.boccassi
2019-04-17 20:27   ` Thomas Monjalon
2019-04-17 20:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546868414.6022.19.camel@debian.org \
    --to=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).