From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 2C7FC1B879;
Fri, 11 Jan 2019 11:45:42 +0100 (CET)
Received: by mail-wr1-f67.google.com with SMTP id j2so14716562wrw.1;
Fri, 11 Jan 2019 02:45:42 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:content-transfer-encoding:mime-version;
bh=UOyvZcxC0+YOQdefeqrxgv5z2av5cDLqrQRIWGQmIMg=;
b=mp3wRwlDThIyGgDfqglGOoLFE6hilx3o3zv1sVvGgwWXdlzo+tRQM+D/hsTvroeYWp
/41cOm/iJ4db+kse+/09kU8uZ8h3yiJNdeiaYuNAKGHC0dDnSnKo2RdtTWrSHtwh5UL1
h9RwVp9P8cqdoWqHGD03oCM6sTXpMyopIAKwBHTRm4fLpnVEEPxjp55FLg+tbZq9L4ne
Jthlnj3TBUNggluOCFOWf85ci5wzuJ/eDD2UHPI8fzJQEovAMLjpIjpVmqOg/TbE2ApI
oQkc52DufOOZ9w6LzK2uTi7j27HMr+uK0PVg1w1Iriyc4YlR2wjPhJ/fWrS8U99QezmA
HXFw==
X-Gm-Message-State: AJcUukf2TI5evkypqvmF1SWrkeKxFjwlbPix5VXG8E5t/Td4C1JGSA8K
mQuOn+dYW20jMC9dNL7aM/hvpgG81Uo=
X-Google-Smtp-Source: ALg8bN7M9MX4vito60dELkMB6kDcS7fdoK7hoqsFPhR5HD4XV2Q5MHCg+k+iYt1ngu/S+PHjdR0T7Q==
X-Received: by 2002:adf:9361:: with SMTP id 88mr12514416wro.204.1547203541231;
Fri, 11 Jan 2019 02:45:41 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556])
by smtp.gmail.com with ESMTPSA id 202sm24314724wmt.8.2019.01.11.02.45.40
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Fri, 11 Jan 2019 02:45:40 -0800 (PST)
Message-ID: <1547203539.4501.7.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: dev@dpdk.org
Cc: gavin.hu@arm.com, viktorin@rehivetech.com, jerinj@marvell.com,
stable@dpdk.org
Date: Fri, 11 Jan 2019 10:45:39 +0000
In-Reply-To: <20190107141130.24360-1-bluca@debian.org>
References: <20181224125627.25690-1-bluca@debian.org>
<20190107141130.24360-1-bluca@debian.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when
using 'default' machine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 10:45:42 -0000
On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote:
> When building for generic distribution we need a stable baseline
> architecture, or depending on the build worker the result will vary.
>=20
> Force the default flags if the user explicitly sets machine=3Ddefault
> at configuration time.
>=20
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: fix typo in commit message, remove variable used only once
> v3: put back temporary variable, as "machine" gets overwritten
> =C2=A0=C2=A0=C2=A0=C2=A0by the function and loses the original value befo=
re we need
> =C2=A0=C2=A0=C2=A0=C2=A0it.
>=20
> =C2=A0config/arm/meson.build | 7 ++++++-
> =C2=A01 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index dae55d6b2..614139534 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -6,6 +6,7 @@
> =C2=A0march_opt =3D '-march=3D@0@'.format(machine)
> =C2=A0
> =C2=A0arm_force_native_march =3D false
> +arm_force_default_march =3D (machine =3D=3D 'default')
> =C2=A0
> =C2=A0machine_args_generic =3D [
> =C2=A0 ['default', ['-march=3Darmv8-a+crc+crypto']],
> @@ -105,7 +106,11 @@ else
> =C2=A0 cmd_generic =3D ['generic', '', '', 'default', '']
> =C2=A0 cmd_output =3D cmd_generic # Set generic by default
> =C2=A0 machine_args =3D [] # Clear previous machine args
> - if not meson.is_cross_build()
> + if arm_force_default_march and not meson.is_cross_build()
> + machine =3D impl_generic
> + cmd_output =3D cmd_generic
> + impl_pn =3D 'default'
> + elif not meson.is_cross_build()
> =C2=A0 # The script returns ['Implementer', 'Variant',
> 'Architecture',
> =C2=A0 # 'Primary Part number', 'Revision']
> =C2=A0 detect_vendor =3D find_program(join_paths(
Any chance for a quick review from the arm maintainers/devs? Thanks!
--=20
Kind regards,
Luca Boccassi