From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id EC17410A3; Thu, 17 Jan 2019 23:48:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 76BDC28363; Thu, 17 Jan 2019 17:48:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 17:48:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6EHBMiMKkIpHYvC7/YU5afy8ZH+vyZczzwn0iqEtVCo=; b=fGtNONWoE74c tzLvSwFAySEecPGkV/2vb2o6WMfEz6NKRVYLBZhmvS11ORBKnsKNtB/MgIYMiezk 50CnFNp0TAhFxZICUnNzWQPhddmxdIFuKBO70uprwJ2XICnA0rmHBtJSt/ikmOfl sWVsQeVO0DGgVFjpvA09gg1BNC63rS8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=6EHBMiMKkIpHYvC7/YU5afy8ZH+vyZczzwn0iqEtV Co=; b=jrlrmOQ9lG/rnFV1qaOKROU3tnZMxYtwBUrDcS83VcmQb5fobygrCAWEs qq+Sjx26YCJDfb+bq8Q6vywODoCSvDIKtAbnVxNacSJF68Qlv0tzy+tANLdB40tN 4JBRNN9SHlG5ymJS0ZNqOhBfpkYOXeLavvb/C+hwxZoppwAV/6m7yq7GZN556fmX K+S3bHh5+D1xKeo70hZWkifXteGp4Os62a29QV+STckVPSY3NGiTGGm2f74wsOYb yKwvnH1LlTALF+QsDGP/p6jShhHLmrCWGDxqdhdI/BCdZv6CNxc3FHfD2QPJ4+i5 TYLfhr0vfkCJgNHxmrvdn1bx76Ppw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgdduieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 97233E407B; Thu, 17 Jan 2019 17:48:26 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, "Phil Yang (Arm Technology China)" , "stable@dpdk.org" , "he.qiao17@zte.com.cn" , Igor Ryzhov , Dan Gora Date: Thu, 17 Jan 2019 23:48:25 +0100 Message-ID: <15486437.2BuXh0EO9Z@xps> In-Reply-To: References: <20190115172802.72238-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/kni: fix crash while handling userspace request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 22:48:30 -0000 > > When KNI interface receives RTE_KNI_REQ_CFG_NETWORK_IF request, it > > stap/start the physical device which as a result of stop() can free all the mbufs in > > its queue. > > Meanwhile sample application continues to read from KNI interface queues and > > push into device queues. This simultaneous access may cause a crash, crash log > > can be found at defect description. > > > > As a solution KNI sample application can do the proper synchronization, and > > stop transfer between KNI interface and physical interface while physical device > > stop/started. > > > > Bugzilla ID: 116 > > Fixes: 3fc5ca2f6352 ("kni: initial import") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Phil Yang Applied, thanks