From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix build error on BSD 10 / GCC 4.8
Date: Thu, 20 Jul 2017 18:32:11 +0300 [thread overview]
Message-ID: <1549179.tPcfIyeouT@xps> (raw)
In-Reply-To: <c74e5301361f6d326e5f2eac32e5d12732168ed6.1500553652.git.gaetan.rivet@6wind.com>
20/07/2017 15:27, Gaetan Rivet:
> ctype.h is not compilable in BSD 10 on GCC 4.8 in C11 mode.
>
> == Build drivers/net/failsafe
> CC failsafe.o
> In file included from /usr/include/_ctype.h:94:0,
> from /usr/include/ctype.h:46,
> from /root/dpdk.org/build/include/rte_common.h:50,
> from /root/dpdk.org/build/include/rte_memory.h:57,
> from /root/dpdk.org/build/include/rte_malloc.h:45,
> from /root/dpdk.org/drivers/net/failsafe/failsafe.c:35:
> /usr/include/runetype.h:92:22: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'const'
> extern _Thread_local const _RuneLocale *_ThreadRuneLocale;
> ^
> /usr/include/runetype.h: In function '__getCurrentRuneLocale':
> /usr/include/runetype.h:96:6: error: '_ThreadRuneLocale' undeclareds
> (first use in this function)
> if (_ThreadRuneLocale)
> ^
> /usr/include/runetype.h:96:6: note: each undeclared identifier is reported
> only once for each function it appears in
> /root/dpdk.org/mk/internal/rte.compile-pre.mk:138: recipe for target
> 'failsafe.o' failed
>
> The fix is to put GCC in gnu99 mode instead.
>
> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-07-20 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 12:27 Gaetan Rivet
2017-07-20 15:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549179.tPcfIyeouT@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).