From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 16E9B29C8 for ; Thu, 20 Jul 2017 17:32:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A39C4209ED; Thu, 20 Jul 2017 11:32:13 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 20 Jul 2017 11:32:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=jQiH7CKJA/JWK8X dNRuJFWzG4dwuv9hl0P4sU5HIqk4=; b=C5ydTBjblGaElSSh9eiJtVwcsdAgdV2 2lT3shtqLeg57YWQU1cC82mpXQ3uusgviyEnXvoL9CFYYpdXrM3v3G2PhUPc/MF6 o8KNMMI8HWsTeMVwHjtPbMPa5iyxc4D/XPVZXiCvyzD6J0j8Qd7bFDj+ZGa6fw/X NXOw9co0E0kc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=jQiH7CKJA/JWK8XdNRuJFWzG4dwuv9hl0P4sU5HIqk4=; b=HWQqCsLg krk+3l/BPEQd6SuqByqeJJCk18v+tXxJkB/H/5lS2+zhfKbqSNduqcFO7zyjJvGO IvNUJ9oBTdl4Bwne6AvWSo+zuG3GlT5sVrfbibiyPACSVMMYxLu2amNTXoA82vXL Gc6p0sRXAfZ3OuDQXZZKjy0IoJXAQCsc77pQBVMRHR7Y1rIGlpCJE7NRWOVvXAg8 UK4q94HsLUZPvsrbHtVEkTqmECrDKEJTZpXse0DOGysJRyPPSlQ5CTa6x6JZapHi ylpkRII3t4TDyEi6vf5YbKK1GnoBjlckRLFeXHNNH6RKR4OMVPdjIO6gg/qH1oGU WjdOMoC9jED+EA== X-ME-Sender: X-Sasl-enc: pvyo7TBqGVYEjuPs/xUOQOFApsEaY+vW4j1ZQMjJOrxx 1500564733 Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E97B7E4AA; Thu, 20 Jul 2017 11:32:13 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Thu, 20 Jul 2017 18:32:11 +0300 Message-ID: <1549179.tPcfIyeouT@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix build error on BSD 10 / GCC 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2017 15:32:14 -0000 20/07/2017 15:27, Gaetan Rivet: > ctype.h is not compilable in BSD 10 on GCC 4.8 in C11 mode. > > == Build drivers/net/failsafe > CC failsafe.o > In file included from /usr/include/_ctype.h:94:0, > from /usr/include/ctype.h:46, > from /root/dpdk.org/build/include/rte_common.h:50, > from /root/dpdk.org/build/include/rte_memory.h:57, > from /root/dpdk.org/build/include/rte_malloc.h:45, > from /root/dpdk.org/drivers/net/failsafe/failsafe.c:35: > /usr/include/runetype.h:92:22: error: expected '=', ',', ';', 'asm' or > '__attribute__' before 'const' > extern _Thread_local const _RuneLocale *_ThreadRuneLocale; > ^ > /usr/include/runetype.h: In function '__getCurrentRuneLocale': > /usr/include/runetype.h:96:6: error: '_ThreadRuneLocale' undeclareds > (first use in this function) > if (_ThreadRuneLocale) > ^ > /usr/include/runetype.h:96:6: note: each undeclared identifier is reported > only once for each function it appears in > /root/dpdk.org/mk/internal/rte.compile-pre.mk:138: recipe for target > 'failsafe.o' failed > > The fix is to put GCC in gnu99 mode instead. > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > > Signed-off-by: Gaetan Rivet Applied, thanks