From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id A66D42BBD
 for <dev@dpdk.org>; Mon, 11 Jul 2016 14:58:57 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id f126so88432190wma.1
 for <dev@dpdk.org>; Mon, 11 Jul 2016 05:58:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=doU1krSG9xu/VrELFCJn/2DYms5KYXUUlPeAdD9ZXiA=;
 b=bvfZY+Qd/ePhDx4fmr80kqNOAvFgRGMKOUGtUy2MQDMDT46G4XngjwcA1ezHR4XFEY
 U/LTS79BNm95fug2tO7XxhgfaQdTwyJt1SzdMJIb+g3IMbmQ4x8xXSDA/U5HV366tXHx
 /VQXsx6uH/v5Ba2iAAGB4F5aRvwn2wc+1xoOTUqLcLbZTTJfh6U7udIh4V1s49X4khU2
 f1LKCWay/izPBkSv8a/IhLL9FPvLnW+wSZ9mtYlBDwWJFDBPt1pa+vu07qhGrkX6S56F
 QG9IyrbnqjjnVgJ+/DHzYusYmmia0oQgJoWp+sVX74UCmURiWJPwTTvBjT5hR/JjAzvq
 yFxg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=doU1krSG9xu/VrELFCJn/2DYms5KYXUUlPeAdD9ZXiA=;
 b=WGPhNkOof3vMU2gumgrcSifpMJbnUWnoXil/dUkOLCZBsEkbB0diW9vpuBFKpr7WPf
 FJzxBJ8/SD6wE7V+6oeCy3tDILqUkguHg+VgPuIlpM8BK8hmc4IRia+NFJHTa6B2oWL5
 GQqBTYIvX7z+hCo1JB3yEQ75VWgfSfYQSGyshX0VjH/O9jcYfzVajYmgCxznkHVbqtlu
 iVEu9WaWX89tjE0sdWiPhSvSikbwrcO5S22ImJ8WJ/3hJo2gpmOJqql9p3KkaoY9QRJh
 zIYIfYtxcGA8TRyqFVKJuxBNzdr7G0+YUFTVYKz+BZaqrgy4E3XcqM1NyQ0c48hDf8Le
 3jyw==
X-Gm-Message-State: ALyK8tKqn/lMH0A/h1iuQ48oEWNocGTgtZqM7Ls/vUTmaptAK5lqLXnvKzPnyVMfDelfQMZw
X-Received: by 10.28.128.15 with SMTP id b15mr12833088wmd.100.1468241937414;
 Mon, 11 Jul 2016 05:58:57 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id f73sm29527130wmg.1.2016.07.11.05.58.56
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 Jul 2016 05:58:56 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Eric Kinzie <ehkinzie@gmail.com>, dev@dpdk.org
Date: Mon, 11 Jul 2016 14:58:53 +0200
Message-ID: <1549476.KsTX9tT3L4@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1468236421-30752-1-git-send-email-christian.ehrhardt@canonical.com>
References: <1467805145-24817-1-git-send-email-christian.ehrhardt@canonical.com>
 <1468236421-30752-1-git-send-email-christian.ehrhardt@canonical.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_bond: fix exported symbol
	versioning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2016 12:58:57 -0000

2016-07-11 13:27, Christian Ehrhardt:
> *update in v2*
> - add missing changes in rte_eth_bond_8023ad.h
> 
> The older versions of rte_eth_bond_8023ad_conf_get and
> rte_eth_bond_8023ad_setup were available in the old way since 2.0 - at
> least according to the map file.
> 
> But versioning in the code was set to 16.04.
> That breaks compatibility checks for 2.0 on that library.
> 
> For example with the dpdk abi checker:
> http://people.canonical.com/~paelzer/compat_report.html
> 
> To fix, version the old symbols on the 2.0 version as they were
> initially added to the map file.
> 
> See http://people.canonical.com/~paelzer/compat_report.html
> 
> Fixes: dc40f17a ("net/bonding: allow external state machine in mode 4")
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Applied, thanks