From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5A3B11CA95;
Thu, 5 Apr 2018 12:03:09 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 96E79207F1;
Thu, 5 Apr 2018 06:03:08 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Thu, 05 Apr 2018 06:03:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=7Au8i0DDR5uNyIZ7zA3+CsL5Fz
JAQ1T7zHJsdob2FJU=; b=fx5KbzQpuwTSKnXghd0abU3r+AxJpyrHv6YS8R5EB5
+CR/9KATK4EuTleC3sK8nIxdCJoBVeoAIXR++lJyYv+AE0FWbZ+X3fCdPM/26dTK
BgWfUkSPnjlxKDtK5Bdjpy48Cjb9ws0YUlLnE0ymdaJCOZE6N4AQZtiOaMpwXtaq
A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7Au8i0
DDR5uNyIZ7zA3+CsL5FzJAQ1T7zHJsdob2FJU=; b=nYju30pLsg6/vhXmtntp3k
jXn/xWedsjhlUWXxXQ/2VFcLkwteKCyHVQ9wrvMuxle7RWj7EYk1uh1/AfnuRjVG
6dWDlHyoP8pLXCuRG4StY15nk+Mtf/6I2xHdRUpesC89M7YZx9m4MP+a/yEnbG8g
GYfn1mvSF/m5TzWqhJSGCeUVWHb0KiHZPVpkmdkiDZRzmHvGQbaH4e0cqzt9rc6C
X+70vrmRfzW1GZuUo5hxTqMgzbJt9qki23tg6IwQ1bfcsdbV0jT9NnRUJO1koRu8
bztfvHxZ7CAZvnz8RP3t2AnVBQIRB0WJV9GLfi6qkoz6QL6AqMLKqI7cUDifI/Kg
==
X-ME-Sender: <xms:XPTFWmu5cznEtqkWgzWzonhPQier2O1UwFb8tdjr0bOgIKIBZ1nbpg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id B4E0FE502E;
Thu, 5 Apr 2018 06:03:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Chas Williams <3chas3@gmail.com>, Chas Williams <chas3@att.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, skhare@vmware.com,
stable@dpdk.org
Date: Thu, 05 Apr 2018 12:03:06 +0200
Message-ID: <1549783.CbrISpF0YD@xps>
In-Reply-To: <c7a2017c-c78b-4b7c-a7a5-6e172724d4a1@intel.com>
References: <20180318014552.16703-1-3chas3@gmail.com>
<c7a2017c-c78b-4b7c-a7a5-6e172724d4a1@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state
consistent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:03:09 -0000
20/03/2018 15:12, Ferruh Yigit:
> On 3/18/2018 1:45 AM, Chas Williams wrote:
> > From: Chas Williams <chas3@att.com>
> >
> > The vmxnet3 never attempts link speed negotiation. As a virtual device
> > the link speed is vague at best. However, it is important for certain
> > applications, like bonding, to see a consistent link_status. 802.3ad
> > requires that only links of the same cost (link speed) be enslaved.
> > Keeping the link status consistent in vmxnet3 avoids races with bonding
> > enslavement.
I don't understand the issue.
Are you sure it is not an issue in bonding?
About the right value to set for virtual PMDs, I don't know, both are fakes.
I thought that AUTONEG better convey the vague link speed you describe.
> > Author: Thomas Monjalon <thomas@monjalon.net>
> > Date: Fri Jan 5 18:38:55 2018 +0100
> >
> > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
> > Cc: stable@dpdk.org
>
> There were a few more PMDs [1] they have been updated from FIXED to AUTONEG with
> above commit, do you think should we update them back to FIXED as well?
>
> [1]
> pcap
> softnic
> vmxnet3
Yes, they all can be fixed/LINK_FIXED :) I guess