From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 07060A3; Tue, 19 Mar 2019 13:48:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66C1C307D961; Tue, 19 Mar 2019 12:48:09 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AC9B5C64C; Tue, 19 Mar 2019 12:48:07 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-3-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <154ac18a-f16b-ba4f-44ac-3d43bc11139e@redhat.com> Date: Tue, 19 Mar 2019 13:48:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319064312.13743-3-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 19 Mar 2019 12:48:09 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 02/10] net/virtio: fix interrupt helper for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 12:48:10 -0000 On 3/19/19 7:43 AM, Tiwei Bie wrote: > When disabling interrupt, the shadow event flags should also be > updated accordingly. The unnecessary wmb is also dropped. > > Fixes: e9f4feb7e622 ("net/virtio: add packed virtqueue helpers") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtqueue.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 707E1A065E for ; Tue, 19 Mar 2019 13:48:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 386B82956; Tue, 19 Mar 2019 13:48:11 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 07060A3; Tue, 19 Mar 2019 13:48:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66C1C307D961; Tue, 19 Mar 2019 12:48:09 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AC9B5C64C; Tue, 19 Mar 2019 12:48:07 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-3-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <154ac18a-f16b-ba4f-44ac-3d43bc11139e@redhat.com> Date: Tue, 19 Mar 2019 13:48:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319064312.13743-3-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 19 Mar 2019 12:48:09 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 02/10] net/virtio: fix interrupt helper for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319124805._D3O2rEOv__AD0yu2CpYMlv6NutN-787oPwX0lUzQto@z> On 3/19/19 7:43 AM, Tiwei Bie wrote: > When disabling interrupt, the shadow event flags should also be > updated accordingly. The unnecessary wmb is also dropped. > > Fixes: e9f4feb7e622 ("net/virtio: add packed virtqueue helpers") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtqueue.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime