From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 524DBA0032; Mon, 15 Nov 2021 20:02:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAE8141147; Mon, 15 Nov 2021 20:02:14 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D63C941144; Mon, 15 Nov 2021 20:02:12 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="220717349" X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="220717349" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 11:02:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="592249721" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 15 Nov 2021 11:02:08 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 11:02:08 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 11:02:08 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 11:02:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l05eKNwZyR4o3vT5QKA9ccFtJDKnUu/HcuE+D02Ds2SrskIwIXak5qu6FsqYqyO/P94ChAfuSx4vOpYc99PGjE4SCReXoAUJYrjoOUQGtu6aBXr/8kHldIuSSxm2gg40TrW5Y9C60ITWRNdplP9QdbHL6+t02I0Loo7ztDsgOCJ+V86lq5F6OhyY0fhAFM8wALimB/lma0x9IfU9Badhrrw41ym5SFcmZJm4Jpxd99qE6uBcmk+psXlfpcQR4ELkDOnwnZZ7+KDfUhyqKh0HbCsF6SRabkP12A+jtEASu644I+Gm+ktKR1NE64hr5X2ifIETtB/7HTjI5r3T0W8+5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6xEau/u9OYecPpVNJR9XOy0v3spCiUDqxW7qTxUd0iU=; b=BGrwo/yRT9omgQUUdrUTJcvdPYvUsE0Yr/4EN5cIF/JlyQl3A3ps0nN0N5WjZ4egYyPBeC0MxElYQ9P29QLnEIlWqv1VtfPgfOYyFoFCyBM6EAfCNh/W8eXoaObnbWxRzwvjFNoJa1WdmCZPPBkU8ELJKPTicrPa1kfIGDA3CVmgCzoTUQDYnL6iMgyC7GqhFosNU3nBQuXDe/WYvsdzSasElFojw93WjIOPq7hbGiZUtBjFNubtzW5y28Pq+s7UT8A5YIDPp3YMN+82lrMlHhOGfEOF/sni2qmxWb8Wj2fiOyHt4AFUyBxY9m3qyRcP6Y0Cj+EOo/lPwBBd3EU8nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6xEau/u9OYecPpVNJR9XOy0v3spCiUDqxW7qTxUd0iU=; b=stdUFmmRjGGlfEWBmD7OmLJ5qAVa1t6+42MP5Vnx1fuNlG1mgEP0YtXiho5ZN0V+qTn+dZ+xlgBDVsVlkZuLkHCKEiwupaYOqi8K7nyey+JBKxV20+lvM66jkHpWVPPU//pHErSAonhLrVxJIcji9JLTjqi56qJ3bXoAQv6ljp4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5128.namprd11.prod.outlook.com (2603:10b6:510:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 15 Nov 2021 19:02:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 19:02:07 +0000 Message-ID: <15512c80-0374-2d4a-6816-354166a22923@intel.com> Date: Mon, 15 Nov 2021 19:02:01 +0000 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length Content-Language: en-US To: Raslan Darawsheh , Ori Kam , CC: , Xiaoyun Li , References: <20211104093518.8922-1-rasland@nvidia.com> <20211104094027.9329-1-rasland@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211104094027.9329-1-rasland@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:10:1d9::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:10:1d9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend Transport; Mon, 15 Nov 2021 19:02:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07e17b54-6a92-47f4-8ac7-08d9a86a6b12 X-MS-TrafficTypeDiagnostic: PH0PR11MB5128: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aroPhHu4bSTM5RrmP1t90/DSuO54mP0+SuRQwHiqOKidRYSEdN06j4S3uR2LMXVpj2vYUtmyeFMjlnSpgT+2ozXMpkvQ1y+BeyeiW4pCRYwufqTyGYBngV/3g/fvesmPwvEhr4itzgztiANjtf/8g2o/4G53kgcVa8Giqj1tS4RF4/b+HYJ7fNk5IUPOIWlPB6BfrZO1hN9dDGp05mZNXhmftygDBtlsG0c6TXQtccL7+JR5iZeal1WwXBsMKx2fB31j5Ex8d9jqwGuUxuRb1kUsnYYztUlmptlfKO41imJIFaWLXZ2q322k0IKLcVxIGH7Pg6619ya6SUfdm4HPluYbYZgd8uKfe8d/a+7dFl3zOLsfRiyUjYkmPWPO75m+7jEOHH1tace9giJu17255ANnxZtSKFKf/Ur8NWhMS7AsGGUc0c3HnnMGhawWv+s9kwwbiEZnRohOyThPkSGONoFIO5KQ89BWIjCv2Y6YQREEn9Qw5fk4JvzmXLvnrG2nG2BVBabgctFO+Emg2+m/8TRQWVr7NQ+Hv4axOwAKzFmPURmrwlfMxNoeqMJ7XE8kJLRqc0hg8SVv5cw0AVCbRzcxEeDmrjmM09n0a769cp5NBwrHniPc7N+xQEprgt1KIaP/cJwwK5x4y4orcWB7yAFIW2rkllpKzz5cvFl3bk0ltEMlbgWbZC+HF/bdZLsH08Nt+uNcIK8+C+WJDZAJ9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(31686004)(5660300002)(2616005)(186003)(44832011)(8676002)(36756003)(956004)(6666004)(31696002)(66476007)(110136005)(8936002)(38100700002)(26005)(316002)(16576012)(508600001)(4326008)(86362001)(82960400001)(53546011)(66946007)(83380400001)(2906002)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFUrY2VONXRMczhCN2JQMzdFY0x6YktFRkxQRHpSaVd6SUF4WHQ1dDd4L3cr?= =?utf-8?B?aVFnRjdjVXowREl3cS9GbE01bVNyZDh5V29LemNjVXJqS21oTXVnK2lUbGVt?= =?utf-8?B?Mk9hNEZPTjNHanlpMnYrY3AvYUpjVUloN1BNTllKRUNsM3l2WHVLNUtTVDVM?= =?utf-8?B?cnhUWFZrc21VQnZ3NERVSksxVTFqbDlROW9wR0Fhc3hvNlVmZTkzZVVDZURF?= =?utf-8?B?OTZHRnJCdllkald3UEtSYmR0M3RkeS9HWG54Y0dyZXBha3NsT1hmVkc4SGda?= =?utf-8?B?dUxPdlJXbXkrSkFVRmVnVytTOC9oTy9UNGp2UHVMU25Da1AyRG5qY3BmQ05H?= =?utf-8?B?UHBQSG44ZURVYnZ3Z0RRN3RrV200Q1AxRE5oV2JiNFM2WWkxeUw0ZS94N3I1?= =?utf-8?B?bW81MUlOcUpETjdXWHhyZUtha25SZXYyTUJiTjRiZlJ1MUc5Wk83YzJxQU11?= =?utf-8?B?Q3Y2ejh1VWQwMU13dkFoR3hLMThFRTNJNURRcE5oYzNhSmtBcVIyWUF5MVls?= =?utf-8?B?c1JFUS80ZFZpUVJqSzVmUUJLb3RrbWtBNUpWSmppWXRGNUtCaHBsWVJYaUpp?= =?utf-8?B?VFdSVXFHanE4SXRqVTBxZmI4MStBVXM4TkNzNUsxRDBmZmttM0RtcnZCTStz?= =?utf-8?B?ZEFVT3VGbGk4N3Vub2hnVlljblgyei9qVlo1N2UvQW9mUi9TcHBES3NESG8x?= =?utf-8?B?OUpiRlpjRkZ3d2s3RE53YndvVDQwTEpiNjlmbmNlcGNjeVV3YXdldGNhZlhO?= =?utf-8?B?VnNlSzBXdXRyenlra3FFcUR3ZUZSSEpWLzMyLzNwTFJ1UkpWcVVDZEFtRmZC?= =?utf-8?B?czFPUDlocFRvOGJWT0VtV0U5L0VjV2dZQnV6L1JtZ1dUc2tNS3dkZVZoV25X?= =?utf-8?B?Z1hxNGpKdVcwRUJUekNRSEtoYzBmVWtieXlqeG1DK21YZk83YU1EZ1kvUVd3?= =?utf-8?B?dVJ5UENvRHM4SEszSUl0WWNIbWlTUlRFUllQNGo0SG85N2FXMGFWcWpUb01X?= =?utf-8?B?b0pSOVo0bTEwdExSOWVxeUlpTjkxWkhNOUhnSjY4ODgxZXc1M1ozY0dPWEFB?= =?utf-8?B?UmhTM0JGdktNS2tycHU1WlVIclRrUjNtTm9SWVFPRGpXL2M3dDliYVVrNlpx?= =?utf-8?B?UFdNZEQvRFl6SGNsbXhadjl6RWR5eVpZTFlHRVhMNjBaTkM2UWx0bTY2ZUd2?= =?utf-8?B?R0JMS3UxSSt2Nm85TExVTDBTVWh0WHhlV2xDYjFuZGYzZ3FUWWhmTllZcFhv?= =?utf-8?B?MTdMbm5leVFZdzgrRHpNMEhXdzJNOU1mVVRleW1UUzBEWWRod0FzWE5UY0o1?= =?utf-8?B?UjFPMU92eWNBL3JsbUpBMWNJa0V1YzVyYXJ0dVZWNVVpZVhDWitrTzdTcGRh?= =?utf-8?B?a21NNUxYMUx6OWV0SWd1L2ExbTFBQlJsMWJyY21Db2k4ZjhQdE5kTVRwVW9l?= =?utf-8?B?NytLMDJWaWpzYkJjNDRYMHU1UDRqdEJSWFcvSlE1REVDR2ZsSzlrZ29lL0Rw?= =?utf-8?B?anI4Y2dNYzBXeGV2aUJZY0ZxL0F2OS9Za25wdkN1ZFd3OGRQLzRxMVhVaHQ0?= =?utf-8?B?bzBPYkxSVm1SMVYxS0lqdlIwNmNzOHd2dkxDZ2RFWWJWTGk3emVwQ1JseVFO?= =?utf-8?B?UUxpY0FDYXQzR1B6SFVZMjJEWm50Vm9sZnFkTmxMQlVhMm5wSko1WlN5Wm1o?= =?utf-8?B?U0RXUFZTbFU0SlROMEp3alE3Wjc5MGQwQkFuYjlUUWEyZlhPalB1YXpVdzdk?= =?utf-8?B?NkprSWVNUlZJcVFYTGV5bWFwd0l4cEpnKzZVcmxUMkVsTUtHYXRwSXVqc0Yw?= =?utf-8?B?TUt5UFc1YWNHcmxHU1ovZHNNK1BlaHl2OXVxQ3NaTzJjYlUydFJDSVFCeURr?= =?utf-8?B?aXJXVGhmeGJadTNlWllSU240SUJETE9PV0RPY2VkQ0VtbHhxWDZuV2p4T0Qr?= =?utf-8?B?b01IUEtBY3JUU0FUUEJPK2t1a1BBaVFwcHBTM0RqQXlBV3RlcHJiNHVMN1h5?= =?utf-8?B?U0lhbUt3WS8yTEZlamFBNzRkOEFnV0o2bjBBV2l5OHc0OXRCamhQV2tvazZl?= =?utf-8?B?M002YWgyUERBekhtbzFrQ2JMY3VJYWxzMCtaRXFTbkZwajhwWXlvNndoMENR?= =?utf-8?B?VTRrK2E1eXVWR25KRU9iYkUzTjNuSkdCYTBubzNuV256SERMQjYySHd4TVRn?= =?utf-8?Q?bIzMdJWww8xq0kWlk27LVjM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 07e17b54-6a92-47f4-8ac7-08d9a86a6b12 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 19:02:06.9437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k/6AwsFMpqRkQ0kGl5RJsMPXUyv287y2ifsgDVCmzjrlqgmaT/j120MxGwIUlmi3pxMe8Q1H+IMjG9foTGNy+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5128 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/4/2021 9:40 AM, Raslan Darawsheh wrote: > Current implementation for raw encap sets the length to be in bytes, > but, GTP 'extension' header length is an 8-bit field in 4-octet units. > > This fixes the length calculation of the header length. > > Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets") > Cc: viacheslavo@nvidia.com > Cc: stable@dpdk.org > > Signed-off-by: Raslan Darawsheh > --- > v2: fix spelling issues > --- > app/test-pmd/cmdline_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 24b224e632..b4c5aacdbe 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in) > uint8_t qfi:6; > uint8_t next; > } psc; > - psc.len = sizeof(psc); > + psc.len = sizeof(psc) / 4; > psc.pdu_type = opt->hdr.type; > psc.qfi = opt->hdr.qfi; > psc.next = 0; > Hi Ori, Slava, Can you please review this patch?