From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 62E1B231C for <dev@dpdk.org>; Fri, 14 Oct 2016 17:08:10 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id d128so3202597wmf.1 for <dev@dpdk.org>; Fri, 14 Oct 2016 08:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=iZxl2a9uFFVZIP5RFW0oBHa1mDruZPdHcvImCztX6xY=; b=w3hs0D+5GUx6QWbc7/Mw1DqVJ7MXbFbWPmVS3DbqllVzkN5Q3e7MftYq0m5LjOng59 MFMAkDhWfMDOec0A4mDoduWLZdqvk/PcuLpnnNKrmLvzBVAg3XeMeW+ZC0vnckgiJ+ov cD04UTqYMGFgQYj0hUQ1XYk6x7D2xTLv3gFrD6cDQrx5tJbZe/t+F+GTGI4nE4EMwdma hv0D4gnbC+oKgrdUGLDprmAZvkjM6S8Ggm+I5Gf8vDppIDflBGMhnNQ3EOMbgj+gf5Hr SzbvP0WvHmvyHaEJ+Ma5Y7kfguGDqrhcyXFwvK/QXPuyRLIJ/Z+6KHaEaDjEVFidQgDb Ojzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=iZxl2a9uFFVZIP5RFW0oBHa1mDruZPdHcvImCztX6xY=; b=jYyeL1JFBvpaQ0uDVO9FsYZ4+DVumedsO4l6xhPBV+kvNg5NveitPZQuXfQFf2MlcZ MqsKV/qQ3h/K3bZEPayJIPeHHy7uNgKlO71rUa7CwR+AFkQVGzm6ij1LMERsYmGBFRko jj/mgfnwB8emu9RvrlOqVPqZs79wshsqLPRGCQrq6E6hjQsTRkjl2QvigP8ZAJMVB68p jaHmu78pww5RGQucvSim7Bjasz4gc7Li0Uob4EH39Xnb1s79qu7TL4J4gyuuk+8l+3hw 6/dPxjn3QBF9QmuqchJvvBMg71jNPkxkRYEPYSaxbAP1ufmsNCCK07Gy2bcdGDJ6tkuY b9zg== X-Gm-Message-State: AA6/9RkD3QTn+KPoPaUck6VQnOOdv1M7q9zeCC0FshWOtlDql9EzUbAUPILke2dEtI1pHOW1 X-Received: by 10.194.168.129 with SMTP id zw1mr2395704wjb.26.1476457690039; Fri, 14 Oct 2016 08:08:10 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c17sm256917wmc.0.2016.10.14.08.08.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2016 08:08:09 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>, dev@dpdk.org Date: Fri, 14 Oct 2016 17:08:08 +0200 Message-ID: <1551628.WMOZ8qHgAT@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com> References: <1470432064-59047-1-git-send-email-jasvinder.singh@intel.com> <8534270.5teDzHbgep@xps13> <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 14 Oct 2016 15:08:10 -0000 2016-10-12 20:44, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > This patchset was probably not tested as it does not compile. > > And it could be useless if a TAP PMD is integrated. > > I suggest to wait 17.02 cycle and see. > > This patch was tested by me and Jasvinder as well and it works brilliantly. > > We did not enable stats when testing, will sort out the missing semicolon issue in the stats macros and resend v3 asap. This is a trivial issue, no need to wait for 17.02. So the stats were not tested. > This is not conflicting with TAP PMD, and as said the scope of this supersedes the TAP PMD. The v3 has been applied and it breaks FreeBSD compilation now. I felt it was not ready but you won with the words "it works brilliantly" ;) (sorry I have not resisted to make the joke)