* [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP checksum request
@ 2015-10-29 8:47 David Marchand
2015-11-02 7:26 ` Lu, Wenzhuo
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2015-10-29 8:47 UTC (permalink / raw)
To: dev
From: Didier Pallard <didier.pallard@6wind.com>
According to Table 7-38: Valid Fields by Offload Option
of Intel ® 82599 10 GbE Controller Datasheet,
L4LEN field is not needed for L4 XSUM computation by the hardware.
So remove l4_len from tx_offload_mask in ixgbe_set_xmit_ctx
function used to build the context transmitted to the hardware.
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index a598a72..26bc2a1 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -415,7 +415,6 @@ ixgbe_set_xmit_ctx(struct ixgbe_tx_queue *txq,
mss_l4len_idx |= sizeof(struct tcp_hdr) << IXGBE_ADVTXD_L4LEN_SHIFT;
tx_offload_mask.l2_len |= ~0;
tx_offload_mask.l3_len |= ~0;
- tx_offload_mask.l4_len |= ~0;
break;
case PKT_TX_SCTP_CKSUM:
type_tucmd_mlhl |= IXGBE_ADVTXD_TUCMD_L4T_SCTP |
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP checksum request
2015-10-29 8:47 [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP checksum request David Marchand
@ 2015-11-02 7:26 ` Lu, Wenzhuo
2015-11-03 10:37 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2015-11-02 7:26 UTC (permalink / raw)
To: David Marchand, dev
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Thursday, October 29, 2015 4:48 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP
> checksum request
>
> From: Didier Pallard <didier.pallard@6wind.com>
>
> According to Table 7-38: Valid Fields by Offload Option of Intel ® 82599 10
> GbE Controller Datasheet, L4LEN field is not needed for L4 XSUM
> computation by the hardware.
> So remove l4_len from tx_offload_mask in ixgbe_set_xmit_ctx function used
> to build the context transmitted to the hardware.
>
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP checksum request
2015-11-02 7:26 ` Lu, Wenzhuo
@ 2015-11-03 10:37 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-03 10:37 UTC (permalink / raw)
To: David Marchand, Didier Pallard; +Cc: dev
> > From: Didier Pallard <didier.pallard@6wind.com>
> >
> > According to Table 7-38: Valid Fields by Offload Option of Intel ® 82599 10
> > GbE Controller Datasheet, L4LEN field is not needed for L4 XSUM
> > computation by the hardware.
> > So remove l4_len from tx_offload_mask in ixgbe_set_xmit_ctx function used
> > to build the context transmitted to the hardware.
> >
> > Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-03 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-29 8:47 [dpdk-dev] [PATCH] ixgbe: remove useless fields in tx_offload on TCP checksum request David Marchand
2015-11-02 7:26 ` Lu, Wenzhuo
2015-11-03 10:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).