* [dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice
@ 2018-01-11 14:47 Kirill Rybalchenko
2018-01-12 10:19 ` Kovacevic, Marko
2018-01-12 10:27 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
0 siblings, 2 replies; 9+ messages in thread
From: Kirill Rybalchenko @ 2018-01-11 14:47 UTC (permalink / raw)
To: dev; +Cc: kirill.rybalchenko, andrey.chilikin, nhorman, thomas
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 13e8543..f0589ea 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,12 @@ Deprecation Notices
Target release for removal of the legacy API will be defined once most
PMDs have switched to rte_flow.
+* ethdev: anounce ABI change
+ The size of variables flow_types_mask in rte_eth_fdir_info structure,
+ sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
+ will be increased from 32 to 64 bits to fulfill hardware requirements.
+ This change will break existing ABI as size of the structures will increase.
+
* i40e: The default flexible payload configuration which extracts the first 16
bytes of the payload for RSS will be deprecated starting from 18.02. If
required the previous behavior can be configured using existing flow
--
2.5.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice
2018-01-11 14:47 [dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice Kirill Rybalchenko
@ 2018-01-12 10:19 ` Kovacevic, Marko
2018-01-12 10:27 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
1 sibling, 0 replies; 9+ messages in thread
From: Kovacevic, Marko @ 2018-01-12 10:19 UTC (permalink / raw)
To: Rybalchenko, Kirill, dev; +Cc: Chilikin, Andrey, nhorman, thomas
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> +* ethdev: anounce ABI change
^^^^^^^^
One small typo announce
> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf
> structure
> + will be increased from 32 to 64 bits to fulfill hardware requirements.
> + This change will break existing ABI as size of the structures will increase.
> +
> * i40e: The default flexible payload configuration which extracts the first 16
> bytes of the payload for RSS will be deprecated starting from 18.02. If
> required the previous behavior can be configured using existing flow
You can add my ack when changed.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v2] doc: ethdev ABI change deprecation notice
2018-01-11 14:47 [dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice Kirill Rybalchenko
2018-01-12 10:19 ` Kovacevic, Marko
@ 2018-01-12 10:27 ` Kirill Rybalchenko
2018-01-12 10:29 ` [dpdk-dev] [PATCH v3] " Kirill Rybalchenko
1 sibling, 1 reply; 9+ messages in thread
From: Kirill Rybalchenko @ 2018-01-12 10:27 UTC (permalink / raw)
To: dev; +Cc: kirill.rybalchenko, andrey.chilikin, nhorman, thomas
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 13e8543..f0589ea 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,12 @@ Deprecation Notices
Target release for removal of the legacy API will be defined once most
PMDs have switched to rte_flow.
+* ethdev: anounce ABI change
+ The size of variables flow_types_mask in rte_eth_fdir_info structure,
+ sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
+ will be increased from 32 to 64 bits to fulfill hardware requirements.
+ This change will break existing ABI as size of the structures will increase.
+
* i40e: The default flexible payload configuration which extracts the first 16
bytes of the payload for RSS will be deprecated starting from 18.02. If
required the previous behavior can be configured using existing flow
--
2.5.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-01-12 10:27 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
@ 2018-01-12 10:29 ` Kirill Rybalchenko
2018-01-12 14:38 ` Neil Horman
0 siblings, 1 reply; 9+ messages in thread
From: Kirill Rybalchenko @ 2018-01-12 10:29 UTC (permalink / raw)
To: dev; +Cc: kirill.rybalchenko, andrey.chilikin, nhorman, thomas
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 13e8543..aaf306a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,12 @@ Deprecation Notices
Target release for removal of the legacy API will be defined once most
PMDs have switched to rte_flow.
+* ethdev: announce ABI change
+ The size of variables flow_types_mask in rte_eth_fdir_info structure,
+ sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
+ will be increased from 32 to 64 bits to fulfill hardware requirements.
+ This change will break existing ABI as size of the structures will increase.
+
* i40e: The default flexible payload configuration which extracts the first 16
bytes of the payload for RSS will be deprecated starting from 18.02. If
required the previous behavior can be configured using existing flow
--
2.5.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-01-12 10:29 ` [dpdk-dev] [PATCH v3] " Kirill Rybalchenko
@ 2018-01-12 14:38 ` Neil Horman
2018-02-13 12:09 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Neil Horman @ 2018-01-12 14:38 UTC (permalink / raw)
To: Kirill Rybalchenko; +Cc: dev, andrey.chilikin, thomas
On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 13e8543..aaf306a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -45,6 +45,12 @@ Deprecation Notices
> Target release for removal of the legacy API will be defined once most
> PMDs have switched to rte_flow.
>
> +* ethdev: announce ABI change
> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> + will be increased from 32 to 64 bits to fulfill hardware requirements.
> + This change will break existing ABI as size of the structures will increase.
> +
> * i40e: The default flexible payload configuration which extracts the first 16
> bytes of the payload for RSS will be deprecated starting from 18.02. If
> required the previous behavior can be configured using existing flow
> --
> 2.5.5
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-01-12 14:38 ` Neil Horman
@ 2018-02-13 12:09 ` Ferruh Yigit
2018-02-13 13:21 ` Olivier Matz
0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2018-02-13 12:09 UTC (permalink / raw)
To: Neil Horman, Kirill Rybalchenko; +Cc: dev, andrey.chilikin, thomas
On 1/12/2018 2:38 PM, Neil Horman wrote:
> On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
>> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>>
>> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 13e8543..aaf306a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -45,6 +45,12 @@ Deprecation Notices
>> Target release for removal of the legacy API will be defined once most
>> PMDs have switched to rte_flow.
>>
>> +* ethdev: announce ABI change
>> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
>> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
>> + will be increased from 32 to 64 bits to fulfill hardware requirements.
>> + This change will break existing ABI as size of the structures will increase.
>> +
>> * i40e: The default flexible payload configuration which extracts the first 16
>> bytes of the payload for RSS will be deprecated starting from 18.02. If
>> required the previous behavior can be configured using existing flow
>> --
>> 2.5.5
>>
>>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-02-13 12:09 ` Ferruh Yigit
@ 2018-02-13 13:21 ` Olivier Matz
2018-02-14 0:14 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Olivier Matz @ 2018-02-13 13:21 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Neil Horman, Kirill Rybalchenko, dev, andrey.chilikin, thomas
On Tue, Feb 13, 2018 at 12:09:19PM +0000, Ferruh Yigit wrote:
> On 1/12/2018 2:38 PM, Neil Horman wrote:
> > On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
> >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> >>
> >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> >> ---
> >> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> >> index 13e8543..aaf306a 100644
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> @@ -45,6 +45,12 @@ Deprecation Notices
> >> Target release for removal of the legacy API will be defined once most
> >> PMDs have switched to rte_flow.
> >>
> >> +* ethdev: announce ABI change
> >> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
> >> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> >> + will be increased from 32 to 64 bits to fulfill hardware requirements.
> >> + This change will break existing ABI as size of the structures will increase.
> >> +
> >> * i40e: The default flexible payload configuration which extracts the first 16
> >> bytes of the payload for RSS will be deprecated starting from 18.02. If
> >> required the previous behavior can be configured using existing flow
> >> --
> >> 2.5.5
> >>
> >>
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-02-13 13:21 ` Olivier Matz
@ 2018-02-14 0:14 ` Thomas Monjalon
2018-02-14 17:18 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2018-02-14 0:14 UTC (permalink / raw)
To: Kirill Rybalchenko
Cc: dev, Olivier Matz, Ferruh Yigit, Neil Horman, andrey.chilikin,
adrien.mazarguil
> > >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > >>
> > >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > >> ---
> > >> +* ethdev: announce ABI change
> > >> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
> > >> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> > >> + will be increased from 32 to 64 bits to fulfill hardware requirements.
> > >> + This change will break existing ABI as size of the structures will increase.
> > >> +
> > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
I would prefer you drop the legacy code to keep only rte_flow.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice
2018-02-14 0:14 ` Thomas Monjalon
@ 2018-02-14 17:18 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2018-02-14 17:18 UTC (permalink / raw)
To: Kirill Rybalchenko
Cc: dev, Olivier Matz, Ferruh Yigit, Neil Horman, andrey.chilikin,
adrien.mazarguil
14/02/2018 01:14, Thomas Monjalon:
> > > >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > > >>
> > > >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > > >> ---
> > > >> +* ethdev: announce ABI change
> > > >> + The size of variables flow_types_mask in rte_eth_fdir_info structure,
> > > >> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> > > >> + will be increased from 32 to 64 bits to fulfill hardware requirements.
> > > >> + This change will break existing ABI as size of the structures will increase.
> > > >> +
> > > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> > >
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> I would prefer you drop the legacy code to keep only rte_flow.
Applied
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-02-14 17:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 14:47 [dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice Kirill Rybalchenko
2018-01-12 10:19 ` Kovacevic, Marko
2018-01-12 10:27 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
2018-01-12 10:29 ` [dpdk-dev] [PATCH v3] " Kirill Rybalchenko
2018-01-12 14:38 ` Neil Horman
2018-02-13 12:09 ` Ferruh Yigit
2018-02-13 13:21 ` Olivier Matz
2018-02-14 0:14 ` Thomas Monjalon
2018-02-14 17:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).