From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 4CF052BFA;
Tue, 26 Mar 2019 04:08:29 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Mar 2019 20:08:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="330670487"
Received: from dpdk6.bj.intel.com ([172.16.182.192])
by fmsmga006.fm.intel.com with ESMTP; 25 Mar 2019 20:08:26 -0700
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org,
qi.z.zhang@intel.com,
Wei Zhao <wei.zhao1@intel.com>
Date: Tue, 26 Mar 2019 10:40:50 +0800
Message-Id: <1553568050-13343-1-git-send-email-wei.zhao1@intel.com>
X-Mailer: git-send-email 2.7.5
In-Reply-To: <1553236034-45852-1-git-send-email-wei.zhao1@intel.com>
References: <1553236034-45852-1-git-send-email-wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v3] net/iavf: fix Tx interrupt vertor
configuration error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Mar 2019 03:08:29 -0000
There is need to align to kernel iavf code when setting Tx
queue interrupt vector in messge VIRTCHNL_OP_CONFIG_IRQ_MAP,
if not it maybe cause restart iavf port error in some scenario.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
update git log and add new work around
v3:
update git comment and change fix code as suggestion
---
drivers/net/iavf/iavf_vchnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 6381fb6..3f8c115 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -614,8 +614,8 @@ iavf_config_irq_map(struct iavf_adapter *adapter)
vecmap->vsi_id = vf->vsi_res->vsi_id;
vecmap->rxitr_idx = IAVF_ITR_INDEX_DEFAULT;
vecmap->vector_id = vf->msix_base + i;
- vecmap->txq_map = 0;
vecmap->rxq_map = vf->rxq_map[vf->msix_base + i];
+ vecmap->txq_map = vecmap->rxq_map;
}
args.ops = VIRTCHNL_OP_CONFIG_IRQ_MAP;
--
2.7.5
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 9E8DFA05D3
for <public@inbox.dpdk.org>; Tue, 26 Mar 2019 04:08:31 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B6B202C19;
Tue, 26 Mar 2019 04:08:30 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 4CF052BFA;
Tue, 26 Mar 2019 04:08:29 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Mar 2019 20:08:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="330670487"
Received: from dpdk6.bj.intel.com ([172.16.182.192])
by fmsmga006.fm.intel.com with ESMTP; 25 Mar 2019 20:08:26 -0700
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org,
qi.z.zhang@intel.com,
Wei Zhao <wei.zhao1@intel.com>
Date: Tue, 26 Mar 2019 10:40:50 +0800
Message-Id: <1553568050-13343-1-git-send-email-wei.zhao1@intel.com>
X-Mailer: git-send-email 2.7.5
In-Reply-To: <1553236034-45852-1-git-send-email-wei.zhao1@intel.com>
References: <1553236034-45852-1-git-send-email-wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v3] net/iavf: fix Tx interrupt vertor
configuration error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190326024050.U49ELdkKxyK1_V6L96pjK2LfS6zfzXKhpH5FV6fHpys@z>
There is need to align to kernel iavf code when setting Tx
queue interrupt vector in messge VIRTCHNL_OP_CONFIG_IRQ_MAP,
if not it maybe cause restart iavf port error in some scenario.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
update git log and add new work around
v3:
update git comment and change fix code as suggestion
---
drivers/net/iavf/iavf_vchnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 6381fb6..3f8c115 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -614,8 +614,8 @@ iavf_config_irq_map(struct iavf_adapter *adapter)
vecmap->vsi_id = vf->vsi_res->vsi_id;
vecmap->rxitr_idx = IAVF_ITR_INDEX_DEFAULT;
vecmap->vector_id = vf->msix_base + i;
- vecmap->txq_map = 0;
vecmap->rxq_map = vf->rxq_map[vf->msix_base + i];
+ vecmap->txq_map = vecmap->rxq_map;
}
args.ops = VIRTCHNL_OP_CONFIG_IRQ_MAP;
--
2.7.5