* [dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments
@ 2019-04-02 7:40 Viacheslav Ovsiienko
2019-04-02 7:40 ` Viacheslav Ovsiienko
2019-04-05 8:55 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
0 siblings, 2 replies; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-02 7:40 UTC (permalink / raw)
To: dev; +Cc: shahafs
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 14 +++++++-------
drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 96ad4c6..7d322b6 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -149,7 +149,7 @@ struct mlx5_dev_spawn_data {
* port dedicated IB device, the context will be used by only given
* port due to unification.
*
- * Routine first searches the context for the spesified IB device name,
+ * Routine first searches the context for the specified IB device name,
* if found the shared context assumed and reference counter is incremented.
* If no context found the new one is created and initialized with specified
* IB device context and parameters.
@@ -179,7 +179,7 @@ struct mlx5_dev_spawn_data {
goto exit;
}
}
- /* No device found, we have to create new sharted context. */
+ /* No device found, we have to create new shared context. */
assert(spawn->max_port);
sh = rte_zmalloc("ethdev shared ib context",
sizeof(struct mlx5_ibv_shared) +
@@ -300,7 +300,7 @@ struct mlx5_dev_spawn_data {
/**
* Initialize DV/DR related data within private structure.
* Routine checks the reference counter and does actual
- * resources creation/iniialization only if counter is zero.
+ * resources creation/initialization only if counter is zero.
*
* @param[in] priv
* Pointer to the private device data structure.
@@ -1228,7 +1228,7 @@ struct mlx5_dev_spawn_data {
* Currently we support single E-Switch per PF configurations
* only and vport_id field contains the vport index for
* associated VF, which is deduced from representor port name.
- * For exapmple, let's have the IB device port 10, it has
+ * For example, let's have the IB device port 10, it has
* attached network device eth0, which has port name attribute
* pf0vf2, we can deduce the VF number as 2, and set vport index
* as 3 (2+1). This assigning schema should be changed if the
@@ -1483,7 +1483,7 @@ struct mlx5_dev_spawn_data {
mlx5_set_link_up(eth_dev);
/*
* Even though the interrupt handler is not installed yet,
- * interrupts will still trigger on the asyn_fd from
+ * interrupts will still trigger on the async_fd from
* Verbs context returned by ibv_open_device().
*/
mlx5_link_update(eth_dev, 0);
@@ -1656,7 +1656,7 @@ struct mlx5_dev_spawn_data {
}
ibv_match[nd] = NULL;
if (!nd) {
- /* No device macthes, just complain and bail out. */
+ /* No device matches, just complain and bail out. */
mlx5_glue->free_device_list(ibv_list);
DRV_LOG(WARNING,
"no Verbs device matches PCI device " PCI_PRI_FMT ","
@@ -1689,7 +1689,7 @@ struct mlx5_dev_spawn_data {
if (np > 1) {
/*
- * Signle IB device with multiple ports found,
+ * Single IB device with multiple ports found,
* it may be E-Switch master device and representors.
* We have to perform identification trough the ports.
*/
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index 3006f83..fc04c9d 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -2916,7 +2916,7 @@ struct pedit_parser {
* VXLAN VNI in 24-bit wire format.
*
* @return
- * VXLAN VNI as a 32-bit integer value in network endian.
+ * VXLAN VNI as a 32-bit integer value in network endianness.
*/
static inline rte_be32_t
vxlan_vni_as_be32(const uint8_t vni[3])
@@ -4051,7 +4051,7 @@ struct pedit_parser {
nlh->nlmsg_flags |= NLM_F_ACK;
ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
if (ret <= 0) {
- /* Message send error occurres. */
+ /* Message send error occurred. */
rte_errno = errno;
return -rte_errno;
}
@@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4343,7 +4343,7 @@ struct tcf_nlcb_context {
}
/**
- * Collect neigh permament rules on specified network device.
+ * Collect neigh permanent rules on specified network device.
* This is callback routine called by libmnl mnl_cb_run() in loop for
* every message in received packet.
*
@@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
}
if (!na_mac || !na_ip)
return 1;
- /* Neigh rule with permenent attribute found. */
+ /* Neigh rule with permanent attribute found. */
size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
MNL_ALIGN(sizeof(struct ndmsg)) +
SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
@@ -4431,7 +4431,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4599,7 +4599,7 @@ struct tcf_nlcb_context {
* Note that an implicit route is maintained by the kernel due to the
* presence of a peer address (IFA_ADDRESS).
*
- * These rules are used for encapsultion only and allow to assign
+ * These rules are used for encapsulation only and allow to assign
* the outer tunnel source IP address.
*
* @param[in] tcf
@@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
/**
* Releases VXLAN encap rules container by pointer. Decrements the
- * reference cointer and deletes the container if counter is zero.
+ * reference counter and deletes the container if counter is zero.
*
* @param[in] irule
* VXLAN rule container pointer to release.
@@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] vtep
- * Object represinting the network device to delete. Memory
+ * Object representing the network device to delete. Memory
* allocated for this object is freed by routine.
*/
static void
@@ -5268,7 +5268,7 @@ struct tcf_nlcb_context {
}
/**
- * Aqcuire target interface index for VXLAN tunneling encapsulation.
+ * Acquire target interface index for VXLAN tunneling encapsulation.
*
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
@@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
/**
* Fetch the applied rule handle. This is callback routine called by
* libmnl mnl_cb_run() in loop for every message in received packet.
- * When the NLM_F_ECHO flag i sspecified the kernel sends the created
+ * When the NLM_F_ECHO flag is specified the kernel sends the created
* rule descriptor back to the application and we can retrieve the
* actual rule handle from updated descriptor.
*
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments
2019-04-02 7:40 [dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments Viacheslav Ovsiienko
@ 2019-04-02 7:40 ` Viacheslav Ovsiienko
2019-04-05 8:55 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
1 sibling, 0 replies; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-02 7:40 UTC (permalink / raw)
To: dev; +Cc: shahafs
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 14 +++++++-------
drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 96ad4c6..7d322b6 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -149,7 +149,7 @@ struct mlx5_dev_spawn_data {
* port dedicated IB device, the context will be used by only given
* port due to unification.
*
- * Routine first searches the context for the spesified IB device name,
+ * Routine first searches the context for the specified IB device name,
* if found the shared context assumed and reference counter is incremented.
* If no context found the new one is created and initialized with specified
* IB device context and parameters.
@@ -179,7 +179,7 @@ struct mlx5_dev_spawn_data {
goto exit;
}
}
- /* No device found, we have to create new sharted context. */
+ /* No device found, we have to create new shared context. */
assert(spawn->max_port);
sh = rte_zmalloc("ethdev shared ib context",
sizeof(struct mlx5_ibv_shared) +
@@ -300,7 +300,7 @@ struct mlx5_dev_spawn_data {
/**
* Initialize DV/DR related data within private structure.
* Routine checks the reference counter and does actual
- * resources creation/iniialization only if counter is zero.
+ * resources creation/initialization only if counter is zero.
*
* @param[in] priv
* Pointer to the private device data structure.
@@ -1228,7 +1228,7 @@ struct mlx5_dev_spawn_data {
* Currently we support single E-Switch per PF configurations
* only and vport_id field contains the vport index for
* associated VF, which is deduced from representor port name.
- * For exapmple, let's have the IB device port 10, it has
+ * For example, let's have the IB device port 10, it has
* attached network device eth0, which has port name attribute
* pf0vf2, we can deduce the VF number as 2, and set vport index
* as 3 (2+1). This assigning schema should be changed if the
@@ -1483,7 +1483,7 @@ struct mlx5_dev_spawn_data {
mlx5_set_link_up(eth_dev);
/*
* Even though the interrupt handler is not installed yet,
- * interrupts will still trigger on the asyn_fd from
+ * interrupts will still trigger on the async_fd from
* Verbs context returned by ibv_open_device().
*/
mlx5_link_update(eth_dev, 0);
@@ -1656,7 +1656,7 @@ struct mlx5_dev_spawn_data {
}
ibv_match[nd] = NULL;
if (!nd) {
- /* No device macthes, just complain and bail out. */
+ /* No device matches, just complain and bail out. */
mlx5_glue->free_device_list(ibv_list);
DRV_LOG(WARNING,
"no Verbs device matches PCI device " PCI_PRI_FMT ","
@@ -1689,7 +1689,7 @@ struct mlx5_dev_spawn_data {
if (np > 1) {
/*
- * Signle IB device with multiple ports found,
+ * Single IB device with multiple ports found,
* it may be E-Switch master device and representors.
* We have to perform identification trough the ports.
*/
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index 3006f83..fc04c9d 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -2916,7 +2916,7 @@ struct pedit_parser {
* VXLAN VNI in 24-bit wire format.
*
* @return
- * VXLAN VNI as a 32-bit integer value in network endian.
+ * VXLAN VNI as a 32-bit integer value in network endianness.
*/
static inline rte_be32_t
vxlan_vni_as_be32(const uint8_t vni[3])
@@ -4051,7 +4051,7 @@ struct pedit_parser {
nlh->nlmsg_flags |= NLM_F_ACK;
ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
if (ret <= 0) {
- /* Message send error occurres. */
+ /* Message send error occurred. */
rte_errno = errno;
return -rte_errno;
}
@@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4343,7 +4343,7 @@ struct tcf_nlcb_context {
}
/**
- * Collect neigh permament rules on specified network device.
+ * Collect neigh permanent rules on specified network device.
* This is callback routine called by libmnl mnl_cb_run() in loop for
* every message in received packet.
*
@@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
}
if (!na_mac || !na_ip)
return 1;
- /* Neigh rule with permenent attribute found. */
+ /* Neigh rule with permanent attribute found. */
size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
MNL_ALIGN(sizeof(struct ndmsg)) +
SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
@@ -4431,7 +4431,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4599,7 +4599,7 @@ struct tcf_nlcb_context {
* Note that an implicit route is maintained by the kernel due to the
* presence of a peer address (IFA_ADDRESS).
*
- * These rules are used for encapsultion only and allow to assign
+ * These rules are used for encapsulation only and allow to assign
* the outer tunnel source IP address.
*
* @param[in] tcf
@@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
/**
* Releases VXLAN encap rules container by pointer. Decrements the
- * reference cointer and deletes the container if counter is zero.
+ * reference counter and deletes the container if counter is zero.
*
* @param[in] irule
* VXLAN rule container pointer to release.
@@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] vtep
- * Object represinting the network device to delete. Memory
+ * Object representing the network device to delete. Memory
* allocated for this object is freed by routine.
*/
static void
@@ -5268,7 +5268,7 @@ struct tcf_nlcb_context {
}
/**
- * Aqcuire target interface index for VXLAN tunneling encapsulation.
+ * Acquire target interface index for VXLAN tunneling encapsulation.
*
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
@@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
/**
* Fetch the applied rule handle. This is callback routine called by
* libmnl mnl_cb_run() in loop for every message in received packet.
- * When the NLM_F_ECHO flag i sspecified the kernel sends the created
+ * When the NLM_F_ECHO flag is specified the kernel sends the created
* rule descriptor back to the application and we can retrieve the
* actual rule handle from updated descriptor.
*
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments
2019-04-02 7:40 [dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments Viacheslav Ovsiienko
2019-04-02 7:40 ` Viacheslav Ovsiienko
@ 2019-04-05 8:55 ` Viacheslav Ovsiienko
2019-04-05 8:55 ` Viacheslav Ovsiienko
2019-04-08 6:00 ` Shahaf Shuler
1 sibling, 2 replies; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-05 8:55 UTC (permalink / raw)
To: dev; +Cc: shahafs
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
v2:
rebasing only
v1:
http://patches.dpdk.org/patch/52056/
---
drivers/net/mlx5/mlx5.c | 14 +++++++-------
drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index f571ba2..09f4a21 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -155,7 +155,7 @@ struct mlx5_dev_spawn_data {
* port dedicated IB device, the context will be used by only given
* port due to unification.
*
- * Routine first searches the context for the spesified IB device name,
+ * Routine first searches the context for the specified IB device name,
* if found the shared context assumed and reference counter is incremented.
* If no context found the new one is created and initialized with specified
* IB device context and parameters.
@@ -185,7 +185,7 @@ struct mlx5_dev_spawn_data {
goto exit;
}
}
- /* No device found, we have to create new sharted context. */
+ /* No device found, we have to create new shared context. */
assert(spawn->max_port);
sh = rte_zmalloc("ethdev shared ib context",
sizeof(struct mlx5_ibv_shared) +
@@ -305,7 +305,7 @@ struct mlx5_dev_spawn_data {
/**
* Initialize DR related data within private structure.
* Routine checks the reference counter and does actual
- * resources creation/iniialization only if counter is zero.
+ * resources creation/initialization only if counter is zero.
*
* @param[in] priv
* Pointer to the private device data structure.
@@ -1353,7 +1353,7 @@ struct mlx5_dev_spawn_data {
* Currently we support single E-Switch per PF configurations
* only and vport_id field contains the vport index for
* associated VF, which is deduced from representor port name.
- * For exapmple, let's have the IB device port 10, it has
+ * For example, let's have the IB device port 10, it has
* attached network device eth0, which has port name attribute
* pf0vf2, we can deduce the VF number as 2, and set vport index
* as 3 (2+1). This assigning schema should be changed if the
@@ -1595,7 +1595,7 @@ struct mlx5_dev_spawn_data {
mlx5_set_link_up(eth_dev);
/*
* Even though the interrupt handler is not installed yet,
- * interrupts will still trigger on the asyn_fd from
+ * interrupts will still trigger on the async_fd from
* Verbs context returned by ibv_open_device().
*/
mlx5_link_update(eth_dev, 0);
@@ -1772,7 +1772,7 @@ struct mlx5_dev_spawn_data {
}
ibv_match[nd] = NULL;
if (!nd) {
- /* No device macthes, just complain and bail out. */
+ /* No device matches, just complain and bail out. */
mlx5_glue->free_device_list(ibv_list);
DRV_LOG(WARNING,
"no Verbs device matches PCI device " PCI_PRI_FMT ","
@@ -1805,7 +1805,7 @@ struct mlx5_dev_spawn_data {
if (np > 1) {
/*
- * Signle IB device with multiple ports found,
+ * Single IB device with multiple ports found,
* it may be E-Switch master device and representors.
* We have to perform identification trough the ports.
*/
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index 3006f83..fc04c9d 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -2916,7 +2916,7 @@ struct pedit_parser {
* VXLAN VNI in 24-bit wire format.
*
* @return
- * VXLAN VNI as a 32-bit integer value in network endian.
+ * VXLAN VNI as a 32-bit integer value in network endianness.
*/
static inline rte_be32_t
vxlan_vni_as_be32(const uint8_t vni[3])
@@ -4051,7 +4051,7 @@ struct pedit_parser {
nlh->nlmsg_flags |= NLM_F_ACK;
ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
if (ret <= 0) {
- /* Message send error occurres. */
+ /* Message send error occurred. */
rte_errno = errno;
return -rte_errno;
}
@@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4343,7 +4343,7 @@ struct tcf_nlcb_context {
}
/**
- * Collect neigh permament rules on specified network device.
+ * Collect neigh permanent rules on specified network device.
* This is callback routine called by libmnl mnl_cb_run() in loop for
* every message in received packet.
*
@@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
}
if (!na_mac || !na_ip)
return 1;
- /* Neigh rule with permenent attribute found. */
+ /* Neigh rule with permanent attribute found. */
size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
MNL_ALIGN(sizeof(struct ndmsg)) +
SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
@@ -4431,7 +4431,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4599,7 +4599,7 @@ struct tcf_nlcb_context {
* Note that an implicit route is maintained by the kernel due to the
* presence of a peer address (IFA_ADDRESS).
*
- * These rules are used for encapsultion only and allow to assign
+ * These rules are used for encapsulation only and allow to assign
* the outer tunnel source IP address.
*
* @param[in] tcf
@@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
/**
* Releases VXLAN encap rules container by pointer. Decrements the
- * reference cointer and deletes the container if counter is zero.
+ * reference counter and deletes the container if counter is zero.
*
* @param[in] irule
* VXLAN rule container pointer to release.
@@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] vtep
- * Object represinting the network device to delete. Memory
+ * Object representing the network device to delete. Memory
* allocated for this object is freed by routine.
*/
static void
@@ -5268,7 +5268,7 @@ struct tcf_nlcb_context {
}
/**
- * Aqcuire target interface index for VXLAN tunneling encapsulation.
+ * Acquire target interface index for VXLAN tunneling encapsulation.
*
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
@@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
/**
* Fetch the applied rule handle. This is callback routine called by
* libmnl mnl_cb_run() in loop for every message in received packet.
- * When the NLM_F_ECHO flag i sspecified the kernel sends the created
+ * When the NLM_F_ECHO flag is specified the kernel sends the created
* rule descriptor back to the application and we can retrieve the
* actual rule handle from updated descriptor.
*
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments
2019-04-05 8:55 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
@ 2019-04-05 8:55 ` Viacheslav Ovsiienko
2019-04-08 6:00 ` Shahaf Shuler
1 sibling, 0 replies; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-05 8:55 UTC (permalink / raw)
To: dev; +Cc: shahafs
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
v2:
rebasing only
v1:
http://patches.dpdk.org/patch/52056/
---
drivers/net/mlx5/mlx5.c | 14 +++++++-------
drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index f571ba2..09f4a21 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -155,7 +155,7 @@ struct mlx5_dev_spawn_data {
* port dedicated IB device, the context will be used by only given
* port due to unification.
*
- * Routine first searches the context for the spesified IB device name,
+ * Routine first searches the context for the specified IB device name,
* if found the shared context assumed and reference counter is incremented.
* If no context found the new one is created and initialized with specified
* IB device context and parameters.
@@ -185,7 +185,7 @@ struct mlx5_dev_spawn_data {
goto exit;
}
}
- /* No device found, we have to create new sharted context. */
+ /* No device found, we have to create new shared context. */
assert(spawn->max_port);
sh = rte_zmalloc("ethdev shared ib context",
sizeof(struct mlx5_ibv_shared) +
@@ -305,7 +305,7 @@ struct mlx5_dev_spawn_data {
/**
* Initialize DR related data within private structure.
* Routine checks the reference counter and does actual
- * resources creation/iniialization only if counter is zero.
+ * resources creation/initialization only if counter is zero.
*
* @param[in] priv
* Pointer to the private device data structure.
@@ -1353,7 +1353,7 @@ struct mlx5_dev_spawn_data {
* Currently we support single E-Switch per PF configurations
* only and vport_id field contains the vport index for
* associated VF, which is deduced from representor port name.
- * For exapmple, let's have the IB device port 10, it has
+ * For example, let's have the IB device port 10, it has
* attached network device eth0, which has port name attribute
* pf0vf2, we can deduce the VF number as 2, and set vport index
* as 3 (2+1). This assigning schema should be changed if the
@@ -1595,7 +1595,7 @@ struct mlx5_dev_spawn_data {
mlx5_set_link_up(eth_dev);
/*
* Even though the interrupt handler is not installed yet,
- * interrupts will still trigger on the asyn_fd from
+ * interrupts will still trigger on the async_fd from
* Verbs context returned by ibv_open_device().
*/
mlx5_link_update(eth_dev, 0);
@@ -1772,7 +1772,7 @@ struct mlx5_dev_spawn_data {
}
ibv_match[nd] = NULL;
if (!nd) {
- /* No device macthes, just complain and bail out. */
+ /* No device matches, just complain and bail out. */
mlx5_glue->free_device_list(ibv_list);
DRV_LOG(WARNING,
"no Verbs device matches PCI device " PCI_PRI_FMT ","
@@ -1805,7 +1805,7 @@ struct mlx5_dev_spawn_data {
if (np > 1) {
/*
- * Signle IB device with multiple ports found,
+ * Single IB device with multiple ports found,
* it may be E-Switch master device and representors.
* We have to perform identification trough the ports.
*/
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index 3006f83..fc04c9d 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -2916,7 +2916,7 @@ struct pedit_parser {
* VXLAN VNI in 24-bit wire format.
*
* @return
- * VXLAN VNI as a 32-bit integer value in network endian.
+ * VXLAN VNI as a 32-bit integer value in network endianness.
*/
static inline rte_be32_t
vxlan_vni_as_be32(const uint8_t vni[3])
@@ -4051,7 +4051,7 @@ struct pedit_parser {
nlh->nlmsg_flags |= NLM_F_ACK;
ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
if (ret <= 0) {
- /* Message send error occurres. */
+ /* Message send error occurred. */
rte_errno = errno;
return -rte_errno;
}
@@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4343,7 +4343,7 @@ struct tcf_nlcb_context {
}
/**
- * Collect neigh permament rules on specified network device.
+ * Collect neigh permanent rules on specified network device.
* This is callback routine called by libmnl mnl_cb_run() in loop for
* every message in received packet.
*
@@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
}
if (!na_mac || !na_ip)
return 1;
- /* Neigh rule with permenent attribute found. */
+ /* Neigh rule with permanent attribute found. */
size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
MNL_ALIGN(sizeof(struct ndmsg)) +
SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
@@ -4431,7 +4431,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] ifindex
- * Network inferface index to perform cleanup.
+ * Network interface index to perform cleanup.
*/
static void
flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf,
@@ -4599,7 +4599,7 @@ struct tcf_nlcb_context {
* Note that an implicit route is maintained by the kernel due to the
* presence of a peer address (IFA_ADDRESS).
*
- * These rules are used for encapsultion only and allow to assign
+ * These rules are used for encapsulation only and allow to assign
* the outer tunnel source IP address.
*
* @param[in] tcf
@@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
/**
* Releases VXLAN encap rules container by pointer. Decrements the
- * reference cointer and deletes the container if counter is zero.
+ * reference counter and deletes the container if counter is zero.
*
* @param[in] irule
* VXLAN rule container pointer to release.
@@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
* @param[in] vtep
- * Object represinting the network device to delete. Memory
+ * Object representing the network device to delete. Memory
* allocated for this object is freed by routine.
*/
static void
@@ -5268,7 +5268,7 @@ struct tcf_nlcb_context {
}
/**
- * Aqcuire target interface index for VXLAN tunneling encapsulation.
+ * Acquire target interface index for VXLAN tunneling encapsulation.
*
* @param[in] tcf
* Context object initialized by mlx5_flow_tcf_context_create().
@@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
/**
* Fetch the applied rule handle. This is callback routine called by
* libmnl mnl_cb_run() in loop for every message in received packet.
- * When the NLM_F_ECHO flag i sspecified the kernel sends the created
+ * When the NLM_F_ECHO flag is specified the kernel sends the created
* rule descriptor back to the application and we can retrieve the
* actual rule handle from updated descriptor.
*
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments
2019-04-05 8:55 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
2019-04-05 8:55 ` Viacheslav Ovsiienko
@ 2019-04-08 6:00 ` Shahaf Shuler
2019-04-08 6:00 ` Shahaf Shuler
1 sibling, 1 reply; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-08 6:00 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Friday, April 5, 2019 11:56 AM, Viacheslav Ovsiienko:
> Subject: [PATCH v2 1/1] net/mlx5: fix typos in comments
>
> Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>
Applied to next-net-mlx, thanks.
Pay attention the below comments should be after the "---" to not be included on the commit log.
> v2:
> rebasing only
> v1:
> http://patches.dpdk.org/patch/52056/
>
> ---
> drivers/net/mlx5/mlx5.c | 14 +++++++-------
> drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
> 2 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> f571ba2..09f4a21 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -155,7 +155,7 @@ struct mlx5_dev_spawn_data {
> * port dedicated IB device, the context will be used by only given
> * port due to unification.
> *
> - * Routine first searches the context for the spesified IB device name,
> + * Routine first searches the context for the specified IB device name,
> * if found the shared context assumed and reference counter is
> incremented.
> * If no context found the new one is created and initialized with specified
> * IB device context and parameters.
> @@ -185,7 +185,7 @@ struct mlx5_dev_spawn_data {
> goto exit;
> }
> }
> - /* No device found, we have to create new sharted context. */
> + /* No device found, we have to create new shared context. */
> assert(spawn->max_port);
> sh = rte_zmalloc("ethdev shared ib context",
> sizeof(struct mlx5_ibv_shared) +
> @@ -305,7 +305,7 @@ struct mlx5_dev_spawn_data {
> /**
> * Initialize DR related data within private structure.
> * Routine checks the reference counter and does actual
> - * resources creation/iniialization only if counter is zero.
> + * resources creation/initialization only if counter is zero.
> *
> * @param[in] priv
> * Pointer to the private device data structure.
> @@ -1353,7 +1353,7 @@ struct mlx5_dev_spawn_data {
> * Currently we support single E-Switch per PF configurations
> * only and vport_id field contains the vport index for
> * associated VF, which is deduced from representor port name.
> - * For exapmple, let's have the IB device port 10, it has
> + * For example, let's have the IB device port 10, it has
> * attached network device eth0, which has port name attribute
> * pf0vf2, we can deduce the VF number as 2, and set vport index
> * as 3 (2+1). This assigning schema should be changed if the @@ -
> 1595,7 +1595,7 @@ struct mlx5_dev_spawn_data {
> mlx5_set_link_up(eth_dev);
> /*
> * Even though the interrupt handler is not installed yet,
> - * interrupts will still trigger on the asyn_fd from
> + * interrupts will still trigger on the async_fd from
> * Verbs context returned by ibv_open_device().
> */
> mlx5_link_update(eth_dev, 0);
> @@ -1772,7 +1772,7 @@ struct mlx5_dev_spawn_data {
> }
> ibv_match[nd] = NULL;
> if (!nd) {
> - /* No device macthes, just complain and bail out. */
> + /* No device matches, just complain and bail out. */
> mlx5_glue->free_device_list(ibv_list);
> DRV_LOG(WARNING,
> "no Verbs device matches PCI device " PCI_PRI_FMT
> ","
> @@ -1805,7 +1805,7 @@ struct mlx5_dev_spawn_data {
>
> if (np > 1) {
> /*
> - * Signle IB device with multiple ports found,
> + * Single IB device with multiple ports found,
> * it may be E-Switch master device and representors.
> * We have to perform identification trough the ports.
> */
> diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c
> b/drivers/net/mlx5/mlx5_flow_tcf.c
> index 3006f83..fc04c9d 100644
> --- a/drivers/net/mlx5/mlx5_flow_tcf.c
> +++ b/drivers/net/mlx5/mlx5_flow_tcf.c
> @@ -2916,7 +2916,7 @@ struct pedit_parser {
> * VXLAN VNI in 24-bit wire format.
> *
> * @return
> - * VXLAN VNI as a 32-bit integer value in network endian.
> + * VXLAN VNI as a 32-bit integer value in network endianness.
> */
> static inline rte_be32_t
> vxlan_vni_as_be32(const uint8_t vni[3]) @@ -4051,7 +4051,7 @@ struct
> pedit_parser {
> nlh->nlmsg_flags |= NLM_F_ACK;
> ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
> if (ret <= 0) {
> - /* Message send error occurres. */
> + /* Message send error occurred. */
> rte_errno = errno;
> return -rte_errno;
> }
> @@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] ifindex
> - * Network inferface index to perform cleanup.
> + * Network interface index to perform cleanup.
> */
> static void
> flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf, @@ -
> 4343,7 +4343,7 @@ struct tcf_nlcb_context { }
>
> /**
> - * Collect neigh permament rules on specified network device.
> + * Collect neigh permanent rules on specified network device.
> * This is callback routine called by libmnl mnl_cb_run() in loop for
> * every message in received packet.
> *
> @@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
> }
> if (!na_mac || !na_ip)
> return 1;
> - /* Neigh rule with permenent attribute found. */
> + /* Neigh rule with permanent attribute found. */
> size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
> MNL_ALIGN(sizeof(struct ndmsg)) +
> SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) + @@ -4431,7 +4431,7
> @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] ifindex
> - * Network inferface index to perform cleanup.
> + * Network interface index to perform cleanup.
> */
> static void
> flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf, @@ -
> 4599,7 +4599,7 @@ struct tcf_nlcb_context {
> * Note that an implicit route is maintained by the kernel due to the
> * presence of a peer address (IFA_ADDRESS).
> *
> - * These rules are used for encapsultion only and allow to assign
> + * These rules are used for encapsulation only and allow to assign
> * the outer tunnel source IP address.
> *
> * @param[in] tcf
> @@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
>
> /**
> * Releases VXLAN encap rules container by pointer. Decrements the
> - * reference cointer and deletes the container if counter is zero.
> + * reference counter and deletes the container if counter is zero.
> *
> * @param[in] irule
> * VXLAN rule container pointer to release.
> @@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] vtep
> - * Object represinting the network device to delete. Memory
> + * Object representing the network device to delete. Memory
> * allocated for this object is freed by routine.
> */
> static void
> @@ -5268,7 +5268,7 @@ struct tcf_nlcb_context { }
>
> /**
> - * Aqcuire target interface index for VXLAN tunneling encapsulation.
> + * Acquire target interface index for VXLAN tunneling encapsulation.
> *
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> @@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
> /**
> * Fetch the applied rule handle. This is callback routine called by
> * libmnl mnl_cb_run() in loop for every message in received packet.
> - * When the NLM_F_ECHO flag i sspecified the kernel sends the created
> + * When the NLM_F_ECHO flag is specified the kernel sends the created
> * rule descriptor back to the application and we can retrieve the
> * actual rule handle from updated descriptor.
> *
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments
2019-04-08 6:00 ` Shahaf Shuler
@ 2019-04-08 6:00 ` Shahaf Shuler
0 siblings, 0 replies; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-08 6:00 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Friday, April 5, 2019 11:56 AM, Viacheslav Ovsiienko:
> Subject: [PATCH v2 1/1] net/mlx5: fix typos in comments
>
> Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>
Applied to next-net-mlx, thanks.
Pay attention the below comments should be after the "---" to not be included on the commit log.
> v2:
> rebasing only
> v1:
> http://patches.dpdk.org/patch/52056/
>
> ---
> drivers/net/mlx5/mlx5.c | 14 +++++++-------
> drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------
> 2 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> f571ba2..09f4a21 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -155,7 +155,7 @@ struct mlx5_dev_spawn_data {
> * port dedicated IB device, the context will be used by only given
> * port due to unification.
> *
> - * Routine first searches the context for the spesified IB device name,
> + * Routine first searches the context for the specified IB device name,
> * if found the shared context assumed and reference counter is
> incremented.
> * If no context found the new one is created and initialized with specified
> * IB device context and parameters.
> @@ -185,7 +185,7 @@ struct mlx5_dev_spawn_data {
> goto exit;
> }
> }
> - /* No device found, we have to create new sharted context. */
> + /* No device found, we have to create new shared context. */
> assert(spawn->max_port);
> sh = rte_zmalloc("ethdev shared ib context",
> sizeof(struct mlx5_ibv_shared) +
> @@ -305,7 +305,7 @@ struct mlx5_dev_spawn_data {
> /**
> * Initialize DR related data within private structure.
> * Routine checks the reference counter and does actual
> - * resources creation/iniialization only if counter is zero.
> + * resources creation/initialization only if counter is zero.
> *
> * @param[in] priv
> * Pointer to the private device data structure.
> @@ -1353,7 +1353,7 @@ struct mlx5_dev_spawn_data {
> * Currently we support single E-Switch per PF configurations
> * only and vport_id field contains the vport index for
> * associated VF, which is deduced from representor port name.
> - * For exapmple, let's have the IB device port 10, it has
> + * For example, let's have the IB device port 10, it has
> * attached network device eth0, which has port name attribute
> * pf0vf2, we can deduce the VF number as 2, and set vport index
> * as 3 (2+1). This assigning schema should be changed if the @@ -
> 1595,7 +1595,7 @@ struct mlx5_dev_spawn_data {
> mlx5_set_link_up(eth_dev);
> /*
> * Even though the interrupt handler is not installed yet,
> - * interrupts will still trigger on the asyn_fd from
> + * interrupts will still trigger on the async_fd from
> * Verbs context returned by ibv_open_device().
> */
> mlx5_link_update(eth_dev, 0);
> @@ -1772,7 +1772,7 @@ struct mlx5_dev_spawn_data {
> }
> ibv_match[nd] = NULL;
> if (!nd) {
> - /* No device macthes, just complain and bail out. */
> + /* No device matches, just complain and bail out. */
> mlx5_glue->free_device_list(ibv_list);
> DRV_LOG(WARNING,
> "no Verbs device matches PCI device " PCI_PRI_FMT
> ","
> @@ -1805,7 +1805,7 @@ struct mlx5_dev_spawn_data {
>
> if (np > 1) {
> /*
> - * Signle IB device with multiple ports found,
> + * Single IB device with multiple ports found,
> * it may be E-Switch master device and representors.
> * We have to perform identification trough the ports.
> */
> diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c
> b/drivers/net/mlx5/mlx5_flow_tcf.c
> index 3006f83..fc04c9d 100644
> --- a/drivers/net/mlx5/mlx5_flow_tcf.c
> +++ b/drivers/net/mlx5/mlx5_flow_tcf.c
> @@ -2916,7 +2916,7 @@ struct pedit_parser {
> * VXLAN VNI in 24-bit wire format.
> *
> * @return
> - * VXLAN VNI as a 32-bit integer value in network endian.
> + * VXLAN VNI as a 32-bit integer value in network endianness.
> */
> static inline rte_be32_t
> vxlan_vni_as_be32(const uint8_t vni[3]) @@ -4051,7 +4051,7 @@ struct
> pedit_parser {
> nlh->nlmsg_flags |= NLM_F_ACK;
> ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);
> if (ret <= 0) {
> - /* Message send error occurres. */
> + /* Message send error occurred. */
> rte_errno = errno;
> return -rte_errno;
> }
> @@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] ifindex
> - * Network inferface index to perform cleanup.
> + * Network interface index to perform cleanup.
> */
> static void
> flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf, @@ -
> 4343,7 +4343,7 @@ struct tcf_nlcb_context { }
>
> /**
> - * Collect neigh permament rules on specified network device.
> + * Collect neigh permanent rules on specified network device.
> * This is callback routine called by libmnl mnl_cb_run() in loop for
> * every message in received packet.
> *
> @@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {
> }
> if (!na_mac || !na_ip)
> return 1;
> - /* Neigh rule with permenent attribute found. */
> + /* Neigh rule with permanent attribute found. */
> size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
> MNL_ALIGN(sizeof(struct ndmsg)) +
> SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) + @@ -4431,7 +4431,7
> @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] ifindex
> - * Network inferface index to perform cleanup.
> + * Network interface index to perform cleanup.
> */
> static void
> flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf, @@ -
> 4599,7 +4599,7 @@ struct tcf_nlcb_context {
> * Note that an implicit route is maintained by the kernel due to the
> * presence of a peer address (IFA_ADDRESS).
> *
> - * These rules are used for encapsultion only and allow to assign
> + * These rules are used for encapsulation only and allow to assign
> * the outer tunnel source IP address.
> *
> * @param[in] tcf
> @@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {
>
> /**
> * Releases VXLAN encap rules container by pointer. Decrements the
> - * reference cointer and deletes the container if counter is zero.
> + * reference counter and deletes the container if counter is zero.
> *
> * @param[in] irule
> * VXLAN rule container pointer to release.
> @@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> * @param[in] vtep
> - * Object represinting the network device to delete. Memory
> + * Object representing the network device to delete. Memory
> * allocated for this object is freed by routine.
> */
> static void
> @@ -5268,7 +5268,7 @@ struct tcf_nlcb_context { }
>
> /**
> - * Aqcuire target interface index for VXLAN tunneling encapsulation.
> + * Acquire target interface index for VXLAN tunneling encapsulation.
> *
> * @param[in] tcf
> * Context object initialized by mlx5_flow_tcf_context_create().
> @@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {
> /**
> * Fetch the applied rule handle. This is callback routine called by
> * libmnl mnl_cb_run() in loop for every message in received packet.
> - * When the NLM_F_ECHO flag i sspecified the kernel sends the created
> + * When the NLM_F_ECHO flag is specified the kernel sends the created
> * rule descriptor back to the application and we can retrieve the
> * actual rule handle from updated descriptor.
> *
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-08 6:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 7:40 [dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments Viacheslav Ovsiienko
2019-04-02 7:40 ` Viacheslav Ovsiienko
2019-04-05 8:55 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
2019-04-05 8:55 ` Viacheslav Ovsiienko
2019-04-08 6:00 ` Shahaf Shuler
2019-04-08 6:00 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).