* [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
@ 2019-04-08 12:43 Ori Kam
2019-04-08 12:43 ` Ori Kam
2019-04-10 6:59 ` Shahaf Shuler
0 siblings, 2 replies; 6+ messages in thread
From: Ori Kam @ 2019-04-08 12:43 UTC (permalink / raw)
To: Yongseok Koh, Shahaf Shuler; +Cc: dev, Ori Kam
In case of cross compilation on aarch64 we must add include for
stdlib in order to use the free function.
Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
Signed-off-by: Ori Kam <orika@mellanox.com>
---
drivers/net/mlx5/mlx5_glue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
index f5a6c2e..a508faa 100644
--- a/drivers/net/mlx5/mlx5_glue.c
+++ b/drivers/net/mlx5/mlx5_glue.c
@@ -7,6 +7,7 @@
#include <stdalign.h>
#include <stddef.h>
#include <stdint.h>
+#include <stdlib.h>
/*
* Not needed by this file; included to work around the lack of off_t
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
2019-04-08 12:43 [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64 Ori Kam
@ 2019-04-08 12:43 ` Ori Kam
2019-04-10 6:59 ` Shahaf Shuler
1 sibling, 0 replies; 6+ messages in thread
From: Ori Kam @ 2019-04-08 12:43 UTC (permalink / raw)
To: Yongseok Koh, Shahaf Shuler; +Cc: dev, Ori Kam
In case of cross compilation on aarch64 we must add include for
stdlib in order to use the free function.
Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
Signed-off-by: Ori Kam <orika@mellanox.com>
---
drivers/net/mlx5/mlx5_glue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
index f5a6c2e..a508faa 100644
--- a/drivers/net/mlx5/mlx5_glue.c
+++ b/drivers/net/mlx5/mlx5_glue.c
@@ -7,6 +7,7 @@
#include <stdalign.h>
#include <stddef.h>
#include <stdint.h>
+#include <stdlib.h>
/*
* Not needed by this file; included to work around the lack of off_t
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
2019-04-08 12:43 [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64 Ori Kam
2019-04-08 12:43 ` Ori Kam
@ 2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 17:50 ` Ferruh Yigit
1 sibling, 2 replies; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-10 6:59 UTC (permalink / raw)
To: Ori Kam, Yongseok Koh, ferruh.yigit; +Cc: dev
Monday, April 8, 2019 3:43 PM, Ori Kam:
> Subject: [PATCH] net/mlx5: fix cross compilation on aarch64
>
> In case of cross compilation on aarch64 we must add include for stdlib in
> order to use the free function.
>
> Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
Applied to next-net-mlx, thanks.
Ferruh - you may want to squash to the relevant commit.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
2019-04-10 6:59 ` Shahaf Shuler
@ 2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 17:50 ` Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-10 6:59 UTC (permalink / raw)
To: Ori Kam, Yongseok Koh, ferruh.yigit; +Cc: dev
Monday, April 8, 2019 3:43 PM, Ori Kam:
> Subject: [PATCH] net/mlx5: fix cross compilation on aarch64
>
> In case of cross compilation on aarch64 we must add include for stdlib in
> order to use the free function.
>
> Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
Applied to next-net-mlx, thanks.
Ferruh - you may want to squash to the relevant commit.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 6:59 ` Shahaf Shuler
@ 2019-04-10 17:50 ` Ferruh Yigit
2019-04-10 17:50 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-10 17:50 UTC (permalink / raw)
To: Shahaf Shuler, Ori Kam, Yongseok Koh; +Cc: dev
On 4/10/2019 7:59 AM, Shahaf Shuler wrote:
> Monday, April 8, 2019 3:43 PM, Ori Kam:
>> Subject: [PATCH] net/mlx5: fix cross compilation on aarch64
>>
>> In case of cross compilation on aarch64 we must add include for stdlib in
>> order to use the free function.
>>
>> Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>
> Applied to next-net-mlx, thanks.
> Ferruh - you may want to squash to the relevant commit.
>
I can't squash since the relevant commit already merged into main repo and part
of rc1, merged into next-net as it is.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64
2019-04-10 17:50 ` Ferruh Yigit
@ 2019-04-10 17:50 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-10 17:50 UTC (permalink / raw)
To: Shahaf Shuler, Ori Kam, Yongseok Koh; +Cc: dev
On 4/10/2019 7:59 AM, Shahaf Shuler wrote:
> Monday, April 8, 2019 3:43 PM, Ori Kam:
>> Subject: [PATCH] net/mlx5: fix cross compilation on aarch64
>>
>> In case of cross compilation on aarch64 we must add include for stdlib in
>> order to use the free function.
>>
>> Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule")
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>
> Applied to next-net-mlx, thanks.
> Ferruh - you may want to squash to the relevant commit.
>
I can't squash since the relevant commit already merged into main repo and part
of rc1, merged into next-net as it is.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-10 17:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 12:43 [dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64 Ori Kam
2019-04-08 12:43 ` Ori Kam
2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 6:59 ` Shahaf Shuler
2019-04-10 17:50 ` Ferruh Yigit
2019-04-10 17:50 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).