From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 355FB559A for ; Wed, 24 Aug 2016 18:06:29 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id o80so34726847wme.1 for ; Wed, 24 Aug 2016 09:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=APwe6T0ogdEMQHM+Y3RnFv5JYzl64VVrQekaohcil7I=; b=f8t8aNGuKfbNL7jW6B4BlCv0+HRdiPsZ8FtKeacJDzmtZp3fLRmHjfH27qIHy+xFqG zZe3jJTsvXEk+SLJHxPm5IJ/ehva7rd0XVyl5fFDPBOqh/GVfErIin/haB4hr0i7m7Cn qFeRvlXQ0uC6el8veMhb1CD1WgwEkhFpmkVqkd52jGI3Pb0EuxqNOAVfMptZXXZ5xA28 g1X51MjsIH5G3P0FNLCfo5pxGuj2OirurbZ7Ek0ewL/r0yvYAcMbG1jG0HqlOwRvRr4+ fQzNbPSOsikx0b05KYZqH3XXalxNsgHpe24QHhBCyY2zd9M4l0OhTBC/D2PxAUvIxSho DDeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=APwe6T0ogdEMQHM+Y3RnFv5JYzl64VVrQekaohcil7I=; b=LOY1eY8ZkKmNO2j5i24P3vHqOyDFSHvm3KQYS5FtoJY8UZ9T10GB9nsUxQXmz8cm9G aQZ6MEZ4JR703U/U2c50CBdWzyquEYGPc5XYoSKwnj0cI+H3s6CVSTK9/mABQEYuE7OU GsLOgMClGEWJwtKlcBNC7ZNQO3/J3ce6kXKa081o9MGZFy+xAr3Z3la9N6ViEeO39JNG Jlmzf6ujFwHYb5CITn7asoYiaaqJdc+NbyBNETj521ZTOubyRNnzLOLGjmRxJWhvdR8J bhtH/RgKgk6+622e2LjSfkZ5SiR53ZAwAJNc4GMOQF9wfVFgLOrD3X1UQyq6QwMWiN6s gTtQ== X-Gm-Message-State: AEkoouu1h2gTB0E9sTLlOcd0/w9dUy3nQaX/4VfVdG1uD5oa73nU+BailOJHQDb4L+Pqw+cu X-Received: by 10.194.186.166 with SMTP id fl6mr3433029wjc.44.1472054788940; Wed, 24 Aug 2016 09:06:28 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g67sm11396511wme.5.2016.08.24.09.06.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Aug 2016 09:06:27 -0700 (PDT) From: Thomas Monjalon To: Nikhil Rao Cc: dev@dpdk.org, john.mcnamara@intel.com Date: Wed, 24 Aug 2016 18:06:26 +0200 Message-ID: <1554992.ZnaOu0qKpl@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1470030588-7825-1-git-send-email-nikhil.rao@intel.com> References: <1470030588-7825-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 16:06:29 -0000 2016-08-01 11:19, Nikhil Rao: > This patch fixes a typo in the eth device API doc, device > config. not stored between calls to rte_eth_dev_start/stop() > should be restored before a call to rte_eth_dev_start() > instead of after a call to rte_eth_dev_start(). > > Signed-off-by: Nikhil Rao [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -118,7 +118,7 @@ > * - NIC queue statistics mappings > * > * Any other configuration will not be stored and will need to be re-entered > - * after a call to rte_eth_dev_start(). > + * before a call to rte_eth_dev_start(). I have some doubts about this and above comment. I think we should give move details in the comments of the functions, instead of this (not often read) global comment.