From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 73C721B58E; Wed, 17 Apr 2019 03:59:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 18:59:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="132028410" Received: from unknown (HELO npg-dpdk-cvl-yingwang-117d94.sh.intel.com) ([10.67.117.94]) by orsmga007.jf.intel.com with ESMTP; 16 Apr 2019 18:59:55 -0700 From: Wang Ying A To: wenzhuo.lu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, ramirose@gmail.com, Wang Ying A , stable@dpdk.org Date: Wed, 17 Apr 2019 09:47:51 +0800 Message-Id: <1555465672-288172-2-git-send-email-ying.a.wang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1555465672-288172-1-git-send-email-ying.a.wang@intel.com> References: <1555077139-244831-2-git-send-email-ying.a.wang@intel.com> <1555465672-288172-1-git-send-email-ying.a.wang@intel.com> Subject: [dpdk-dev] [PATCH v2 1/2] net/ice: fix wrong type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 01:59:58 -0000 Variable "status" should be defined as "enum ice_status" instead of "uint16_t". This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: stable@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 0946b19..3263337 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2757,7 +2757,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; uint8_t pmask; - uint16_t status; + enum ice_status status; pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ -2773,7 +2773,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; - uint16_t status; + enum ice_status status; uint8_t pmask; pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | @@ -2791,7 +2791,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; uint8_t pmask; - uint16_t status; + enum ice_status status; pmask = ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ -2806,7 +2806,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; - uint16_t status; + enum ice_status status; uint8_t pmask; if (dev->data->promiscuous == 1) -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 96D01A00E6 for ; Wed, 17 Apr 2019 03:59:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 657C11B58E; Wed, 17 Apr 2019 03:59:59 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 73C721B58E; Wed, 17 Apr 2019 03:59:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 18:59:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="132028410" Received: from unknown (HELO npg-dpdk-cvl-yingwang-117d94.sh.intel.com) ([10.67.117.94]) by orsmga007.jf.intel.com with ESMTP; 16 Apr 2019 18:59:55 -0700 From: Wang Ying A To: wenzhuo.lu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, ramirose@gmail.com, Wang Ying A , stable@dpdk.org Date: Wed, 17 Apr 2019 09:47:51 +0800 Message-Id: <1555465672-288172-2-git-send-email-ying.a.wang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1555465672-288172-1-git-send-email-ying.a.wang@intel.com> References: <1555077139-244831-2-git-send-email-ying.a.wang@intel.com> <1555465672-288172-1-git-send-email-ying.a.wang@intel.com> Subject: [dpdk-dev] [PATCH v2 1/2] net/ice: fix wrong type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190417014751.95GNqZOYIaGESX2iX4TS0krWPhRaInIa4OhtYkqDVVc@z> Variable "status" should be defined as "enum ice_status" instead of "uint16_t". This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: stable@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 0946b19..3263337 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2757,7 +2757,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; uint8_t pmask; - uint16_t status; + enum ice_status status; pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ -2773,7 +2773,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; - uint16_t status; + enum ice_status status; uint8_t pmask; pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | @@ -2791,7 +2791,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; uint8_t pmask; - uint16_t status; + enum ice_status status; pmask = ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ -2806,7 +2806,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_vsi *vsi = pf->main_vsi; - uint16_t status; + enum ice_status status; uint8_t pmask; if (dev->data->promiscuous == 1) -- 1.8.3.1